{"id":26973,"url":"https://patchwork.libcamera.org/api/patches/26973/?format=json","web_url":"https://patchwork.libcamera.org/patch/26973/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-10-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:26","name":"[RFC,v1,09/27] libcamera: pipeline: ipu3: Remove `setRequest()` calls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d15686c2939100fa14b170450d7659e182e950ca","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26973/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26973/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26973/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9538FC3304\n\tfor ;\n\tThu, 18 Jun 2026 12:39:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45B5262C6E;\n\tThu, 18 Jun 2026 14:39:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33BDB62C71\n\tfor ;\n\tThu, 18 Jun 2026 14:38:50 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F3842F8\n\tfor ;\n\tThu, 18 Jun 2026 14:38:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B/Khb1/g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786295;\n\tbh=VQWdVx/eE22959ha/DrBlHrz40UMBHdLJiA9tE+UnuQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=B/Khb1/gmt10W6X949kyEFk6XWa/E+f8b6O1elrw2aQtFT7CJfRqswrz47qpVt7jM\n\tEV7n71tIY5Dxo8m0cgQBKFXCTw3OCAlGvGvnBdEhhhYgC2i/+gLnUzp6sE+AEhi2nY\n\t40Ar5cZH7nw+c+gHFpjfIZHU3JB+KrcCb0ttCO7k=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 09/27] libcamera: pipeline: ipu3: Remove\n\t`setRequest()` calls","Date":"Thu, 18 Jun 2026 14:38:26 +0200","Message-ID":"<20260618123844.656396-10-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"No component queries the associated request of any buffer, so\nsetting it is unnecessary.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 3 +--\n src/libcamera/pipeline/ipu3/cio2.h | 3 +--\n src/libcamera/pipeline/ipu3/frames.cpp | 3 ---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 4 files changed, 3 insertions(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex b6fe84fe70..7481b2686d 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -378,7 +378,7 @@ int CIO2Device::stop()\n \treturn ret;\n }\n \n-FrameBuffer *CIO2Device::queueBuffer(Request *request, FrameBuffer *rawBuffer)\n+FrameBuffer *CIO2Device::queueBuffer(FrameBuffer *rawBuffer)\n {\n \tFrameBuffer *buffer = rawBuffer;\n \n@@ -391,7 +391,6 @@ FrameBuffer *CIO2Device::queueBuffer(Request *request, FrameBuffer *rawBuffer)\n \n \t\tbuffer = availableBuffers_.front();\n \t\tavailableBuffers_.pop();\n-\t\tbuffer->_d()->setRequest(request);\n \t}\n \n \tint ret = output_->queueBuffer(buffer);\ndiff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\nindex d844cb7ae8..91651a1640 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.h\n+++ b/src/libcamera/pipeline/ipu3/cio2.h\n@@ -22,7 +22,6 @@ class CameraSensor;\n class FrameBuffer;\n class MediaDevice;\n class PixelFormat;\n-class Request;\n class Size;\n class SizeRange;\n struct StreamConfiguration;\n@@ -56,7 +55,7 @@ public:\n \tCameraSensor *sensor() { return sensor_.get(); }\n \tconst CameraSensor *sensor() const { return sensor_.get(); }\n \n-\tFrameBuffer *queueBuffer(Request *request, FrameBuffer *rawBuffer);\n+\tFrameBuffer *queueBuffer(FrameBuffer *rawBuffer);\n \tvoid tryReturnBuffer(FrameBuffer *buffer);\n \tSignal &bufferReady() { return output_->bufferReady; }\n \tSignal &frameStart() { return csi2_->frameStart; }\ndiff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex 4232e976a9..67ec922e49 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -58,9 +58,6 @@ IPU3Frames::Info *IPU3Frames::create(Request *request)\n \tFrameBuffer *paramBuffer = availableParamBuffers_.front();\n \tFrameBuffer *statBuffer = availableStatBuffers_.front();\n \n-\tparamBuffer->_d()->setRequest(request);\n-\tstatBuffer->_d()->setRequest(request);\n-\n \tavailableParamBuffers_.pop();\n \tavailableStatBuffers_.pop();\n \ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 560fccd8c0..af1b79d708 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -810,7 +810,7 @@ void IPU3CameraData::queuePendingRequests()\n \t\t * otherwise.\n \t\t */\n \t\tFrameBuffer *reqRawBuffer = request->findBuffer(&rawStream_);\n-\t\tFrameBuffer *rawBuffer = cio2_.queueBuffer(request, reqRawBuffer);\n+\t\tFrameBuffer *rawBuffer = cio2_.queueBuffer(reqRawBuffer);\n \t\t/*\n \t\t * \\todo If queueBuffer fails in queuing a buffer to the device,\n \t\t * report the request as error by cancelling the request and\n","prefixes":["RFC","v1","09/27"]}