[{"id":39171,"web_url":"https://patchwork.libcamera.org/comment/39171/","msgid":"<20260618115753.GB3345533@killaraus.ideasonboard.com>","date":"2026-06-18T11:57:53","subject":"Re: [PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX678\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jai,\n\nThank you for the patch.\n\nOn Thu, Jun 18, 2026 at 05:18:39PM +0530, Jai Luthra wrote:\n> Add Sony IMX678 properties, along with the black level and gain model\n> through a libipa camera sensor helper.\n> \n> The test patterns are intentionally left empty, as they are similar to\n> IMX335/IMX283 and don't map very well to libcamera's enum values.\n\nWe will probably need to introduce more test patterns in the future.\n\n> Signed-off-by: Jai Luthra \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 10 ++++++++++\n> 2 files changed, 22 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 3028197e1..9ab7a52f2 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -642,6 +642,18 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> \n> +class CameraSensorHelperImx678 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx678()\n> +\t{\n> +\t\t/* From datasheet: 0x32 at 10bits. */\n> +\t\tblackLevel_ = 3200;\n> +\t\tgain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx678\", CameraSensorHelperImx678)\n> +\n> class CameraSensorHelperImx708 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index b217363d8..28043150e 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -309,6 +309,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t.hblankDelay = 3\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"imx678\", {\n> +\t\t\t.unitCellSize = { 2000, 2000 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t\t.sensorDelays = {\n> +\t\t\t\t.exposureDelay = 2,\n> +\t\t\t\t.gainDelay = 2,\n> +\t\t\t\t.vblankDelay = 2,\n> +\t\t\t\t.hblankDelay = 2\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"imx708\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8DD4C3261\n\tfor ;\n\tThu, 18 Jun 2026 11:57:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F38CD62988;\n\tThu, 18 Jun 2026 13:57:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D100662980\n\tfor ;\n\tThu, 18 Jun 2026 13:57:55 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 827B7741;\n\tThu, 18 Jun 2026 13:57:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ff2TSTMW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781783840;\n\tbh=AC3gycV8Mf0TGGjiDXJVM0kHZG44Nx1YWjmCiLcIXmA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ff2TSTMWPSwhRnCvaVmiW9bGiNUBryRjdFe3MdRIQTy8Ewxl6ziNKkMphX8Q7ZxA2\n\t4ruhPxx21dBKt3XEYMiYppYXoPTFZnRZ4RM97u2ohgcgHi+DccLemJWli1yD25IC+D\n\t0hC3LTgkcr3Dwr9S5zh/Zmepr19mdr+5kZdV5Ivo=","Date":"Thu, 18 Jun 2026 14:57:53 +0300","From":"Laurent Pinchart ","To":"Jai Luthra ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX678\n\tproperties","Message-ID":"<20260618115753.GB3345533@killaraus.ideasonboard.com>","References":"<20260618-imx678-v1-0-646e09a63692@ideasonboard.com>\n\t<20260618-imx678-v1-1-646e09a63692@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260618-imx678-v1-1-646e09a63692@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39175,"web_url":"https://patchwork.libcamera.org/comment/39175/","msgid":"<178179070884.861173.16652212142032284132@ping.linuxembedded.co.uk>","date":"2026-06-18T13:51:48","subject":"Re: [PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX678\n\tproperties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jai Luthra (2026-06-18 12:48:39)\n> Add Sony IMX678 properties, along with the black level and gain model\n> through a libipa camera sensor helper.\n> \n> The test patterns are intentionally left empty, as they are similar to\n> IMX335/IMX283 and don't map very well to libcamera's enum values.\n> \n> Signed-off-by: Jai Luthra \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 10 ++++++++++\n> 2 files changed, 22 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 3028197e1..9ab7a52f2 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -642,6 +642,18 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> \n> +class CameraSensorHelperImx678 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperImx678()\n> + {\n> + /* From datasheet: 0x32 at 10bits. */\n> + blackLevel_ = 3200;\n> + gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx678\", CameraSensorHelperImx678)\n> +\n> class CameraSensorHelperImx708 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index b217363d8..28043150e 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -309,6 +309,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .hblankDelay = 3\n> },\n> } },\n> + { \"imx678\", {\n> + .unitCellSize = { 2000, 2000 },\n> + .testPatternModes = {},\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> { \"imx708\", {\n> .unitCellSize = { 1400, 1400 },\n> .testPatternModes = {\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D27AFC3261\n\tfor ;\n\tThu, 18 Jun 2026 13:51:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 818906298D;\n\tThu, 18 Jun 2026 15:51:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E1A861754\n\tfor ;\n\tThu, 18 Jun 2026 15:51:51 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 417DA2F8;\n\tThu, 18 Jun 2026 15:51:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GXvRi7Gr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781790676;\n\tbh=n3OQ6YsT3YwaGfXg+jRwl25KthagJdv+0LTm/2NznU8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GXvRi7GrhqNuL9+xTipDjIi66PUS7hd6IcoPDG/E/9oFP5Ky8cp4eyAhf0gR/lYDQ\n\t7nyfsBy0C3Ln1e/2uYLEo/XPC2WrIJNpZfEu7XQoNw0A/qEJkLvVWwaV+dUC9/If6Q\n\tPGo5NOPkysN3VcIeIajs2kHrMValxjHIbfyB/n1Y=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260618-imx678-v1-1-646e09a63692@ideasonboard.com>","References":"<20260618-imx678-v1-0-646e09a63692@ideasonboard.com>\n\t<20260618-imx678-v1-1-646e09a63692@ideasonboard.com>","Subject":"Re: [PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX678\n\tproperties","From":"Kieran Bingham ","Cc":"Jai Luthra ","To":"Jai Luthra ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 18 Jun 2026 14:51:48 +0100","Message-ID":"<178179070884.861173.16652212142032284132@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]