[{"id":3530,"web_url":"https://patchwork.libcamera.org/comment/3530/","msgid":"<20200120113311.uxdathmeudsncjy5@uno.localdomain>","date":"2020-01-20T11:33:11","subject":"Re: [libcamera-devel] [PATCH 04/19] libcamera: log: Print the\n\tthread ID in the log","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Mon, Jan 20, 2020 at 02:24:22AM +0200, Laurent Pinchart wrote:\n> The current thread ID is useful when debugging concurrency issues. Print\n> it in log messages. The syslog target is left out as the thread ID would\n> have little use there, and partly duplicates the process ID.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nThanks\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\n> ---\n>  src/libcamera/log.cpp | 4 +++-\n>  1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index f4eb8c11adc3..1dac4666b435 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -22,6 +22,7 @@\n>\n>  #include <libcamera/logging.h>\n>\n> +#include \"thread.h\"\n>  #include \"utils.h\"\n>\n>  /**\n> @@ -196,7 +197,8 @@ void LogOutput::write(const LogMessage &msg)\n>  \t\tbreak;\n>  \tcase LoggingTargetStream:\n>  \tcase LoggingTargetFile:\n> -\t\tstr = \"[\" + utils::time_point_to_string(msg.timestamp()) + \"]\"\n> +\t\tstr = \"[\" + utils::time_point_to_string(msg.timestamp()) + \"] [\"\n> +\t\t    + std::to_string(Thread::currentId()) + \"]\"\n>  \t\t    + log_severity_name(msg.severity()) + \" \"\n>  \t\t    + msg.category().name() + \" \" + msg.fileInfo() + \" \"\n>  \t\t    + msg.msg();\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCDC5600F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jan 2020 12:30:40 +0100 (CET)","from uno.localdomain (93-34-114-233.ip49.fastwebnet.it\n\t[93.34.114.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 7866B60012;\n\tMon, 20 Jan 2020 11:30:40 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","Date":"Mon, 20 Jan 2020 12:33:11 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200120113311.uxdathmeudsncjy5@uno.localdomain>","References":"<20200120002437.6633-1-laurent.pinchart@ideasonboard.com>\n\t<20200120002437.6633-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5jzgbw5c4rughhvw\"","Content-Disposition":"inline","In-Reply-To":"<20200120002437.6633-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 04/19] libcamera: log: Print the\n\tthread ID in the log","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 20 Jan 2020 11:30:41 -0000"}}]