[{"id":39620,"web_url":"https://patchwork.libcamera.org/comment/39620/","msgid":"<178341378390.292172.4384837766876638183@neptunite.rasen.tech>","date":"2026-07-07T08:43:03","subject":"Re: [PATCH v1 2/2] libcamera: ipa: core: Rename\n\tIPACameraSensorInfo::activeAreaSize to pixelArraySize","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2026-06-16 21:08:15)\n> Rename IPACameraSensorInfo::activeAreaSize to\n> IPACameraSensorInfo::pixelArraySize to better describe the content.\n> \n> Signed-off-by: Stefan Klug \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/ipa/core.mojom | 4 ++--\n> src/ipa/rkisp1/algorithms/lsc.cpp | 6 +-----\n> src/ipa/rpi/common/ipa_base.cpp | 4 ++--\n> src/libcamera/sensor/camera_sensor_legacy.cpp | 2 +-\n> src/libcamera/sensor/camera_sensor_raw.cpp | 2 +-\n> 5 files changed, 7 insertions(+), 11 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\n> index 5da780f5d256..f2e9b0997819 100644\n> --- a/include/libcamera/ipa/core.mojom\n> +++ b/include/libcamera/ipa/core.mojom\n> @@ -153,7 +153,7 @@ module libcamera;\n> */\n> \n> /**\n> - * \\var IPACameraSensorInfo::activeAreaSize\n> + * \\var IPACameraSensorInfo::pixelArraySize\n> * \\brief The size of the physical pixel array of the sensor in pixels\n> */\n> \n> @@ -243,7 +243,7 @@ struct IPACameraSensorInfo {\n> uint32 bitsPerPixel;\n> uint32 cfaPattern;\n> \n> - Size activeAreaSize;\n> + Size pixelArraySize;\n> Rectangle analogCrop;\n> Size outputSize;\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 25f7c512b35c..a3029414ed6e 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -401,11 +401,7 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> ret = loader.parseLscData(yamlSets, lscData);\n> } else if (type == \"polynomial\") {\n> LOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n> - /*\n> - * \\todo: Most likely the reference frame should be native_size.\n> - * Let's wait how the internal discussions progress.\n> - */\n> - auto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize);\n> + auto loader = LscPolynomialLoader(context.sensorInfo.pixelArraySize);\n> ret = loader.parseLscData(yamlSets, lscData);\n> } else {\n> LOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index dacafa578c98..fc0eb3bf4b5c 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -567,8 +567,8 @@ void IpaBase::setMode(const IPACameraSensorInfo &sensorInfo)\n> mode_.bitdepth = sensorInfo.bitsPerPixel;\n> mode_.width = sensorInfo.outputSize.width;\n> mode_.height = sensorInfo.outputSize.height;\n> - mode_.sensorWidth = sensorInfo.activeAreaSize.width;\n> - mode_.sensorHeight = sensorInfo.activeAreaSize.height;\n> + mode_.sensorWidth = sensorInfo.pixelArraySize.width;\n> + mode_.sensorHeight = sensorInfo.pixelArraySize.height;\n> mode_.cropX = sensorInfo.analogCrop.x;\n> mode_.cropY = sensorInfo.analogCrop.y;\n> mode_.pixelRate = sensorInfo.pixelRate;\n> diff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> index 482e387d3b24..e3e97b5b9ef3 100644\n> --- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> @@ -880,7 +880,7 @@ int CameraSensorLegacy::sensorInfo(IPACameraSensorInfo *info) const\n> * rectangle needs to be re-read as it depends on the sensor\n> * configuration.\n> */\n> - info->activeAreaSize = { activeArea_.width, activeArea_.height };\n> + info->pixelArraySize = { pixelArraySize_.width, pixelArraySize_.height };\n> \n> /*\n> * \\todo Support for retreiving the crop rectangle is scheduled to\n> diff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\n> index 410edeb68983..62da78acc513 100644\n> --- a/src/libcamera/sensor/camera_sensor_raw.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n> @@ -998,7 +998,7 @@ int CameraSensorRaw::sensorInfo(IPACameraSensorInfo *info) const\n> * rectangle needs to be re-read as it depends on the sensor\n> * configuration.\n> */\n> - info->activeAreaSize = { activeArea_.width, activeArea_.height };\n> + info->pixelArraySize = { activeArea_.width, activeArea_.height };\n> \n> int ret = subdev_->getSelection(streams_.image.sink, V4L2_SEL_TGT_CROP,\n> &info->analogCrop);\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFC28C3323\n\tfor ;\n\tTue, 7 Jul 2026 08:43:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97D4066063;\n\tTue, 7 Jul 2026 10:43:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 929D166057\n\tfor ;\n\tTue, 7 Jul 2026 10:43:09 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:641e:b4cb:119f:3a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4D7D8673;\n\tTue, 7 Jul 2026 10:42:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ghbMV/Zs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783413740;\n\tbh=5H8samUP0eHln/8BJ2c0P0W5rOy8CtF4cvVcg35Dzlg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ghbMV/Zs9RROmskgskXLp3N2WztzYBzoawHiVdPf1PpVG6SvKmzxmuksbWZGBaRd4\n\tioVIwztROXfPq6e+Cvw5j70plJQlwdp+j4dFOHyn42TSn+qEPSt+hk3cKCyGJrVX/8\n\tIcQ/McaQ38bvzlAUQAu9QT1MQU8+yiO1pNpW1mxU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260616120828.375547-3-stefan.klug@ideasonboard.com>","References":"<20260616120828.375547-1-stefan.klug@ideasonboard.com>\n\t<20260616120828.375547-3-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 2/2] libcamera: ipa: core: Rename\n\tIPACameraSensorInfo::activeAreaSize to pixelArraySize","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 07 Jul 2026 17:43:03 +0900","Message-ID":"<178341378390.292172.4384837766876638183@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]