{"id":26906,"url":"https://patchwork.libcamera.org/api/patches/26906/?format=json","web_url":"https://patchwork.libcamera.org/patch/26906/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260616120828.375547-3-stefan.klug@ideasonboard.com>","date":"2026-06-16T12:08:15","name":"[v1,2/2] libcamera: ipa: core: Rename IPACameraSensorInfo::activeAreaSize to pixelArraySize","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"21c1f4d00762dcc6c58f7c95a804256d81c48175","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26906/mbox/","series":[{"id":5998,"url":"https://patchwork.libcamera.org/api/series/5998/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5998","date":"2026-06-16T12:08:13","name":"Clarify rectangle behavior","version":1,"mbox":"https://patchwork.libcamera.org/series/5998/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26906/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26906/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F41F8C3261\n\tfor ;\n\tTue, 16 Jun 2026 12:08:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB523625C7;\n\tTue, 16 Jun 2026 14:08:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11002625BE\n\tfor ;\n\tTue, 16 Jun 2026 14:08:51 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:f9ec:e24d:190b:e780])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C5EF448;\n\tTue, 16 Jun 2026 14:08:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kGg0GnrE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781611697;\n\tbh=C/I69GSC4xY5D/ERQJaGTeiu1kqenc4C47Y0yml3MV0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kGg0GnrEyXFcGrs6jcOjEOYAKIoanyuzgRJB1wrzdxYN8MsYNwWbs9LxwqU1Z5te6\n\tCy5xYN36K9QR787PQUHjiVKKIlVDHdraS89N2Ya3CdVlCevADHIFl5Io8jYSn4POwm\n\t9FsQ4clygQWyrtMuTpYZ6fOi07NLfUhADLY/UP2Q=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 2/2] libcamera: ipa: core: Rename\n\tIPACameraSensorInfo::activeAreaSize to pixelArraySize","Date":"Tue, 16 Jun 2026 14:08:15 +0200","Message-ID":"<20260616120828.375547-3-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260616120828.375547-1-stefan.klug@ideasonboard.com>","References":"<20260616120828.375547-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename IPACameraSensorInfo::activeAreaSize to\nIPACameraSensorInfo::pixelArraySize to better describe the content.\n\nSigned-off-by: Stefan Klug \n---\n include/libcamera/ipa/core.mojom | 4 ++--\n src/ipa/rkisp1/algorithms/lsc.cpp | 6 +-----\n src/ipa/rpi/common/ipa_base.cpp | 4 ++--\n src/libcamera/sensor/camera_sensor_legacy.cpp | 2 +-\n src/libcamera/sensor/camera_sensor_raw.cpp | 2 +-\n 5 files changed, 7 insertions(+), 11 deletions(-)","diff":"diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\nindex 5da780f5d256..f2e9b0997819 100644\n--- a/include/libcamera/ipa/core.mojom\n+++ b/include/libcamera/ipa/core.mojom\n@@ -153,7 +153,7 @@ module libcamera;\n */\n \n /**\n- * \\var IPACameraSensorInfo::activeAreaSize\n+ * \\var IPACameraSensorInfo::pixelArraySize\n * \\brief The size of the physical pixel array of the sensor in pixels\n */\n \n@@ -243,7 +243,7 @@ struct IPACameraSensorInfo {\n \tuint32 bitsPerPixel;\n \tuint32 cfaPattern;\n \n-\tSize activeAreaSize;\n+\tSize pixelArraySize;\n \tRectangle analogCrop;\n \tSize outputSize;\n \ndiff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 25f7c512b35c..a3029414ed6e 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -401,11 +401,7 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n \t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else if (type == \"polynomial\") {\n \t\tLOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n-\t\t/*\n-\t\t * \\todo: Most likely the reference frame should be native_size.\n-\t\t * Let's wait how the internal discussions progress.\n-\t\t */\n-\t\tauto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize);\n+\t\tauto loader = LscPolynomialLoader(context.sensorInfo.pixelArraySize);\n \t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else {\n \t\tLOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\ndiff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex dacafa578c98..fc0eb3bf4b5c 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -567,8 +567,8 @@ void IpaBase::setMode(const IPACameraSensorInfo &sensorInfo)\n \tmode_.bitdepth = sensorInfo.bitsPerPixel;\n \tmode_.width = sensorInfo.outputSize.width;\n \tmode_.height = sensorInfo.outputSize.height;\n-\tmode_.sensorWidth = sensorInfo.activeAreaSize.width;\n-\tmode_.sensorHeight = sensorInfo.activeAreaSize.height;\n+\tmode_.sensorWidth = sensorInfo.pixelArraySize.width;\n+\tmode_.sensorHeight = sensorInfo.pixelArraySize.height;\n \tmode_.cropX = sensorInfo.analogCrop.x;\n \tmode_.cropY = sensorInfo.analogCrop.y;\n \tmode_.pixelRate = sensorInfo.pixelRate;\ndiff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex 482e387d3b24..e3e97b5b9ef3 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -880,7 +880,7 @@ int CameraSensorLegacy::sensorInfo(IPACameraSensorInfo *info) const\n \t * rectangle needs to be re-read as it depends on the sensor\n \t * configuration.\n \t */\n-\tinfo->activeAreaSize = { activeArea_.width, activeArea_.height };\n+\tinfo->pixelArraySize = { pixelArraySize_.width, pixelArraySize_.height };\n \n \t/*\n \t * \\todo Support for retreiving the crop rectangle is scheduled to\ndiff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\nindex 410edeb68983..62da78acc513 100644\n--- a/src/libcamera/sensor/camera_sensor_raw.cpp\n+++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n@@ -998,7 +998,7 @@ int CameraSensorRaw::sensorInfo(IPACameraSensorInfo *info) const\n \t * rectangle needs to be re-read as it depends on the sensor\n \t * configuration.\n \t */\n-\tinfo->activeAreaSize = { activeArea_.width, activeArea_.height };\n+\tinfo->pixelArraySize = { activeArea_.width, activeArea_.height };\n \n \tint ret = subdev_->getSelection(streams_.image.sink, V4L2_SEL_TGT_CROP,\n \t\t\t\t\t&info->analogCrop);\n","prefixes":["v1","2/2"]}