[{"id":39101,"web_url":"https://patchwork.libcamera.org/comment/39101/","msgid":"<f41d2e21-47fe-4dcb-ae64-5eb49a9c5696@ideasonboard.com>","date":"2026-06-16T08:30:15","subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 16. 8:41 keltezéssel, Daniel Scally írta:\n> Add an instance of IPACameraSensorInfo to the IPAContext and fill it\n> during IPAIPU3::init(). This will allow us to pass sensor information\n> to algorithms at init time.\n> \n> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n> ---\n>   src/ipa/ipu3/ipa_context.cpp | 3 +++\n>   src/ipa/ipu3/ipa_context.h   | 3 +++\n>   src/ipa/ipu3/ipu3.cpp        | 1 +\n>   3 files changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 7152d070d3ab1bc463fdaad437d5e1c1b87ce25c..7fcfd5e0e4ade92521cc2914dd07113235af8e45 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -54,6 +54,9 @@ namespace libcamera::ipa::ipu3 {\n>    *\n>    * \\var IPAContext::ctrlMap\n>    * \\brief A ControlInfoMap::Map of controls populated by the algorithms\n> + *\n> + * \\var IPAContext::sensorInfo\n> + * \\brief An IPACameraSensorInfo instance holding information about the sensor\n>    */\n> \n>   /**\n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> index 1eaaac82da0e3ad5bed0749c39d9dad8c585cab0..f157f223cbb3119f108d768b14fca514ac5661ca 100644\n> --- a/src/ipa/ipu3/ipa_context.h\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -15,6 +15,8 @@\n>   #include <libcamera/controls.h>\n>   #include <libcamera/geometry.h>\n> \n> +#include <libcamera/ipa/core_ipa_interface.h>\n> +\n>   #include <libipa/awb.h>\n>   #include <libipa/ccm.h>\n>   #include <libipa/fc_queue.h>\n> @@ -93,6 +95,7 @@ struct IPAContext {\n>   \tFCQueue<IPAFrameContext> frameContexts;\n> \n>   \tControlInfoMap::Map ctrlMap;\n> +\tIPACameraSensorInfo sensorInfo;\n>   };\n> \n>   } /* namespace ipa::ipu3 */\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 4bdc4b7677fe9703fb968ca91967c68742454514..0827ad207c9d89b8af4887f609fe08881612ab96 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -313,6 +313,7 @@ int IPAIPU3::init(const IPASettings &settings,\n>   \tcontext_.configuration = {};\n>   \tcontext_.configuration.sensor.lineDuration =\n>   \t\tsensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n> +\tcontext_.sensorInfo = sensorInfo;\n\nThere is already a `sensorInfo_` member in `IPAIPU3`. Could we replace\nthat with this one?\n\n\n> \n>   \t/* Load the tuning data file. */\n>   \tFile file(settings.configurationFile);\n> \n> --\n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63A5DC3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Jun 2026 08:30:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 184BD625B0;\n\tTue, 16 Jun 2026 10:30:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0883461754\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jun 2026 10:30:27 +0200 (CEST)","from [192.168.33.27] (185.221.142.169.nat.pool.zt.hu\n\t[185.221.142.169])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A28562EC;\n\tTue, 16 Jun 2026 10:29:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kOyXKGRa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781598593;\n\tbh=pSZdh9xr/PcWipTCkpZQpXDw/LougKf9XqV99Aeut1A=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=kOyXKGRad+6H0XlewuAvqteNBYz1aqUJf47z9rLFH2XIH7GvSzAMNuA3ODtdc2OSp\n\tITSNWZdEai5q/ffu1T+s8pOl3E3Z+JrB+nNQ/ldFnu9DfVeBg7r2VHvJ+vtwcuLVnT\n\t4xpYL7FYGlDyavXbGT+LiJ4dLgUdIb5rg1Irknqo=","Message-ID":"<f41d2e21-47fe-4dcb-ae64-5eb49a9c5696@ideasonboard.com>","Date":"Tue, 16 Jun 2026 10:30:15 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","To":"Daniel Scally <dan.scally@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>\n\t<YFX4RY8a2gvETdM9ieqDCGQUBVlSZj4-bmDX04nX1ogkVIX26aPV4KnYqXwy6tpb1EbIJ0FR-Au4Io52TE_HVA==@protonmail.internalid>\n\t<20260616-ipu3-libipa-rework-v1-9-d4448b54f1d8@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260616-ipu3-libipa-rework-v1-9-d4448b54f1d8@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39191,"web_url":"https://patchwork.libcamera.org/comment/39191/","msgid":"<6605f432-f3a8-490e-8312-7c0322d79c96@ideasonboard.com>","date":"2026-06-19T09:38:25","subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Barnabas\n\nOn 16/06/2026 09:30, Barnabás Pőcze wrote:\n> 2026. 06. 16. 8:41 keltezéssel, Daniel Scally írta:\n>> Add an instance of IPACameraSensorInfo to the IPAContext and fill it\n>> during IPAIPU3::init(). This will allow us to pass sensor information\n>> to algorithms at init time.\n>>\n>> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n>> ---\n>>   src/ipa/ipu3/ipa_context.cpp | 3 +++\n>>   src/ipa/ipu3/ipa_context.h   | 3 +++\n>>   src/ipa/ipu3/ipu3.cpp        | 1 +\n>>   3 files changed, 7 insertions(+)\n>>\n>> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n>> index 7152d070d3ab1bc463fdaad437d5e1c1b87ce25c..7fcfd5e0e4ade92521cc2914dd07113235af8e45 100644\n>> --- a/src/ipa/ipu3/ipa_context.cpp\n>> +++ b/src/ipa/ipu3/ipa_context.cpp\n>> @@ -54,6 +54,9 @@ namespace libcamera::ipa::ipu3 {\n>>    *\n>>    * \\var IPAContext::ctrlMap\n>>    * \\brief A ControlInfoMap::Map of controls populated by the algorithms\n>> + *\n>> + * \\var IPAContext::sensorInfo\n>> + * \\brief An IPACameraSensorInfo instance holding information about the sensor\n>>    */\n>>\n>>   /**\n>> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n>> index 1eaaac82da0e3ad5bed0749c39d9dad8c585cab0..f157f223cbb3119f108d768b14fca514ac5661ca 100644\n>> --- a/src/ipa/ipu3/ipa_context.h\n>> +++ b/src/ipa/ipu3/ipa_context.h\n>> @@ -15,6 +15,8 @@\n>>   #include <libcamera/controls.h>\n>>   #include <libcamera/geometry.h>\n>>\n>> +#include <libcamera/ipa/core_ipa_interface.h>\n>> +\n>>   #include <libipa/awb.h>\n>>   #include <libipa/ccm.h>\n>>   #include <libipa/fc_queue.h>\n>> @@ -93,6 +95,7 @@ struct IPAContext {\n>>       FCQueue<IPAFrameContext> frameContexts;\n>>\n>>       ControlInfoMap::Map ctrlMap;\n>> +    IPACameraSensorInfo sensorInfo;\n>>   };\n>>\n>>   } /* namespace ipa::ipu3 */\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index 4bdc4b7677fe9703fb968ca91967c68742454514..0827ad207c9d89b8af4887f609fe08881612ab96 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -313,6 +313,7 @@ int IPAIPU3::init(const IPASettings &settings,\n>>       context_.configuration = {};\n>>       context_.configuration.sensor.lineDuration =\n>>           sensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n>> +    context_.sensorInfo = sensorInfo;\n> \n> There is already a `sensorInfo_` member in `IPAIPU3`. Could we replace\n> that with this one?\n\nYes I think so...in fact when it's used in ::configure() it just repeats the operations here. I'll \ndrop them from ::configure() and remove that member in the v2 of this patch\n> \n> \n>>\n>>       /* Load the tuning data file. */\n>>       File file(settings.configurationFile);\n>>\n>> -- \n>> 2.43.0\n>>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1704CC3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Jun 2026 09:38:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4D0E656C0;\n\tFri, 19 Jun 2026 11:38:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C7CA61F3F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Jun 2026 11:38:28 +0200 (CEST)","from [192.168.0.43]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F3981494;\n\tFri, 19 Jun 2026 11:37:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RnDZd3Rv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781861872;\n\tbh=TuVat5AV1BY40IrRTczg03NoiZ7NvfpyDUvHqmrOAGI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=RnDZd3RvwSFXkGQ03H6KsnZf/OHr/r6wri73YdoIjnUEW+qKLUcGwrQaSKPdPOkgD\n\tzV/1abH+hTFEWBSRI4nFT5vbcHPxwVwS+3lncuuDKqus7c7Iahbd0Ir/jObvxCZ7Ap\n\tLY4Bzgf8maPslnS2c92TIDcqaCssjohL65pCMQW0=","Message-ID":"<6605f432-f3a8-490e-8312-7c0322d79c96@ideasonboard.com>","Date":"Fri, 19 Jun 2026 10:38:25 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>\n\t<YFX4RY8a2gvETdM9ieqDCGQUBVlSZj4-bmDX04nX1ogkVIX26aPV4KnYqXwy6tpb1EbIJ0FR-Au4Io52TE_HVA==@protonmail.internalid>\n\t<20260616-ipu3-libipa-rework-v1-9-d4448b54f1d8@ideasonboard.com>\n\t<f41d2e21-47fe-4dcb-ae64-5eb49a9c5696@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally <dan.scally@ideasonboard.com>","In-Reply-To":"<f41d2e21-47fe-4dcb-ae64-5eb49a9c5696@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39193,"web_url":"https://patchwork.libcamera.org/comment/39193/","msgid":"<178187068350.1686300.14582054874887776291@ping.linuxembedded.co.uk>","date":"2026-06-19T12:04:43","subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Dan Scally (2026-06-19 10:38:25)\n> Hi Barnabas\n> \n> >> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> >> index 4bdc4b7677fe9703fb968ca91967c68742454514..0827ad207c9d89b8af4887f609fe08881612ab96 100644\n> >> --- a/src/ipa/ipu3/ipu3.cpp\n> >> +++ b/src/ipa/ipu3/ipu3.cpp\n> >> @@ -313,6 +313,7 @@ int IPAIPU3::init(const IPASettings &settings,\n> >>       context_.configuration = {};\n> >>       context_.configuration.sensor.lineDuration =\n> >>           sensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n> >> +    context_.sensorInfo = sensorInfo;\n> > \n> > There is already a `sensorInfo_` member in `IPAIPU3`. Could we replace\n> > that with this one?\n> \n> Yes I think so...in fact when it's used in ::configure() it just repeats the operations here. I'll \n> drop them from ::configure() and remove that member in the v2 of this patch\n\nCheck before dropping if they are updating based on an new sensor\nconfiguration!\n\nconfigure phase is when we find out what the user has configured the\nsensor to specifically...\n\n--\nKieran\n\n> > \n> > \n> >>\n> >>       /* Load the tuning data file. */\n> >>       File file(settings.configurationFile);\n> >>\n> >> -- \n> >> 2.43.0\n> >>\n> > \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B3F3C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Jun 2026 12:04:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D739B62899;\n\tFri, 19 Jun 2026 14:04:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55D1262899\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Jun 2026 14:04:47 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CF0916CB;\n\tFri, 19 Jun 2026 14:04:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QozRw0GD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781870651;\n\tbh=5J6hCU+Yatz1qwSHUfWRPh/3aMB/78mGNClc74IW8Ug=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=QozRw0GDAUVuqPuwqfp83tDqZlkCNlIm8vnTfILa1YdVlqv8cOBJVrvH2UIwFx8FT\n\tMarO72v/ZU+htC0DJALNvskKnr3yPPe2n2tN4cQv1duhdrUgGlQbPJCsIiTCIe3WwO\n\tx4dt9H/3tgjC7DasLmOMcvw3UUmtWMio5sF/aAUk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<6605f432-f3a8-490e-8312-7c0322d79c96@ideasonboard.com>","References":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>\n\t<YFX4RY8a2gvETdM9ieqDCGQUBVlSZj4-bmDX04nX1ogkVIX26aPV4KnYqXwy6tpb1EbIJ0FR-Au4Io52TE_HVA==@protonmail.internalid>\n\t<20260616-ipu3-libipa-rework-v1-9-d4448b54f1d8@ideasonboard.com>\n\t<f41d2e21-47fe-4dcb-ae64-5eb49a9c5696@ideasonboard.com>\n\t<6605f432-f3a8-490e-8312-7c0322d79c96@ideasonboard.com>","Subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tDan Scally <dan.scally@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 19 Jun 2026 13:04:43 +0100","Message-ID":"<178187068350.1686300.14582054874887776291@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39431,"web_url":"https://patchwork.libcamera.org/comment/39431/","msgid":"<2f41c29c-1086-4619-b9b4-fa5708f723fb@ideasonboard.com>","date":"2026-06-26T09:33:21","subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Kieran, Barnabas\n\nOn 19/06/2026 13:04, Kieran Bingham wrote:\n> Quoting Dan Scally (2026-06-19 10:38:25)\n>> Hi Barnabas\n>>\n>>>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>>>> index 4bdc4b7677fe9703fb968ca91967c68742454514..0827ad207c9d89b8af4887f609fe08881612ab96 100644\n>>>> --- a/src/ipa/ipu3/ipu3.cpp\n>>>> +++ b/src/ipa/ipu3/ipu3.cpp\n>>>> @@ -313,6 +313,7 @@ int IPAIPU3::init(const IPASettings &settings,\n>>>>        context_.configuration = {};\n>>>>        context_.configuration.sensor.lineDuration =\n>>>>            sensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n>>>> +    context_.sensorInfo = sensorInfo;\n>>>\n>>> There is already a `sensorInfo_` member in `IPAIPU3`. Could we replace\n>>> that with this one?\n>>\n>> Yes I think so...in fact when it's used in ::configure() it just repeats the operations here. I'll\n>> drop them from ::configure() and remove that member in the v2 of this patch\n> \n> Check before dropping if they are updating based on an new sensor\n> configuration!\n> \n> configure phase is when we find out what the user has configured the\n> sensor to specifically...\n\nKieran is right; the sensorInfo_ member of the class is checked for the applied format size, whereas \nlibcamera::ipa::LscAlgorithm::init() function wants to know the active array size. However, we can \njust update the sensorInfo in context at configure time, and that should be fine.\n> \n> --\n> Kieran\n> \n>>>\n>>>\n>>>>\n>>>>        /* Load the tuning data file. */\n>>>>        File file(settings.configurationFile);\n>>>>\n>>>> -- \n>>>> 2.43.0\n>>>>\n>>>\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECA8FBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 09:33:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2266D658E0;\n\tFri, 26 Jun 2026 11:33:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9D87658D9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 11:33:24 +0200 (CEST)","from [192.168.0.43]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8AD7174;\n\tFri, 26 Jun 2026 11:32:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RVvED0fL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782466363;\n\tbh=2zwiSUibllVKG6oaPxqifD7tJNE+1Zm4O9wKX1g3V+c=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=RVvED0fL07aqQGnbVWZeAxrE5VlvIKmzgmUPN4oahkR/mTchSBT94HfbDR35xIUUN\n\t+HNvlqprkrQLPdisPX6Ur8utWL2VeeQjExbXu6Gyb6IdNWxfBqI5zJKLuDg2OjcmeC\n\tmr8s2K1eDLnMuxxxgeliXVa+MvTWz3wtxhmdLtck=","Message-ID":"<2f41c29c-1086-4619-b9b4-fa5708f723fb@ideasonboard.com>","Date":"Fri, 26 Jun 2026 10:33:21 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/10] ipa: ipu3: Add IPACameraSensorInfo to IPAContext","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>\n\t<YFX4RY8a2gvETdM9ieqDCGQUBVlSZj4-bmDX04nX1ogkVIX26aPV4KnYqXwy6tpb1EbIJ0FR-Au4Io52TE_HVA==@protonmail.internalid>\n\t<20260616-ipu3-libipa-rework-v1-9-d4448b54f1d8@ideasonboard.com>\n\t<f41d2e21-47fe-4dcb-ae64-5eb49a9c5696@ideasonboard.com>\n\t<6605f432-f3a8-490e-8312-7c0322d79c96@ideasonboard.com>\n\t<178187068350.1686300.14582054874887776291@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"Dan Scally <dan.scally@ideasonboard.com>","In-Reply-To":"<178187068350.1686300.14582054874887776291@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]