{"id":2690,"url":"https://patchwork.libcamera.org/api/patches/2690/?format=json","web_url":"https://patchwork.libcamera.org/patch/2690/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200120002437.6633-4-laurent.pinchart@ideasonboard.com>","date":"2020-01-20T00:24:21","name":"[libcamera-devel,03/19] libcamera: thread: Add a method to return the ID of the current thread","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"389a77180acbf0dee1684b93765eaf84abfc5d69","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2690/mbox/","series":[{"id":641,"url":"https://patchwork.libcamera.org/api/series/641/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=641","date":"2020-01-20T00:24:19","name":"Initial libcamera threading model","version":1,"mbox":"https://patchwork.libcamera.org/series/641/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2690/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2690/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C78F607A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jan 2020 01:24:43 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A854504\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jan 2020 01:24:43 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579479883;\n\tbh=U27LJqHdUKh2eK/z9aPBMZOJpM+0sfi7/dMwnBwccGg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=pPx0U0KNaDKGknCg0vGPNLpfSKhrHmF5iWqgEIrPaxYxS8Mf3lE3GGrp5lma9nPx3\n\tmh0gSz+sStoPVoiavgXp3PSSUy9ym8XlB1u+sbzY8lW5PX4nUqNlKqUICRvP3izqgg\n\t0MJwncuxoOcrsZYYIFMziVqRZyQdDtUZf38cCakk=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Jan 2020 02:24:21 +0200","Message-Id":"<20200120002437.6633-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200120002437.6633-1-laurent.pinchart@ideasonboard.com>","References":"<20200120002437.6633-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 03/19] libcamera: thread: Add a method to\n\treturn the ID of the current thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 20 Jan 2020 00:24:43 -0000"},"content":"The current thread ID is useful when logging message to debug\nconcurrency issues. Add a method to retrieve it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/include/thread.h |  2 ++\n src/libcamera/thread.cpp       | 20 ++++++++++++++++++++\n 2 files changed, 22 insertions(+)","diff":"diff --git a/src/libcamera/include/thread.h b/src/libcamera/include/thread.h\nindex 37edd4f5138b..819a9879ac56 100644\n--- a/src/libcamera/include/thread.h\n+++ b/src/libcamera/include/thread.h\n@@ -9,6 +9,7 @@\n \n #include <memory>\n #include <mutex>\n+#include <sys/types.h>\n #include <thread>\n \n #include <libcamera/signal.h>\n@@ -39,6 +40,7 @@ public:\n \tSignal<Thread *> finished;\n \n \tstatic Thread *current();\n+\tstatic pid_t currentId();\n \n \tEventDispatcher *eventDispatcher();\n \tvoid setEventDispatcher(std::unique_ptr<EventDispatcher> dispatcher);\ndiff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\nindex 18ebd16a7e2f..fe32cd677596 100644\n--- a/src/libcamera/thread.cpp\n+++ b/src/libcamera/thread.cpp\n@@ -9,6 +9,9 @@\n \n #include <atomic>\n #include <list>\n+#include <unistd.h>\n+#include <sys/syscall.h>\n+#include <sys/types.h>\n \n #include <libcamera/event_dispatcher.h>\n \n@@ -62,6 +65,7 @@ private:\n \n \tThread *thread_;\n \tbool running_;\n+\tpid_t tid_;\n \n \tMutex mutex_;\n \n@@ -108,6 +112,7 @@ ThreadData *ThreadData::current()\n \t * started, set it here.\n \t */\n \tThreadData *data = mainThread.data_;\n+\tdata->tid_ = syscall(SYS_gettid);\n \tcurrentThreadData = data;\n \treturn data;\n }\n@@ -189,6 +194,7 @@ void Thread::startThread()\n \t */\n \tthread_local ThreadCleaner cleaner(this, &Thread::finishThread);\n \n+\tdata_->tid_ = syscall(SYS_gettid);\n \tcurrentThreadData = data_;\n \n \trun();\n@@ -308,6 +314,20 @@ Thread *Thread::current()\n \treturn data->thread_;\n }\n \n+/**\n+ * \\brief Retrieve the ID of the current thread\n+ *\n+ * The thread ID corresponds to the Linux thread ID (TID) as returned by the\n+ * gettid system call.\n+ *\n+ * \\return The ID of the current thread\n+ */\n+pid_t Thread::currentId()\n+{\n+\tThreadData *data = ThreadData::current();\n+\treturn data->tid_;\n+}\n+\n /**\n  * \\brief Set the event dispatcher\n  * \\param[in] dispatcher Pointer to the event dispatcher\n","prefixes":["libcamera-devel","03/19"]}