{"id":26893,"url":"https://patchwork.libcamera.org/api/patches/26893/?format=json","web_url":"https://patchwork.libcamera.org/patch/26893/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260616-ipu3-libipa-rework-v1-2-d4448b54f1d8@ideasonboard.com>","date":"2026-06-16T06:41:36","name":"[02/10] ipu3: awb: Remove CCM settings from Awb algorithm","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"66c338e055df6dd86e80e69d389547289d8ceb17","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26893/mbox/","series":[{"id":5995,"url":"https://patchwork.libcamera.org/api/series/5995/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5995","date":"2026-06-16T06:41:34","name":"libipa: Re-work IPU3 IPA to use libipa algorithms","version":1,"mbox":"https://patchwork.libcamera.org/series/5995/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26893/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26893/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A6F6BF415\n\tfor ;\n\tTue, 16 Jun 2026 06:41:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93BAC6259D;\n\tTue, 16 Jun 2026 08:41:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BD89623F6\n\tfor ;\n\tTue, 16 Jun 2026 08:41:49 +0200 (CEST)","from [127.0.1.1]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF961166C;\n\tTue, 16 Jun 2026 08:41:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pMsQ5sV4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781592076;\n\tbh=B4LLEhhdkdJIICFVgHPDR1WTHODgJhmo34hBtf3m+z8=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=pMsQ5sV487thOvbtKtfDdfZIG+C5zD/Ybe5bwxSQPTYTGbWqQN4IIcPaUez1/Qp1j\n\tkyVfxkBk8pBc0ceQXq/fPAj0hb60NiH6qZzh62FSsl+kGkdcUnkwZnOgRakKspyuSA\n\t9JMkmR4O+hEJ9jdUUG2F+QFRD/3NNEdT85R6Y43c=","From":"Daniel Scally ","Date":"Tue, 16 Jun 2026 07:41:36 +0100","Subject":"[PATCH 02/10] ipu3: awb: Remove CCM settings from Awb algorithm","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260616-ipu3-libipa-rework-v1-2-d4448b54f1d8@ideasonboard.com>","References":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>","In-Reply-To":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1448;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=B4LLEhhdkdJIICFVgHPDR1WTHODgJhmo34hBtf3m+z8=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqMPApnC9i3J5MffrJGwY2B5hlMHtgKpwXjRiyJ\n\tf1Z/7c3PXiJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCajDwKQAKCRDISVd6bEV1\n\tMn7aD/47LR3YJ7F0VHWdTcuCaO//rIQa/3OciazzOt1qoBNuQHBIEHNqwJ8bfpI8cq3zJ+mjNhX\n\t6Qc9P6D27yH495Y/kfnxaagVbNxVv8nq39eXQWq9KGAo0rIqsWfze49PifuxJMbAEAXpvW0JFV6\n\t71pHw4NIWtNdccTY3D9YRyQ2vq0gJEz8rnpT5mbZVzP6ZIa8i7SEXHyH06zBTrW06fZhshMYzAS\n\tC9Dj3RrUdb11AO6Btnl3mJYC6pDSZ55eCuJmoHGxe+kxcWkX55iK5EwAxVwXOJUCpgPBlnWnb3X\n\tlCYDtv9p35jQxb/wnQwjG7PXg6KbqnQT2wcEkUtmzdyIJQYbO+OzcIBLORTdzjW6Cn6tUOiFM7J\n\tEteVS6eZs7aXzh6Oa/qban1+E0YhsMU9jT1Aik6fBvqovp7iuHMB4r6/djXkn1cobfYzjOHOCnt\n\tdKZsyQctqk0BsMTehRZJnYLObsWVCziKe00I1+13DTOQrPidFTO0lj+sQPJdI5DsBTFIO39DX2n\n\t9HlOaJU2fs+RL07YHr8lbJGqo70t8c4cH0zMvJ+uKVPPfhffwmnlXEXsY4+gWLICE8ordXaMdQZ\n\twOmJCywCFH1PvIaYajoZ3H4jv9VmvgAh9NYEKoU19TwKMaxtyIE6NTRvC6ZcjNf4A/xvqkPo4Tj\n\t8e+ZojPmEpAQkDQ==","X-Developer-Key":"i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3 AWB algorithm currently defines a CCM matrix that is just\na no-op. Remove the settings entirely; they need really to go in to\na dedicated CCM algorithm.\n\nSigned-off-by: Daniel Scally \n---\n src/ipa/ipu3/algorithms/awb.cpp | 10 ----------\n 1 file changed, 10 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n \t.opt_center_sqr = { 419904, 133956 },\n };\n \n-/* Default color correction matrix defined as an identity matrix */\n-static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {\n-\t8191, 0, 0, 0,\n-\t0, 8191, 0, 0,\n-\t0, 0, 8191, 0\n-};\n-\n /**\n * \\class Awb\n * \\brief A Grey world white balance correction algorithm\n@@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context,\n \n \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n \n-\t/* The CCM matrix may change when color temperature will be used */\n-\tparams->acc_param.ccm = imguCssCcmDefault;\n \n \tparams->use.acc_awb = 1;\n \tparams->use.acc_bnr = 1;\n-\tparams->use.acc_ccm = 1;\n }\n \n /* Generate an RGB vector with the average values for each zone */\n","prefixes":["02/10"]}