[{"id":39066,"web_url":"https://patchwork.libcamera.org/comment/39066/","msgid":"","date":"2026-06-15T08:16:58","subject":"Re: [PATCH 6/6] libcamera: Replace last mentions of YAML","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 11. 3:17 keltezéssel, Laurent Pinchart írta:\n> A few comments and log messages still mention YAML while they now relate\n> to code operating on ValueNode. Replace them with value node or tuning\n> data as appropriate for the context.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/libipa/lux.cpp | 2 +-\n> src/ipa/libipa/module.cpp | 10 +++++-----\n> src/ipa/libipa/module.h | 2 +-\n> src/ipa/libipa/pwl.cpp | 2 +-\n> src/ipa/rkisp1/algorithms/dpcc.cpp | 2 +-\n> src/ipa/rkisp1/algorithms/lsc.cpp | 6 +++---\n> src/libcamera/geometry.cpp | 2 +-\n> src/libcamera/matrix.cpp | 2 +-\n> src/libcamera/vector.cpp | 2 +-\n> 9 files changed, 15 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/ipa/libipa/lux.cpp b/src/ipa/libipa/lux.cpp\n> index 46cc63a115b5..12ba073a1165 100644\n> --- a/src/ipa/libipa/lux.cpp\n> +++ b/src/ipa/libipa/lux.cpp\n> @@ -80,7 +80,7 @@ Lux::Lux()\n> * \\brief Parse tuning data\n> * \\param[in] tuningData The ValueNode representing the tuning data\n> *\n> - * This function parses yaml tuning data for the common Lux module. It requires\n> + * This function parses tuning data for the common Lux module. It requires\n> * reference exposure time, analogue gain, digital gain, and lux values.\n> *\n> * \\code{.unparsed}\n> diff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp\n> index 76e10e250b73..bd415eef59e1 100644\n> --- a/src/ipa/libipa/module.cpp\n> +++ b/src/ipa/libipa/module.cpp\n> @@ -85,14 +85,14 @@ namespace ipa {\n> \n> /**\n> * \\fn Module::createAlgorithms()\n> - * \\brief Create algorithms from YAML configuration data\n> + * \\brief Create algorithms from tuning data\n> * \\param[in] context The IPA context\n> * \\param[in] algorithms Algorithms configuration data as a parsed ValueNode\n> *\n> - * This function iterates over the list of \\a algorithms parsed from the YAML\n> - * configuration file, and instantiates and initializes the corresponding\n> - * algorithms. The configuration data is expected to be correct, any error\n> - * causes the function to fail and return immediately.\n> + * This function iterates over the list of \\a algorithms parsed from the tuning\n> + * data, and instantiates and initializes the corresponding algorithms. The\n> + * configuration data is expected to be correct, any error causes the function\n> + * to fail and return immediately.\n> *\n> * Algorithms can optionally be disabled via the tuning file of the camera\n> * module as shown here, with AGC being used as an example:\n> diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h\n> index 3e2408ca30b6..5644458bdf3d 100644\n> --- a/src/ipa/libipa/module.h\n> +++ b/src/ipa/libipa/module.h\n> @@ -50,7 +50,7 @@ public:\n> \t\tfor (const auto &[i, algo] : utils::enumerate(list)) {\n> \t\t\tif (!algo.isDictionary()) {\n> \t\t\t\tLOG(IPAModuleAlgo, Error)\n> -\t\t\t\t\t<< \"Invalid YAML syntax for algorithm \" << i;\n> +\t\t\t\t\t<< \"Invalid tuning data syntax for algorithm \" << i;\n> \t\t\t\talgorithms_.clear();\n> \t\t\t\treturn -EINVAL;\n> \t\t\t}\n> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> index 9fddd5bf70e2..652569d8577a 100644\n> --- a/src/ipa/libipa/pwl.cpp\n> +++ b/src/ipa/libipa/pwl.cpp\n> @@ -429,7 +429,7 @@ std::string Pwl::toString() const\n> \n> #ifndef __DOXYGEN__\n> /*\n> - * The YAML data shall be a list of numerical values with an even number of\n> + * The value node shall be a list of numerical values with an even number of\n> * elements. They are parsed in pairs into x and y points in the piecewise\n> * linear function, and added in order. x must be monotonically increasing.\n> */\n> diff --git a/src/ipa/rkisp1/algorithms/dpcc.cpp b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> index eb8cbf2049c5..20b35d29cbcd 100644\n> --- a/src/ipa/rkisp1/algorithms/dpcc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> @@ -74,7 +74,7 @@ int DefectPixelClusterCorrection::init([[maybe_unused]] IPAContext &context,\n> \t\tconst ValueNode &set = setsObject[i];\n> \t\tuint16_t value;\n> \n> -\t\t/* Enable set if described in YAML tuning file. */\n> +\t\t/* Enable set if described in tuning data. */\n> \t\tconfig_.set_use |= 1 << i;\n> \n> \t\t/* PG Method */\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index a7e3ef8b2eb9..faf88effde01 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -61,9 +61,9 @@ namespace ipa::rkisp1::algorithms {\n> * Due to the optical characteristics of the lens, the light intensity received\n> * by the sensor is not uniform.\n> *\n> - * The Lens Shading Correction algorithm applies multipliers to all pixels\n> - * to compensate for the lens shading effect. The coefficients are\n> - * specified in a downscaled table in the YAML tuning file.\n> + * The Lens Shading Correction algorithm applies multipliers to all pixels to\n> + * compensate for the lens shading effect. The coefficients are specified in a\n> + * downscaled table in the tuning data.\n> */\n> \n> LOG_DEFINE_CATEGORY(RkISP1Lsc)\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index 010c1d8c35d9..11e57a84d785 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -928,7 +928,7 @@ std::ostream &operator<<(std::ostream &out, const Rectangle &r)\n> \n> #ifndef __DOXYGEN__\n> /*\n> - * The YAML data shall be a list of two numerical values containing the x and y\n> + * The value node shall be a list of two numerical values containing the x and y\n> * coordinates, in that order.\n> */\n> template<>\n> diff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\n> index e4fb8d35314d..0950408bb838 100644\n> --- a/src/libcamera/matrix.cpp\n> +++ b/src/libcamera/matrix.cpp\n> @@ -310,7 +310,7 @@ template bool matrixInvert(Span data, Span dataOut\n> \t\t\t\t Span swapBuffer);\n> \n> /*\n> - * The YAML data shall be a list of numerical values. Its size shall be equal\n> + * The value node shall be a list of numerical values. Its size shall be equal\n> * to the product of the number of rows and columns of the matrix (Rows x\n> * Cols). The values shall be stored in row-major order.\n> */\n> diff --git a/src/libcamera/vector.cpp b/src/libcamera/vector.cpp\n> index d850a581e32b..47b3d1af36d9 100644\n> --- a/src/libcamera/vector.cpp\n> +++ b/src/libcamera/vector.cpp\n> @@ -358,7 +358,7 @@ bool vectorValidateValueNode(const ValueNode &obj, unsigned int size)\n> \n> \tif (obj.size() != size) {\n> \t\tLOG(Vector, Error)\n> -\t\t\t<< \"Wrong number of values in YAML vector: expected \"\n> +\t\t\t<< \"Wrong number of values in vector: expected \"\n> \t\t\t<< size << \", got \" << obj.size();\n> \t\treturn false;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 164D3C328C\n\tfor ;\n\tMon, 15 Jun 2026 08:17:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4828623DD;\n\tMon, 15 Jun 2026 10:17:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0C7A623D6\n\tfor ;\n\tMon, 15 Jun 2026 10:16:58 +0200 (CEST)","from [192.168.33.26] (185.221.142.169.nat.pool.zt.hu\n\t[185.221.142.169])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18224C77;\n\tMon, 15 Jun 2026 10:16:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hsn35TWU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781511386;\n\tbh=GSmV9M4kL4uh+WDHtTdGuLh3+FMm3gTQCR2tki+lob8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=hsn35TWUEjQ11Kd3vNoPmJZKw5LeErKO2p/F3JdPlbzFQZDlSvcC+zgevJu2JZKzZ\n\ttDbq2qLyjNnHcipQPX9sf1AE8hOMYk2al2pQzUZdlJBpj3W88+MnzgYKea1oP2BsQY\n\tnDdph0fANG9VdtcMe//J0itUjs6hlXzhO3DTW+8I=","Message-ID":"","Date":"Mon, 15 Jun 2026 10:16:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 6/6] libcamera: Replace last mentions of YAML","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260611011722.1767689-1-laurent.pinchart@ideasonboard.com>\n\t<20260611011722.1767689-7-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260611011722.1767689-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]