{"id":26871,"url":"https://patchwork.libcamera.org/api/patches/26871/?format=json","web_url":"https://patchwork.libcamera.org/patch/26871/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260611011722.1767689-7-laurent.pinchart@ideasonboard.com>","date":"2026-06-11T01:17:22","name":"[6/6] libcamera: Replace last mentions of YAML","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fab22050cc3f7eb3c06c34f5529498d97ee1fe90","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26871/mbox/","series":[{"id":5986,"url":"https://patchwork.libcamera.org/api/series/5986/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5986","date":"2026-06-11T01:17:16","name":"libcamera: Drop legacy mentions of YAML","version":1,"mbox":"https://patchwork.libcamera.org/series/5986/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26871/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26871/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C52A3C328C\n\tfor ;\n\tThu, 11 Jun 2026 01:17:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72D8961F3D;\n\tThu, 11 Jun 2026 03:17:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5EBF61F37\n\tfor ;\n\tThu, 11 Jun 2026 03:17:31 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5918A673\n\tfor ;\n\tThu, 11 Jun 2026 03:17:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e5vbDx8y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781140622;\n\tbh=ybjxsF5CBDBnkpzyLuEHefbgksKGMwqTap4Norv5tyk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=e5vbDx8ypUvS4ozwCfyHaioO+VOKOqyJWkPJLTUvyRE/oajW4IXQCDAp5Dp0/4Qmn\n\tamCybnCdrJesGQRmE9VdOkZpWtwYx/MGOpDrzCdR2v78WYkueXwpSkcoxx+al7aQ/c\n\tG+Dr/jxLomkuRoPm92t1amefDvuSmZS4rE4GHBWE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 6/6] libcamera: Replace last mentions of YAML","Date":"Thu, 11 Jun 2026 04:17:22 +0300","Message-ID":"<20260611011722.1767689-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260611011722.1767689-1-laurent.pinchart@ideasonboard.com>","References":"<20260611011722.1767689-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A few comments and log messages still mention YAML while they now relate\nto code operating on ValueNode. Replace them with value node or tuning\ndata as appropriate for the context.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/lux.cpp | 2 +-\n src/ipa/libipa/module.cpp | 10 +++++-----\n src/ipa/libipa/module.h | 2 +-\n src/ipa/libipa/pwl.cpp | 2 +-\n src/ipa/rkisp1/algorithms/dpcc.cpp | 2 +-\n src/ipa/rkisp1/algorithms/lsc.cpp | 6 +++---\n src/libcamera/geometry.cpp | 2 +-\n src/libcamera/matrix.cpp | 2 +-\n src/libcamera/vector.cpp | 2 +-\n 9 files changed, 15 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/libipa/lux.cpp b/src/ipa/libipa/lux.cpp\nindex 46cc63a115b5..12ba073a1165 100644\n--- a/src/ipa/libipa/lux.cpp\n+++ b/src/ipa/libipa/lux.cpp\n@@ -80,7 +80,7 @@ Lux::Lux()\n * \\brief Parse tuning data\n * \\param[in] tuningData The ValueNode representing the tuning data\n *\n- * This function parses yaml tuning data for the common Lux module. It requires\n+ * This function parses tuning data for the common Lux module. It requires\n * reference exposure time, analogue gain, digital gain, and lux values.\n *\n * \\code{.unparsed}\ndiff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp\nindex 76e10e250b73..bd415eef59e1 100644\n--- a/src/ipa/libipa/module.cpp\n+++ b/src/ipa/libipa/module.cpp\n@@ -85,14 +85,14 @@ namespace ipa {\n \n /**\n * \\fn Module::createAlgorithms()\n- * \\brief Create algorithms from YAML configuration data\n+ * \\brief Create algorithms from tuning data\n * \\param[in] context The IPA context\n * \\param[in] algorithms Algorithms configuration data as a parsed ValueNode\n *\n- * This function iterates over the list of \\a algorithms parsed from the YAML\n- * configuration file, and instantiates and initializes the corresponding\n- * algorithms. The configuration data is expected to be correct, any error\n- * causes the function to fail and return immediately.\n+ * This function iterates over the list of \\a algorithms parsed from the tuning\n+ * data, and instantiates and initializes the corresponding algorithms. The\n+ * configuration data is expected to be correct, any error causes the function\n+ * to fail and return immediately.\n *\n * Algorithms can optionally be disabled via the tuning file of the camera\n * module as shown here, with AGC being used as an example:\ndiff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h\nindex 3e2408ca30b6..5644458bdf3d 100644\n--- a/src/ipa/libipa/module.h\n+++ b/src/ipa/libipa/module.h\n@@ -50,7 +50,7 @@ public:\n \t\tfor (const auto &[i, algo] : utils::enumerate(list)) {\n \t\t\tif (!algo.isDictionary()) {\n \t\t\t\tLOG(IPAModuleAlgo, Error)\n-\t\t\t\t\t<< \"Invalid YAML syntax for algorithm \" << i;\n+\t\t\t\t\t<< \"Invalid tuning data syntax for algorithm \" << i;\n \t\t\t\talgorithms_.clear();\n \t\t\t\treturn -EINVAL;\n \t\t\t}\ndiff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\nindex 9fddd5bf70e2..652569d8577a 100644\n--- a/src/ipa/libipa/pwl.cpp\n+++ b/src/ipa/libipa/pwl.cpp\n@@ -429,7 +429,7 @@ std::string Pwl::toString() const\n \n #ifndef __DOXYGEN__\n /*\n- * The YAML data shall be a list of numerical values with an even number of\n+ * The value node shall be a list of numerical values with an even number of\n * elements. They are parsed in pairs into x and y points in the piecewise\n * linear function, and added in order. x must be monotonically increasing.\n */\ndiff --git a/src/ipa/rkisp1/algorithms/dpcc.cpp b/src/ipa/rkisp1/algorithms/dpcc.cpp\nindex eb8cbf2049c5..20b35d29cbcd 100644\n--- a/src/ipa/rkisp1/algorithms/dpcc.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpcc.cpp\n@@ -74,7 +74,7 @@ int DefectPixelClusterCorrection::init([[maybe_unused]] IPAContext &context,\n \t\tconst ValueNode &set = setsObject[i];\n \t\tuint16_t value;\n \n-\t\t/* Enable set if described in YAML tuning file. */\n+\t\t/* Enable set if described in tuning data. */\n \t\tconfig_.set_use |= 1 << i;\n \n \t\t/* PG Method */\ndiff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex a7e3ef8b2eb9..faf88effde01 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -61,9 +61,9 @@ namespace ipa::rkisp1::algorithms {\n * Due to the optical characteristics of the lens, the light intensity received\n * by the sensor is not uniform.\n *\n- * The Lens Shading Correction algorithm applies multipliers to all pixels\n- * to compensate for the lens shading effect. The coefficients are\n- * specified in a downscaled table in the YAML tuning file.\n+ * The Lens Shading Correction algorithm applies multipliers to all pixels to\n+ * compensate for the lens shading effect. The coefficients are specified in a\n+ * downscaled table in the tuning data.\n */\n \n LOG_DEFINE_CATEGORY(RkISP1Lsc)\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 010c1d8c35d9..11e57a84d785 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -928,7 +928,7 @@ std::ostream &operator<<(std::ostream &out, const Rectangle &r)\n \n #ifndef __DOXYGEN__\n /*\n- * The YAML data shall be a list of two numerical values containing the x and y\n+ * The value node shall be a list of two numerical values containing the x and y\n * coordinates, in that order.\n */\n template<>\ndiff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\nindex e4fb8d35314d..0950408bb838 100644\n--- a/src/libcamera/matrix.cpp\n+++ b/src/libcamera/matrix.cpp\n@@ -310,7 +310,7 @@ template bool matrixInvert(Span data, Span dataOut\n \t\t\t\t Span swapBuffer);\n \n /*\n- * The YAML data shall be a list of numerical values. Its size shall be equal\n+ * The value node shall be a list of numerical values. Its size shall be equal\n * to the product of the number of rows and columns of the matrix (Rows x\n * Cols). The values shall be stored in row-major order.\n */\ndiff --git a/src/libcamera/vector.cpp b/src/libcamera/vector.cpp\nindex d850a581e32b..47b3d1af36d9 100644\n--- a/src/libcamera/vector.cpp\n+++ b/src/libcamera/vector.cpp\n@@ -358,7 +358,7 @@ bool vectorValidateValueNode(const ValueNode &obj, unsigned int size)\n \n \tif (obj.size() != size) {\n \t\tLOG(Vector, Error)\n-\t\t\t<< \"Wrong number of values in YAML vector: expected \"\n+\t\t\t<< \"Wrong number of values in vector: expected \"\n \t\t\t<< size << \", got \" << obj.size();\n \t\treturn false;\n \t}\n","prefixes":["6/6"]}