[{"id":39062,"web_url":"https://patchwork.libcamera.org/comment/39062/","msgid":"<6143080e-b2d2-4224-acfa-2ba64d4cf879@ideasonboard.com>","date":"2026-06-15T08:16:41","subject":"Re: [PATCH 2/6] libcamera: matrix: Rename data validation function","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 11. 3:17 keltezéssel, Laurent Pinchart írta:\n> The matrixValidateYaml() function predates the refactoring of YamlObject\n> and its rename to ValueNode. It now operates on a ValudeNode,\n> disconnected from the YAML parser. Rename it to\n> matrixValidateValueNode() accordingly.\n> \n> While at it, fold consecutive __DOXYGEN__ conditional blocks into a\n> single one.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/matrix.h | 6 ++----\n> src/libcamera/matrix.cpp | 2 +-\n> 2 files changed, 3 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\n> index 0f72263f2536..137eb65e0c52 100644\n> --- a/include/libcamera/internal/matrix.h\n> +++ b/include/libcamera/internal/matrix.h\n> @@ -188,10 +188,8 @@ constexpr Matrix operator+(const Matrix &m1, const\n> }\n> \n> #ifndef __DOXYGEN__\n> -bool matrixValidateYaml(const ValueNode &obj, unsigned int size);\n> -#endif /* __DOXYGEN__ */\n> +bool matrixValidateValueNode(const ValueNode &obj, unsigned int size);\n> \n> -#ifndef __DOXYGEN__\n> template\n> std::ostream &operator<<(std::ostream &out, const Matrix &m)\n> {\n> @@ -203,7 +201,7 @@ template\n> struct ValueNode::Accessor> {\n> \tstd::optional> get(const ValueNode &obj) const\n> \t{\n> -\t\tif (!matrixValidateYaml(obj, Rows * Cols))\n> +\t\tif (!matrixValidateValueNode(obj, Rows * Cols))\n> \t\t\treturn std::nullopt;\n> \n> \t\tMatrix matrix;\n> diff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\n> index 4fe210830421..e4fb8d35314d 100644\n> --- a/src/libcamera/matrix.cpp\n> +++ b/src/libcamera/matrix.cpp\n> @@ -314,7 +314,7 @@ template bool matrixInvert(Span data, Span dataOut\n> * to the product of the number of rows and columns of the matrix (Rows x\n> * Cols). The values shall be stored in row-major order.\n> */\n> -bool matrixValidateYaml(const ValueNode &obj, unsigned int size)\n> +bool matrixValidateValueNode(const ValueNode &obj, unsigned int size)\n> {\n> \tif (!obj.isList())\n> \t\treturn false;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EA2CC328C\n\tfor ;\n\tMon, 15 Jun 2026 08:16:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 290C7623DA;\n\tMon, 15 Jun 2026 10:16:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEB4C61F05\n\tfor ;\n\tMon, 15 Jun 2026 10:16:41 +0200 (CEST)","from [192.168.33.26] (185.221.142.169.nat.pool.zt.hu\n\t[185.221.142.169])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EBB31591;\n\tMon, 15 Jun 2026 10:16:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NMkCc1ld\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781511369;\n\tbh=cVot42yTtXbT4NviNaKRRwC5eRw4JiMWKGKU7oJRNhs=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=NMkCc1ld669CIziX/lhDMOM8UC9VNdLPCU+mYF5yz2hT8L3Rcs07uTK/kF1+4iYYX\n\tU98y39SaiMPUU2Nywhrh+DUS7/2ls2fj0lSfNU+SzBlbbVCiPyn0IfklpK/FIZHJBa\n\t3GpQ2q4tZsYHP4UvptXYetgOloIwGyI6Yh95cJ3E=","Message-ID":"<6143080e-b2d2-4224-acfa-2ba64d4cf879@ideasonboard.com>","Date":"Mon, 15 Jun 2026 10:16:41 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/6] libcamera: matrix: Rename data validation function","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260611011722.1767689-1-laurent.pinchart@ideasonboard.com>\n\t<20260611011722.1767689-3-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260611011722.1767689-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]