[{"id":39061,"web_url":"https://patchwork.libcamera.org/comment/39061/","msgid":"<1450487e-6a9b-4ce4-9e19-608af7d508e9@ideasonboard.com>","date":"2026-06-15T08:16:34","subject":"Re: [PATCH 1/6] ipa: rkisp1: ccm: Drop unused parseYaml() function\n\tdeclaration","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 11. 3:17 keltezéssel, Laurent Pinchart írta:\n> The Ccm::parseYaml() function is neither used nor implemented. Drop its\n> declaration.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n\n>   src/ipa/rkisp1/algorithms/ccm.h | 1 -\n>   1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.h b/src/ipa/rkisp1/algorithms/ccm.h\n> index 9ac537426d16..3d3a660065ff 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.h\n> +++ b/src/ipa/rkisp1/algorithms/ccm.h\n> @@ -41,7 +41,6 @@ public:\n>   \t\t     ControlList &metadata) override;\n>   \n>   private:\n> -\tvoid parseYaml(const ValueNode &tuningData);\n>   \tvoid setParameters(struct rkisp1_cif_isp_ctk_config &config,\n>   \t\t\t   const Matrix<float, 3, 3> &matrix,\n>   \t\t\t   const Matrix<int16_t, 3, 1> &offsets);","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AE4BC328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 Jun 2026 08:16:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A8BB623CF;\n\tMon, 15 Jun 2026 10:16:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17AE561F05\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Jun 2026 10:16:38 +0200 (CEST)","from [192.168.33.26] (185.221.142.169.nat.pool.zt.hu\n\t[185.221.142.169])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54B79591;\n\tMon, 15 Jun 2026 10:16:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M0eDl3Vd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781511365;\n\tbh=YBSDhxWlGgHmBLbNY/AosxafHHCA7gsPgkxsz4a9CJw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=M0eDl3VdKT3F9sL1SZPo9iGxVOjxFAjjdKSOV5w1q/gZ+q5aew2S4Uegnt0EyuQ57\n\tNOs7gOLsY7Gzl31kDYGEyCl+7tXWQJzg+cZ04eZ8oEsYwyt/aC/vx5VwpULjcSsUg3\n\tB5KxRNGyXe7HX5n9TXLNMOsH730jnC1UUlkX3vew=","Message-ID":"<1450487e-6a9b-4ce4-9e19-608af7d508e9@ideasonboard.com>","Date":"Mon, 15 Jun 2026 10:16:34 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/6] ipa: rkisp1: ccm: Drop unused parseYaml() function\n\tdeclaration","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260611011722.1767689-1-laurent.pinchart@ideasonboard.com>\n\t<20260611011722.1767689-2-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260611011722.1767689-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]