[{"id":39024,"web_url":"https://patchwork.libcamera.org/comment/39024/","msgid":"<9ce1f2b1-be34-4228-9404-e54ec0adc146@collabora.com>","date":"2026-06-10T12:08:35","subject":"Re: [PATCH v3] software_isp: debayer_egl: Request input buffer\n\talignment of 256 bytes","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Notes from the weekly call:\n\nBefore merging the patch, Hans requested that it should be tested on at \nleast one driver that actually honors the requested value\n\n * This is not the case on the devices I tested so far (qcom-camss,\n Librem5/imx7-csi, Pinephone/sun6i-csi) - it only happens\n accidentally if the driver happens to choose a matching stride at\n certain resolutions.\n * Vivid *should* support it but unfortunately can't be used with the\n simple pipeline handler / the gpu-isp atm.\n * It *might* work on the RPi 4/5. I'll try to test that - if I'm not\n able to with the hardware I have around, Milan offered to test the\n patch later this week.\n\nHow to test:\n\nJust check the logs from a command like \"cam -c some-device -s \nwidth=1920,height=1080 --capture=1\"\n\nIf the driver honors the request there shouldn't be any info logs \ncontaining \"Input buffer stride ignored by the driver.\" or \"Importing \ninput buffer with DMABuf import failed, falling back to upload\". The \nreported strides should change between before this patch and with it, \nthough, and always be a multiple of 256 - i.e. instead of e.g.\n\nINFO SoftwareIsp software_isp.cpp:293 Input 4080x3072-GRBG-10-CSI2P stride 5104\n\nthe logs should contain\n\nINFO SoftwareIsp software_isp.cpp:293 Input 4080x3072-GRBG-10-CSI2P stride 5120\n\nOtherwise, if the driver does not honor the request, at least at certain \nresolutions you should get logs like:\n\nINFO SimplePipeline simple.cpp:1568 Input buffer stride ignored by the driver. Requested 5120, got 5104\n...\nINFO SoftwareIsp software_isp.cpp:293 Input 4080x3072-GRBG-10-CSI2P stride 5104\n...\nINFO Debayer debayer_egl.cpp:523 Importing input buffer with DMABuf import failed, falling back to upload\n\nNote that the last log will not always appear, it just becomes more likely.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 020A4C324C\n\tfor ;\n\tWed, 10 Jun 2026 12:08:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3432F61F09;\n\tWed, 10 Jun 2026 14:08:47 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DFF461754\n\tfor ;\n\tWed, 10 Jun 2026 14:08:45 +0200 (CEST)","by mx.zohomail.com with SMTPS id 178109331875583.81076439266394;\n\tWed, 10 Jun 2026 05:08:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"XPJNYx3u\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1781093321; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=Ldif8WUErQAmUrz4D3GcxmY8wUopJpVsaQv3y71qBPL+ipqmMcUUEoJvP9eM/MLYI3bXJUDSsHaeJRtjVQecOuPzpReYEc/4wL/QRjhnbucsHaYci4yEfLrE87wFsCYGfrSh0TOiAswTCehCtZvwfCO4v+2NSK2RNSVuPBASa9g=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1781093321;\n\th=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=DlWhvx1SfJZUJzVUz1miu6DeoHRReVzCigpTA9T9ncc=; \n\tb=Ym9eExiSHK0kdRJPTNKB6M2PUvH9pyklwGwjj0Mv7pOTpgYg6+9dUJMee7CpsyJcs558gbdksxcQixBBZvADmFzPiHoQLscWQOscalEt0oU98EqA5mBEvKVOuUy5o3FU+nYcu35poaYZTKFuF79ftl+m8c0+2Agk445XpDVGRek=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1781093321;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Message-Id:Reply-To:Cc;\n\tbh=DlWhvx1SfJZUJzVUz1miu6DeoHRReVzCigpTA9T9ncc=;\n\tb=XPJNYx3u3AqGKleg9TSP7ZTTycN2qTQ6l727DQfo7L0yrlGPqY4wJri9rKhGbDGI\n\tbfRdFOLKwO9rejKJzGsj1ypjmWpCKNC48+1gWs7Q9irjPwfoNG81qVaic/5im74eHCI\n\tUoKpbV8THdnmV924gVKgoWCeiVQNfHcgdK3e92L4=","Content-Type":"multipart/alternative;\n\tboundary=\"------------4M55d9uenl0KftcZxXNWZlLe\"","Message-ID":"<9ce1f2b1-be34-4228-9404-e54ec0adc146@collabora.com>","Date":"Wed, 10 Jun 2026 14:08:35 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3] software_isp: debayer_egl: Request input buffer\n\talignment of 256 bytes","To":"libcamera-devel@lists.libcamera.org","References":"<20260609225356.23383-1-robert.mader@collabora.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20260609225356.23383-1-robert.mader@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]