[{"id":39021,"web_url":"https://patchwork.libcamera.org/comment/39021/","msgid":"<178102484166.3406404.11197495914750205936@ping.linuxembedded.co.uk>","date":"2026-06-09T17:07:21","subject":"Re: [PATCH] libcamera: matrix: Improve comment related to C++20","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-06-09 16:50:43)\n> It was envisioned that the Matrix::data_ initializer could be dropped\n> once moving to C++20. Unfortunately older compilers don't agree. Update\n> the comment accordingly.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/matrix.h | 8 +++++---\n> 1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\n> index 0f72263f2536..4900dcc0a419 100644\n> --- a/include/libcamera/internal/matrix.h\n> +++ b/include/libcamera/internal/matrix.h\n> @@ -117,9 +117,11 @@ public:\n> \n> private:\n> /*\n> - * \\todo The initializer is only necessary for the constructor to be\n> - * constexpr in C++17. Remove the initializer as soon as we are on\n> - * C++20.\n> + * \\todo The initializer should be only necessary for the constructor to\n> + * be constexpr in C++17. However, older gcc versions (at least 9 and\n> + * 12, but apparently not 10), as well as clang versions (at least 14\n> + * and 19), throw compilation errors, even with C++20. Remove the\n> + * initializer once we can drop support of those old compiler versions.\n> */\n> std::array data_ = {};\n> };\n> \n> base-commit: 5701eb5f47cf3649e2746a2082c7bb3e0a0577e8\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5011AC328C\n\tfor ;\n\tTue, 9 Jun 2026 17:07:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B77861EF9;\n\tTue, 9 Jun 2026 19:07:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CF116139A\n\tfor ;\n\tTue, 9 Jun 2026 19:07:24 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9C4A1E7;\n\tTue, 9 Jun 2026 19:06:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BavxvWFx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781024815;\n\tbh=xMtXo4rzre0K8kqTX+ZnEGLGRNibBLXqw03JlMI+Zts=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=BavxvWFxiQ4p5NhEoadEa2SjldFZA9/E5SlIG6HxxVe+Ny8k8Y/h6HQS8zg4RP61l\n\tBrXN86WxHYcJExILLkrjWd5mtzWgbk4F1ca68bbrFy9cJ7Tb1Zxh2fpB2KB5iIMVh4\n\t3OqkKbxsrsAwDRnoVF6lJZTdNI2lG3FB7gh1MVT0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260609155043.1121340-1-laurent.pinchart@ideasonboard.com>","References":"<20260609155043.1121340-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: matrix: Improve comment related to C++20","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Jun 2026 18:07:21 +0100","Message-ID":"<178102484166.3406404.11197495914750205936@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]