{"id":26847,"url":"https://patchwork.libcamera.org/api/patches/26847/?format=json","web_url":"https://patchwork.libcamera.org/patch/26847/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260608150349.134371-3-mzamazal@redhat.com>","date":"2026-06-08T15:03:31","name":"[RFC,v4,02/17] libcamera: ipa: simple: Rename setIspParams to paramsComputed","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a577720d445080aac07171f097818267be5ac313","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26847/mbox/","series":[{"id":5982,"url":"https://patchwork.libcamera.org/api/series/5982/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5982","date":"2026-06-08T15:03:29","name":"Software ISP: Share params and stats buffers","version":4,"mbox":"https://patchwork.libcamera.org/series/5982/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26847/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26847/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A189C328C\n\tfor ;\n\tMon, 8 Jun 2026 15:04:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52EF061EFB;\n\tMon, 8 Jun 2026 17:04:13 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 726D961ED7\n\tfor ;\n\tMon, 8 Jun 2026 17:04:09 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-471-UKgfMssBNzCqW_vYcNCOMg-1;\n\tMon, 08 Jun 2026 11:04:03 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id B20E81954B2C; Mon, 8 Jun 2026 15:04:01 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.48.51])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D2E6D1800361; Mon, 8 Jun 2026 15:03:59 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"d8XSPOX3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1780931048;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=fW+na+Fqr4LPOHgft2h50ooOqd8NAiIWylxyllqdgtM=;\n\tb=d8XSPOX3a369gp5bvE9KZNnUmM0LT0Brvjgd3bFSZfN0v6HALeY279hlz4VEk1izqRhYst\n\tuaz/qg1fTsdJbgcdHI70LaqASFgcRkWCMAp0uPTWVFut44zXs2Tjs0jAv7WdWFZwhSu2Lr\n\trfJ13IDuZYWnfKbxPmJWp9mgss5w2YM=","X-MC-Unique":"UKgfMssBNzCqW_vYcNCOMg-1","X-Mimecast-MFC-AGG-ID":"UKgfMssBNzCqW_vYcNCOMg_1780931042","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, johannes.goede@oss.qualcomm.com","Subject":"[RFC PATCH v4 02/17] libcamera: ipa: simple: Rename setIspParams to\n\tparamsComputed","Date":"Mon, 8 Jun 2026 17:03:31 +0200","Message-ID":"<20260608150349.134371-3-mzamazal@redhat.com>","In-Reply-To":"<20260608150349.134371-1-mzamazal@redhat.com>","References":"<20260608150349.134371-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Haf3ULw-1rbpJ04_7dYzfVEs6FIpZrRKHVQgUPVDSvc_1780931042","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For better consistency with other pipelines.\n\nReviewed-by: Kieran Bingham \nSigned-off-by: Milan Zamazal \n---\n include/libcamera/ipa/soft.mojom | 2 +-\n src/ipa/simple/soft_simple.cpp | 2 +-\n src/libcamera/software_isp/software_isp.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..e75b03a3d 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -33,6 +33,6 @@ interface IPASoftInterface {\n \n interface IPASoftEventInterface {\n \tsetSensorControls(libcamera.ControlList sensorControls);\n-\tsetIspParams();\n+\tparamsComputed();\n \tmetadataReady(uint32 frame, libcamera.ControlList metadata);\n };\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 629e1a32d..cfc1389e4 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -292,7 +292,7 @@ void IPASoftSimple::computeParams(const uint32_t frame)\n \t\talgo->prepare(context_, frame, frameContext, params_);\n \tparams_->combinedMatrix = context_.activeState.combinedMatrix;\n \n-\tsetIspParams.emit();\n+\tparamsComputed.emit();\n }\n \n void IPASoftSimple::processStats(const uint32_t frame,\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 224a2fa7c..f5b44f4e5 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -164,7 +164,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\treturn;\n \t}\n \n-\tipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams);\n+\tipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams);\n \tipa_->metadataReady.connect(this,\n \t\t\t\t [this](uint32_t frame, const ControlList &metadata) {\n \t\t\t\t\t metadataReady.emit(frame, metadata);\n","prefixes":["RFC","v4","02/17"]}