[{"id":38997,"web_url":"https://patchwork.libcamera.org/comment/38997/","msgid":"<665fc411-fb6c-4b5c-9899-893ce603bb8a@collabora.com>","date":"2026-06-04T10:42:30","subject":"Re: [PATCH v2] software_isp: debayer_egl: Request input buffer\n\talignment of 256 bytes","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 04.06.26 12:14, Robert Mader wrote:\n> ...\n> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n> index 86cb8f8de..7440937c2 100644\n> --- a/include/libcamera/internal/software_isp/software_isp.h\n> +++ b/include/libcamera/internal/software_isp/software_isp.h\n> @@ -61,6 +61,7 @@ public:\n>   \n>   \tstd::tuple<unsigned int, unsigned int>\n>   \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n> +\tuint32_t getPreferredInputStride(const PixelFormat &inputFormat, const Size &size);\n>   \n>   \tint configure(const StreamConfiguration &inputCfg,\n>   \t\t      const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\nJust figured that I should probably drop the \"get\", i.e. \n\"preferredInputStride()\" instead of \"getPreferredInputStride()\". Will do \nthat in v3 (but first wait for further feedback).","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1113C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  4 Jun 2026 10:42:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B69CE63320;\n\tThu,  4 Jun 2026 12:42:40 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00E1A6303B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  4 Jun 2026 12:42:37 +0200 (CEST)","by mx.zohomail.com with SMTPS id 178056975286866.37115252216154;\n\tThu, 4 Jun 2026 03:42:32 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"WM3lMZHd\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1780569755; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=U+MfmsWE52CprBwojAw6Jcb93Y1aLyj81MggbnK0CpM2ziN6KjUNLVI3c1MXt2eaTT1ck4qmywD1IRt/Tno1ugp3ut5yK/bXEk/lQb1PzXq64ampibAyUCyIp8rh4xJcQxfXpWlZiUy8Uvx9DOwg9FbJmL6DUlHhFut/GTQZXpY=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1780569755;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=07PaWF0qTq0weJmG5nZzF9r+xS/PnYAzW+/gybTQBqM=; \n\tb=TIg7XKLAH0pipBcezpoCfi2tjKUBkyS/31YTgEltYy/9qPDxePA+va6F1nHuoe29iuqODew4F3jriCmzKAO7DxZ3mOHKfFz0ibULkBOflg/FLdEJSBBrqfCeAbeqfkG5a+lvKQHrj+8NY7sZBrccs2hA9mhR5uVogdGbDSO09WY=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass  header.i=collabora.com;\n\tspf=pass  smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1780569755;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=07PaWF0qTq0weJmG5nZzF9r+xS/PnYAzW+/gybTQBqM=;\n\tb=WM3lMZHdqueXOcyFPSe6nAK37cZm4IzeIEuhyY7gCHF82NNxNlpsDZGmLffvnTcM\n\talcRFzB4cZAjCu978DGOHU3ynQoVZ6115jAPpupAv0bdgkjA+95l9Fku3z8q9cf4g5N\n\tkOTphPbT7DDtKBOBEM8tnWlR23WQLTHnHFNILiF4=","Message-ID":"<665fc411-fb6c-4b5c-9899-893ce603bb8a@collabora.com>","Date":"Thu, 4 Jun 2026 12:42:30 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] software_isp: debayer_egl: Request input buffer\n\talignment of 256 bytes","To":"libcamera-devel@lists.libcamera.org","References":"<20260604101448.45378-1-robert.mader@collabora.com>","Content-Language":"en-US, de-DE","From":"Robert Mader <robert.mader@collabora.com>","In-Reply-To":"<20260604101448.45378-1-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]