{"id":26841,"url":"https://patchwork.libcamera.org/api/patches/26841/?format=json","web_url":"https://patchwork.libcamera.org/patch/26841/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260604095105.68798-22-mzamazal@redhat.com>","date":"2026-06-04T09:51:03","name":"[RFC,v3,17/17] libcamera: software_isp: Remove stats-sharing TODO item","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4244efdaf88b30ad8c16adc5c31e028a5ec6fd90","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26841/mbox/","series":[{"id":5976,"url":"https://patchwork.libcamera.org/api/series/5976/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5976","date":"2026-06-04T09:50:42","name":"Software ISP: Share params and stats buffers","version":3,"mbox":"https://patchwork.libcamera.org/series/5976/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26841/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26841/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A6E2C328C\n\tfor ;\n\tThu, 4 Jun 2026 09:52:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32CC963753;\n\tThu, 4 Jun 2026 11:52:10 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0674B63748\n\tfor ;\n\tThu, 4 Jun 2026 11:52:07 +0200 (CEST)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-507-yoXpOossPjSd_HRvjn_Row-1;\n\tThu, 04 Jun 2026 05:52:03 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 7F70E1800473; Thu, 4 Jun 2026 09:52:02 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.156])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id CF04230001A1; Thu, 4 Jun 2026 09:52:00 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"d4lqvweU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1780566727;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=PUQ3rffI/BqzXYrzqqZr/7ddTTGPMDReNYc7sL2Z3O0=;\n\tb=d4lqvweUN7pmDs22Ko6Tvb+IsVLdIJeOsHuSFvF3VrEbkLHDy4l+64lG4tsW/Iy1e93hsF\n\tBxXVSGMBioywU5MRMjUvkpFtmAlFLqCBJEZh57PWVEda0sfvLUjleaFv4aPJnkOUu3/33o\n\tPrj/eJ9tfnilLjrKx6xpZbPP1/wBRT8=","X-MC-Unique":"yoXpOossPjSd_HRvjn_Row-1","X-Mimecast-MFC-AGG-ID":"yoXpOossPjSd_HRvjn_Row_1780566722","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ,\n\tjohannes.goede@oss.qualcomm.com","Subject":"[RFC PATCH v3 17/17] libcamera: software_isp: Remove stats-sharing\n\tTODO item","Date":"Thu, 4 Jun 2026 11:51:03 +0200","Message-ID":"<20260604095105.68798-22-mzamazal@redhat.com>","In-Reply-To":"<20260604095105.68798-1-mzamazal@redhat.com>","References":"<20260604095105.68798-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"e657CyJQiX53mlVZ6gZFxcNDHc24xn64rPx4sFnbN6A_1780566722","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Shared per-frame statistics buffers are implemented, we can remove\nTODO #2.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/software_isp/TODO.md | 27 ---------------------------\n 1 file changed, 27 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/TODO.md b/src/libcamera/software_isp/TODO.md\nindex f4e5190e0..dcdfd109f 100644\n--- a/src/libcamera/software_isp/TODO.md\n+++ b/src/libcamera/software_isp/TODO.md\n@@ -10,33 +10,6 @@ The TODO items in this section gather comments from patch review that were not\n deemed to require being addressed right away. The text in block quotes is\n copied directly from e-mail review.\n \n-### Reconsider stats sharing\n-\n-```\n->>> +void SwStatsCpu::finishFrame(void)\n->>> +{\n->>> +\t*sharedStats_ = stats_;\n->> \n->> Is it more efficient to copy the stats instead of operating directly on\n->> the shared memory ?\n->\n-> I inherited doing things this way from Andrey. I kept this because\n-> we don't really have any synchronization with the IPA reading this.\n->\n-> So the idea is to only touch this when the next set of statistics\n-> is ready since we don't know when the IPA is done with accessing\n-> the previous set of statistics ...\n->\n-> This is both something which seems mostly a theoretic problem,\n-> yet also definitely something which I think we need to fix.\n->\n-> Maybe use a ringbuffer of stats buffers and pass the index into\n-> the ringbuffer to the emit signal ?\n-\n-That would match how we deal with hardware ISPs, and I think that's a\n-good idea. It will help decoupling the processing side from the IPA.\n-```\n-\n ### Remove statsReady signal\n \n ```\n","prefixes":["RFC","v3","17/17"]}