[{"id":3516,"web_url":"https://patchwork.libcamera.org/comment/3516/","msgid":"<20200118231843.GB1124294@oden.dyn.berto.se>","date":"2020-01-18T23:18:43","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: thread: Add a method\n\tto return the ID of the current thread","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-01-18 23:33:47 +0200, Laurent Pinchart wrote:\n> The current thread ID is useful when logging message to debug\n> concurrency issues. Add a method to retrieve it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/thread.h | 2 ++\n> src/libcamera/thread.cpp | 20 ++++++++++++++++++++\n> 2 files changed, 22 insertions(+)\n> \n> diff --git a/src/libcamera/include/thread.h b/src/libcamera/include/thread.h\n> index 37edd4f5138b..819a9879ac56 100644\n> --- a/src/libcamera/include/thread.h\n> +++ b/src/libcamera/include/thread.h\n> @@ -9,6 +9,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> \n> #include \n> @@ -39,6 +40,7 @@ public:\n> \tSignal finished;\n> \n> \tstatic Thread *current();\n> +\tstatic pid_t currentId();\n> \n> \tEventDispatcher *eventDispatcher();\n> \tvoid setEventDispatcher(std::unique_ptr dispatcher);\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index 18ebd16a7e2f..fe32cd677596 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -9,6 +9,9 @@\n> \n> #include \n> #include \n> +#include \n> +#include \n> +#include \n> \n> #include \n> \n> @@ -62,6 +65,7 @@ private:\n> \n> \tThread *thread_;\n> \tbool running_;\n> +\tpid_t tid_;\n> \n> \tMutex mutex_;\n> \n> @@ -108,6 +112,7 @@ ThreadData *ThreadData::current()\n> \t * started, set it here.\n> \t */\n> \tThreadData *data = mainThread.data_;\n> +\tdata->tid_ = syscall(SYS_gettid);\n> \tcurrentThreadData = data;\n> \treturn data;\n> }\n> @@ -189,6 +194,7 @@ void Thread::startThread()\n> \t */\n> \tthread_local ThreadCleaner cleaner(this, &Thread::finishThread);\n> \n> +\tdata_->tid_ = syscall(SYS_gettid);\n> \tcurrentThreadData = data_;\n> \n> \trun();\n> @@ -308,6 +314,20 @@ Thread *Thread::current()\n> \treturn data->thread_;\n> }\n> \n> +/**\n> + * \\brief Retrieve the ID of the current thread\n> + *\n> + * The thread ID corresponds to the Linux thread ID (TID) as returned by the\n> + * gettid system call.\n> + *\n> + * \\return The ID of the current thread\n> + */\n> +pid_t Thread::currentId()\n> +{\n> +\tThreadData *data = ThreadData::current();\n> +\treturn data->tid_;\n> +}\n> +\n> /**\n> * \\brief Set the event dispatcher\n> * \\param[in] dispatcher Pointer to the event dispatcher\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E3006079E\n\tfor ;\n\tSun, 19 Jan 2020 00:18:45 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id 203so21110593lfa.12\n\tfor ;\n\tSat, 18 Jan 2020 15:18:45 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tv5sm14469760ljk.67.2020.01.18.15.18.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 18 Jan 2020 15:18:43 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=MmP9TFsXHLSF+oD0YH4MqFLooxKfd8S2pQLRy8Q/MlY=;\n\tb=b4DbZf+gdBxf1bYe43NkjLO6Czj8AGxEvp0+mMlhuZTEQg+Z8o6j3C4V8YbFNajCFA\n\ti+DSwv4Uos0ziFVu55gzLPPHao8EgPm2V67Sn9LTE64UsmVcoYmwuqdU2kJfAUkYkRDM\n\tYYjUxPTAOh3ZnHACq9PheaknhgKDjs9LkWRXtw2DcKSHJXh3rKRVS8Q5jHWxzMK/Xjv2\n\tVM5gaEpU3kL5h4gAsGDczJynFZ9mlg9kW3sp6aFx0Hla0qfFgrt+1SghDjIlYb8Tfrdx\n\trRXRgE9twAwd8xJqUOx9EsqSWbXwdADrmejS0itorClwRso30ujQZt3Euw5lpYmIi02Q\n\tlwQQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=MmP9TFsXHLSF+oD0YH4MqFLooxKfd8S2pQLRy8Q/MlY=;\n\tb=B2Loc6ddQ6Z7NWj+4E8ff4OaZmwyUmQcBN1GW7gT7FgV/XIr23DVDl94PTXwQ2fsk3\n\t8Sy1AT/bylzthPdDBPmMoAIHWdzj9hQ7XqAPbYJyyU+6b0MduaTqBk8KRjApbEiyiFq/\n\toV1W+AFgltox7NBNxQDV811gsvJnBxml8P+EP+QIa/+3pGSq5AuG0LdcOUU0pF1QqMP8\n\tmIDPaw27EbrXqlqJSI5qIvm2/poWXLhoQJ9ruCT5pdZXgEGXDHrsjrwxeuwBYNaYDIib\n\tp07fjZppc+uIKE82IBDbSaSayGFehy9d4NyS1GWvoVnU7M7mxYfo1t8Wme0TLGHRU+/Y\n\t+bZA==","X-Gm-Message-State":"APjAAAUZGcAJWBXB9Vjg6SeIopiFmn7tjBZnxBjpPgrTVc/RmFaVVKxk\n\tUPkpUgp0vQ+FbFgejzKJkEI5dQ==","X-Google-Smtp-Source":"APXvYqztCYRGDCrvHAo5dtBp2JnTPuKDAy2acyFctqtqmeUUnUFqb2qgHHNFulsJXt8EfT2Pw/yZCg==","X-Received":"by 2002:ac2:5195:: with SMTP id\n\tu21mr8999472lfi.141.1579389524522; \n\tSat, 18 Jan 2020 15:18:44 -0800 (PST)","Date":"Sun, 19 Jan 2020 00:18:43 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200118231843.GB1124294@oden.dyn.berto.se>","References":"<20200118213348.16561-1-laurent.pinchart@ideasonboard.com>\n\t<20200118213348.16561-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200118213348.16561-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: thread: Add a method\n\tto return the ID of the current thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 Jan 2020 23:18:45 -0000"}},{"id":3522,"web_url":"https://patchwork.libcamera.org/comment/3522/","msgid":"<3f3fd73c-8616-4375-9107-0a1498c71d02@ideasonboard.com>","date":"2020-01-20T10:11:58","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: thread: Add a method\n\tto return the ID of the current thread","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 18/01/2020 21:33, Laurent Pinchart wrote:\n> The current thread ID is useful when logging message to debug\n> concurrency issues. Add a method to retrieve it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/include/thread.h | 2 ++\n> src/libcamera/thread.cpp | 20 ++++++++++++++++++++\n> 2 files changed, 22 insertions(+)\n> \n> diff --git a/src/libcamera/include/thread.h b/src/libcamera/include/thread.h\n> index 37edd4f5138b..819a9879ac56 100644\n> --- a/src/libcamera/include/thread.h\n> +++ b/src/libcamera/include/thread.h\n> @@ -9,6 +9,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> \n> #include \n> @@ -39,6 +40,7 @@ public:\n> \tSignal finished;\n> \n> \tstatic Thread *current();\n> +\tstatic pid_t currentId();\n> \n> \tEventDispatcher *eventDispatcher();\n> \tvoid setEventDispatcher(std::unique_ptr dispatcher);\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index 18ebd16a7e2f..fe32cd677596 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -9,6 +9,9 @@\n> \n> #include \n> #include \n> +#include \n> +#include \n> +#include \n> \n> #include \n> \n> @@ -62,6 +65,7 @@ private:\n> \n> \tThread *thread_;\n> \tbool running_;\n> +\tpid_t tid_;\n> \n> \tMutex mutex_;\n> \n> @@ -108,6 +112,7 @@ ThreadData *ThreadData::current()\n> \t * started, set it here.\n> \t */\n> \tThreadData *data = mainThread.data_;\n> +\tdata->tid_ = syscall(SYS_gettid);\n> \tcurrentThreadData = data;\n> \treturn data;\n> }\n> @@ -189,6 +194,7 @@ void Thread::startThread()\n> \t */\n> \tthread_local ThreadCleaner cleaner(this, &Thread::finishThread);\n> \n> +\tdata_->tid_ = syscall(SYS_gettid);\n\nWe will now have direct syscalls from V4L2Device, V4L2VideoDevice, and\nThread.\n\nNot that we particularly want another-adaptation-layer, but should these\nbe moved to a single layer (or even just utils::?), as effectively they\nare c-library emulations?\n\nAnyway, if we chose to do so, that can be a standalone patch on top.\n\nThis is certainly a good idea to help threaded debug.\n\nReviewed-by: Kieran Bingham \n\n\n> \tcurrentThreadData = data_;\n> \n> \trun();\n> @@ -308,6 +314,20 @@ Thread *Thread::current()\n> \treturn data->thread_;\n> }\n> \n> +/**\n> + * \\brief Retrieve the ID of the current thread\n> + *\n> + * The thread ID corresponds to the Linux thread ID (TID) as returned by the\n> + * gettid system call.\n> + *\n> + * \\return The ID of the current thread\n> + */\n> +pid_t Thread::currentId()\n> +{\n> +\tThreadData *data = ThreadData::current();\n> +\treturn data->tid_;\n> +}\n> +\n> /**\n> * \\brief Set the event dispatcher\n> * \\param[in] dispatcher Pointer to the event dispatcher\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E43660454\n\tfor ;\n\tMon, 20 Jan 2020 11:12:01 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BADE2F9;\n\tMon, 20 Jan 2020 11:12:00 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579515121;\n\tbh=RR9r7R7Ap4cJpTq2e0K2fyOflnHhvuB9F8G+bJasCE0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=tZn8jOKDUxLCUGsJarBM67AaJojBCVtKP0R1KA09+6w/h96a57k5GdcZaQO0KcBf6\n\tIYhlNQHN40Zet8qCyIREhm3aihGXa/GLdsxgjYwjEBK6JwTlG7Ao1Ru78PyIWtLtpR\n\toybcH28D/ea+FqwFzoxgwV+FKpqKpuXFr5X9Qlgk=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200118213348.16561-1-laurent.pinchart@ideasonboard.com>\n\t<20200118213348.16561-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3f3fd73c-8616-4375-9107-0a1498c71d02@ideasonboard.com>","Date":"Mon, 20 Jan 2020 10:11:58 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200118213348.16561-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: thread: Add a method\n\tto return the ID of the current thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 20 Jan 2020 10:12:01 -0000"}},{"id":3525,"web_url":"https://patchwork.libcamera.org/comment/3525/","msgid":"<20200120111132.GA20122@pendragon.ideasonboard.com>","date":"2020-01-20T11:11:32","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: thread: Add a method\n\tto return the ID of the current thread","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Jan 20, 2020 at 10:11:58AM +0000, Kieran Bingham wrote:\n> On 18/01/2020 21:33, Laurent Pinchart wrote:\n> > The current thread ID is useful when logging message to debug\n> > concurrency issues. Add a method to retrieve it.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/include/thread.h | 2 ++\n> > src/libcamera/thread.cpp | 20 ++++++++++++++++++++\n> > 2 files changed, 22 insertions(+)\n> > \n> > diff --git a/src/libcamera/include/thread.h b/src/libcamera/include/thread.h\n> > index 37edd4f5138b..819a9879ac56 100644\n> > --- a/src/libcamera/include/thread.h\n> > +++ b/src/libcamera/include/thread.h\n> > @@ -9,6 +9,7 @@\n> > \n> > #include \n> > #include \n> > +#include \n> > #include \n> > \n> > #include \n> > @@ -39,6 +40,7 @@ public:\n> > \tSignal finished;\n> > \n> > \tstatic Thread *current();\n> > +\tstatic pid_t currentId();\n> > \n> > \tEventDispatcher *eventDispatcher();\n> > \tvoid setEventDispatcher(std::unique_ptr dispatcher);\n> > diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> > index 18ebd16a7e2f..fe32cd677596 100644\n> > --- a/src/libcamera/thread.cpp\n> > +++ b/src/libcamera/thread.cpp\n> > @@ -9,6 +9,9 @@\n> > \n> > #include \n> > #include \n> > +#include \n> > +#include \n> > +#include \n> > \n> > #include \n> > \n> > @@ -62,6 +65,7 @@ private:\n> > \n> > \tThread *thread_;\n> > \tbool running_;\n> > +\tpid_t tid_;\n> > \n> > \tMutex mutex_;\n> > \n> > @@ -108,6 +112,7 @@ ThreadData *ThreadData::current()\n> > \t * started, set it here.\n> > \t */\n> > \tThreadData *data = mainThread.data_;\n> > +\tdata->tid_ = syscall(SYS_gettid);\n> > \tcurrentThreadData = data;\n> > \treturn data;\n> > }\n> > @@ -189,6 +194,7 @@ void Thread::startThread()\n> > \t */\n> > \tthread_local ThreadCleaner cleaner(this, &Thread::finishThread);\n> > \n> > +\tdata_->tid_ = syscall(SYS_gettid);\n> \n> We will now have direct syscalls from V4L2Device, V4L2VideoDevice, and\n> Thread.\n> \n> Not that we particularly want another-adaptation-layer, but should these\n> be moved to a single layer (or even just utils::?), as effectively they\n> are c-library emulations?\n\nFor the openat() syscall, we may want to do so, as it may need to be\nwrapped with additional logic (for instance to handle 32/64-bit file\naccess, if needed). For gettid here, I'm not sure, as there's no\ngettid() in C libraries. And now that I've written this, I realize that\nglibc has added a gettid() wrapper in v2.30 (released on August the 1st\n2019). We could thus add a wrapper too, but more as a convenience than\nanything else, as it's just one syscall without any glue around it.\n\n> Anyway, if we chose to do so, that can be a standalone patch on top.\n> \n> This is certainly a good idea to help threaded debug.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \tcurrentThreadData = data_;\n> > \n> > \trun();\n> > @@ -308,6 +314,20 @@ Thread *Thread::current()\n> > \treturn data->thread_;\n> > }\n> > \n> > +/**\n> > + * \\brief Retrieve the ID of the current thread\n> > + *\n> > + * The thread ID corresponds to the Linux thread ID (TID) as returned by the\n> > + * gettid system call.\n> > + *\n> > + * \\return The ID of the current thread\n> > + */\n> > +pid_t Thread::currentId()\n> > +{\n> > +\tThreadData *data = ThreadData::current();\n> > +\treturn data->tid_;\n> > +}\n> > +\n> > /**\n> > * \\brief Set the event dispatcher\n> > * \\param[in] dispatcher Pointer to the event dispatcher","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86896600F5\n\tfor ;\n\tMon, 20 Jan 2020 12:11:33 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 083DEA62;\n\tMon, 20 Jan 2020 12:11:32 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579518693;\n\tbh=w+PnMm793dVhPzIcHgPCCbbkvzc7smI7Fnp5PMHvHdg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PskNq5DecTTM+5wLFlrwYnMajaswu45ocD/K8iz6PDIJZJxEx1x/DstdM32d4Tr/O\n\tevstxp/u6P2UPrtfVmVpzFw9E1tEQ0Ql1nqPM8Noafqho9CWVzltdPC5sQPcnnrYh/\n\tfKxI/i3tNHEEhDzKbzZojwrjCVLd5TX7fcAO0Fag=","Date":"Mon, 20 Jan 2020 13:11:32 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200120111132.GA20122@pendragon.ideasonboard.com>","References":"<20200118213348.16561-1-laurent.pinchart@ideasonboard.com>\n\t<20200118213348.16561-2-laurent.pinchart@ideasonboard.com>\n\t<3f3fd73c-8616-4375-9107-0a1498c71d02@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<3f3fd73c-8616-4375-9107-0a1498c71d02@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: thread: Add a method\n\tto return the ID of the current thread","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 20 Jan 2020 11:11:33 -0000"}}]