{"id":26831,"url":"https://patchwork.libcamera.org/api/patches/26831/?format=json","web_url":"https://patchwork.libcamera.org/patch/26831/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260604095105.68798-11-mzamazal@redhat.com>","date":"2026-06-04T09:50:52","name":"[RFC,v3,06/17] libcamera: software_isp: Separate allocation of the parameters buffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ab6c97849c23e04aa229f32e2ec9179875c0ffc6","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26831/mbox/","series":[{"id":5980,"url":"https://patchwork.libcamera.org/api/series/5980/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5980","date":"2026-06-04T09:50:52","name":null,"version":3,"mbox":"https://patchwork.libcamera.org/series/5980/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26831/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26831/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 532F7C328C\n\tfor ;\n\tThu, 4 Jun 2026 09:51:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1148E635AE;\n\tThu, 4 Jun 2026 11:51:44 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3CB763403\n\tfor ;\n\tThu, 4 Jun 2026 11:51:42 +0200 (CEST)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-624-05mFNIWJPNmFksdWIlAv2w-1;\n\tThu, 04 Jun 2026 05:51:39 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 99C651800581; Thu, 4 Jun 2026 09:51:37 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.156])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D30B230001A1; Thu, 4 Jun 2026 09:51:35 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"He5X/DUg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1780566701;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ouRvvoIFiiFXfXcZYXvpK6AvCC4OfXCNN2ZvV3cmX0s=;\n\tb=He5X/DUg/D3xW43UM/khUTBeXDyPaztEtxuwMAdgid3L0Rm0Mptwgq4ESxS+0DRBiy9f1P\n\tSOHEjH463SG0HJfMMZuye1LUQLJ5VfnF6tndrJJTP+NqT0lAZg1rMHQMbZpqjjWMHsdxI6\n\t2zplZHptRixkNKDiIMW+j6krOB2d064=","X-MC-Unique":"05mFNIWJPNmFksdWIlAv2w-1","X-Mimecast-MFC-AGG-ID":"05mFNIWJPNmFksdWIlAv2w_1780566697","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ,\n\tjohannes.goede@oss.qualcomm.com","Subject":"[RFC PATCH v3 06/17] libcamera: software_isp: Separate allocation of\n\tthe parameters buffer","Date":"Thu, 4 Jun 2026 11:50:52 +0200","Message-ID":"<20260604095105.68798-11-mzamazal@redhat.com>","In-Reply-To":"<20260604095105.68798-1-mzamazal@redhat.com>","References":"<20260604095105.68798-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"83drOIe3hJiqf3YdgGq8Uv7nSCypgMHxoH0dHW_piv8_1780566697","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There will be some additions to that code in followup patches and let's\nnot blow the code in SoftwareIsp constructor even more.\n\nSigned-off-by: Milan Zamazal \n---\n .../internal/software_isp/software_isp.h | 1 +\n src/libcamera/software_isp/software_isp.cpp | 17 ++++++++++++-----\n 2 files changed, 13 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 85c9059e2..f97d25f0a 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -90,6 +90,7 @@ public:\n private:\n \tvoid saveIspParams(const uint32_t paramsBufferId);\n \tvoid paramsBufferReady(const uint32_t paramsBufferId);\n+\tbool allocateParamsBuffers();\n \tvoid setSensorCtrls(const ControlList &sensorControls);\n \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n \tvoid inputReady(FrameBuffer *input);\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex a1200e924..774f2bf75 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -90,12 +90,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create DmaBufAllocator object\";\n \t\treturn;\n \t}\n-\n-\tsharedParams_ = SharedMemObject(\"softIsp_params\");\n-\tif (!sharedParams_) {\n-\t\tLOG(SoftwareIsp, Error) << \"Failed to create shared memory for parameters\";\n+\tif (!allocateParamsBuffers())\n \t\treturn;\n-\t}\n \n \tconst CameraManager &cm = *pipe->cameraManager();\n \n@@ -181,6 +177,17 @@ SoftwareIsp::~SoftwareIsp()\n \tdebayer_.reset();\n }\n \n+bool SoftwareIsp::allocateParamsBuffers()\n+{\n+\tsharedParams_ = SharedMemObject(\"softIsp_params\");\n+\tif (!sharedParams_) {\n+\t\tLOG(SoftwareIsp, Error) << \"Failed to create shared memory for parameters\";\n+\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n /**\n * \\fn int SoftwareIsp::loadConfiguration([[maybe_unused]] const std::string &filename)\n * \\brief Load a configuration from a file\n","prefixes":["RFC","v3","06/17"]}