[{"id":39001,"web_url":"https://patchwork.libcamera.org/comment/39001/","msgid":"<178059715058.1119811.10088898963597834094@ping.linuxembedded.co.uk>","date":"2026-06-04T18:19:10","subject":"Re: [RFC PATCH v3 01/17] libcamera: software_isp: Fix misplacement\n\tin SoftwareIsp docstring","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2026-06-04 10:50:43)\n> A new parameter line was inserted at a wrong position previously.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/software_isp/software_isp.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 781cf02f8..224a2fa7c 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -76,8 +76,8 @@ LOG_DEFINE_CATEGORY(SoftwareIsp)\n> * \\brief Constructs SoftwareIsp object\n> * \\param[in] pipe The pipeline handler in use\n> * \\param[in] sensor Pointer to the CameraSensor instance owned by the pipeline\n> - * \\param[out] ipaControls The IPA controls to update\n> * handler\n> + * \\param[out] ipaControls The IPA controls to update\n> */\n> SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> ControlInfoMap *ipaControls)\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D51DC324C\n\tfor ;\n\tThu, 4 Jun 2026 18:19:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D26563494;\n\tThu, 4 Jun 2026 20:19:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA19562DC4\n\tfor ;\n\tThu, 4 Jun 2026 20:19:12 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E00C013D7;\n\tThu, 4 Jun 2026 20:18:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NXPJSC2W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1780597128;\n\tbh=Xl6xVZbwyhcJ/y8qkzU6SGuk0rQBIHz7iPHYnlfCT6E=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=NXPJSC2WnJbKnvHlqG1NUdAODz23ReUUSG0e+ZCGqjvpnaw3RRvWoYHDEWR+GMj4g\n\tA/aFevQXikvhrFKM7dSATjSCnlYVLBEyazfeQhwpD27FxRnyofi5q5i/bawSExzqTa\n\tMWAGT3yYcuJ1nCzZ0KSI7/RPW2cPe6QGBzwSxOKg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260604095105.68798-2-mzamazal@redhat.com>","References":"<20260604095105.68798-1-mzamazal@redhat.com>\n\t<20260604095105.68798-2-mzamazal@redhat.com>","Subject":"Re: [RFC PATCH v3 01/17] libcamera: software_isp: Fix misplacement\n\tin SoftwareIsp docstring","From":"Kieran Bingham ","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ,\n\tjohannes.goede@oss.qualcomm.com","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Thu, 04 Jun 2026 19:19:10 +0100","Message-ID":"<178059715058.1119811.10088898963597834094@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]