{"id":26812,"url":"https://patchwork.libcamera.org/api/patches/26812/?format=json","web_url":"https://patchwork.libcamera.org/patch/26812/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260528071909.547179-1-shaunakkdatar@gmail.com>","date":"2026-05-28T07:19:09","name":"ipa: libipa: Handle missing YAML nodes in Interpolator","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"17674789da9a612555b3316cca456f9c5fe8d0a7","submitter":{"id":276,"url":"https://patchwork.libcamera.org/api/people/276/?format=json","name":"Shaunak Datar","email":"shaunakkdatar@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26812/mbox/","series":[{"id":5969,"url":"https://patchwork.libcamera.org/api/series/5969/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5969","date":"2026-05-28T07:19:09","name":"ipa: libipa: Handle missing YAML nodes in Interpolator","version":1,"mbox":"https://patchwork.libcamera.org/series/5969/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26812/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26812/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52F2EC328C\n\tfor ;\n\tThu, 28 May 2026 08:06:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5D3762FEA;\n\tThu, 28 May 2026 10:06:11 +0200 (CEST)","from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n\t[IPv6:2607:f8b0:4864:20::102e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4B1B62DC4\n\tfor ;\n\tThu, 28 May 2026 09:29:19 +0200 (CEST)","by mail-pj1-x102e.google.com with SMTP id\n\t98e67ed59e1d1-366139223e4so7674014a91.0\n\tfor ;\n\tThu, 28 May 2026 00:29:19 -0700 (PDT)","from fedora ([2405:201:2011:e829:cc4:6306:45d:33c])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c85202a337fsm14463865a12.8.2026.05.28.00.29.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 May 2026 00:29:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lXMiduNP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20251104; t=1779953358; x=1780558158;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=BI1V2YMl9Xwr7DtONU1eI+wkJsTgH4lWz+MqxH8XjP8=;\n\tb=lXMiduNPa//KLC4urzeQNWGbgKZUnzV+l7UA49aiBI2cgjCVRsKxUUTfZYVym72jDd\n\tuHItQ7PueLZizQunq1g/MJMqJK2J0waz5vjrw+6G4TK+jxNBtZTo6DrTNcBR5vVBBQLw\n\t9NhNELK3fb+AS5BT7K1MX7sJb+jkAfSj6zJano71ykCeJDCj2CUeyS63mXz+HHqFKkW4\n\t97TGkeU1c+y/VYBK4xAI8iYt0CtabipIQyVfEGLUYhDuFAjw65V3EMWkCbV3tz9aLaBv\n\txcv91z353zBSFVdlfH+4foN0wduRDqaNo4LyUWbnGaNDtpMYeeknGecaQkYgRzCo9y4M\n\tgc1g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1779953358; x=1780558158;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=BI1V2YMl9Xwr7DtONU1eI+wkJsTgH4lWz+MqxH8XjP8=;\n\tb=fFGX0GR2ItcCTttfTpBIV+X+xRFm2v4TVbVn6gmR0MvVr+uOxskJ889tiaVcAWzDqD\n\tgRgCXa+HChmVwF/qvy4KtHZ8kBVOVLshUV7Vhqv6g5WTKWc7w+UwbQri8Zg+IF4pDwZ2\n\t7EuagLBHcDz+jsIiYeOSlYen06S3H7DuLYQ73TtOUWUEzE4+2r6tbIXdMHuUa2rnMAg9\n\tpskTxDX0BQ4sKFS/XJHWbVup8mLwSxIHFXx2fPNER0n0C4B6Z273/d4zNOtXJdFtjD+V\n\tzQ4sU3C2vRFS7cksjqdNGXqIY2SGyakBvj4zyQdQYvJDQkmKDsEwIB7IC3lavzNZ3Pyw\n\trh7Q==","X-Gm-Message-State":"AOJu0YzqjsIztUijLEYRXRBbtL5THHBfCtgfPDjn+t1SiMgVCodcCOe4\n\tPpfjNIdeWL5TgzXa/0rBvPe2OSuXz+vZKPxz2YSrwlxN1uT6DgEK/Luanf26ig==","X-Gm-Gg":"Acq92OFqhAWg7jANO0l4gFPECEWLiUn6QJ+vr1ycaeVhZ0pdbkzugvpkO51AEHyw4uY\n\tFJ3QoOs11WC83+LAGCAWnV+E10w5MdH4L2CiyPuH35xUlZZlblbVX7yf/V7uNRkg3Izl5/vhQs9\n\t+ZzxKw3F+19tB20UzQL//l2rbjUezWNe4R94CL5Tql2lcvzPmytY6N9XR8w49do/ss5q6Rb9pBr\n\tkiRtK7OhVQgEiIFoyTH+cAlIfQmzpOT2EKf+0wewc6Mhm7HhxPoRpEPMj+4N2M4IBgdDsNluLeF\n\tJNkl1Blgz171UU4if5mJ7nNycGHPAg95EMp5xi2T1vTpiw6VcdvKWWMHWk6k9XlnoyTYHJcOhuC\n\tw474mI7zQ8OHsyQvjpjuqzBnt/604KxrteCvPJxacLzDJVyNMgeHcrSM/wDtbRimISOV11q44py\n\txYU6/h2nhzSC0oJxNzYeYnIqskXygGKQKTAbCSTfSUZUVJLbdwEe0LC+YNQgZvUfLJ0PIui/b0p\n\tbb84S2ZIconHw==","X-Received":"by 2002:a05:6a20:a11b:b0:398:7c6b:8615 with SMTP id\n\tadf61e73a8af0-3b328c704aemr28437561637.6.1779953357949; \n\tThu, 28 May 2026 00:29:17 -0700 (PDT)","From":"Shaunak Datar ","To":"libcamera-devel@lists.libcamera.org","Cc":"Shaunak Datar ","Subject":"[PATCH] ipa: libipa: Handle missing YAML nodes in Interpolator","Date":"Thu, 28 May 2026 12:49:09 +0530","Message-ID":"<20260528071909.547179-1-shaunakkdatar@gmail.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Thu, 28 May 2026 10:06:11 +0200","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Interpolator::readYaml() currently logs an error when passed an empty\nYAML object because it expects the node to always be a list.\n\nOptional tuning parameters such as colourGains in the AWB Grey algorithm\nmay be absent from the tuning files. rkisp1 uses tuning files without a\ncolourGains section.\n\nReturn -ENOENT for empty YAML nodes before validating the node to avoid\nERROR logs while still reporting a warning to the caller.\n\nFixes: #323\n\nSigned-off-by: Shaunak Datar \n---\n src/ipa/libipa/interpolator.h | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/ipa/libipa/interpolator.h b/src/ipa/libipa/interpolator.h\nindex cc4b27b5..01bd8140 100644\n--- a/src/ipa/libipa/interpolator.h\n+++ b/src/ipa/libipa/interpolator.h\n@@ -46,6 +46,9 @@ public:\n \t\tdata_.clear();\n \t\tlastInterpolatedKey_.reset();\n \n+\t\tif (yaml.isEmpty())\n+\t\t\treturn -ENOENT;\n+\n \t\tif (!yaml.isList()) {\n \t\t\tLOG(Interpolator, Error) << \"yaml object must be a list\";\n \t\t\treturn -EINVAL;\n","prefixes":[]}