{"id":26808,"url":"https://patchwork.libcamera.org/api/patches/26808/?format=json","web_url":"https://patchwork.libcamera.org/patch/26808/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260527081534.20245-4-robert.mader@collabora.com>","date":"2026-05-27T08:15:32","name":"[v5,3/5] egl: eGLImage: Add flag to remember dmabuf import fails","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9b524f86ada801c647c40bd40cfbe91b6059fcfb","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26808/mbox/","series":[{"id":5965,"url":"https://patchwork.libcamera.org/api/series/5965/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5965","date":"2026-05-27T08:15:29","name":"software_isp: Implement DMABuf import for input buffers","version":5,"mbox":"https://patchwork.libcamera.org/series/5965/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26808/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26808/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56556C32A9\n\tfor ;\n\tWed, 27 May 2026 08:16:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41F2563021;\n\tWed, 27 May 2026 10:16:19 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A99D363021\n\tfor ;\n\tWed, 27 May 2026 10:16:13 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1779869764635638.4647018928291;\n\tWed, 27 May 2026 01:16:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"DBKzBBdq\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1779869766; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=RQI90qS993DBzetFE8czL8VMlOTxBv+tNEy0Ptn8k09UYw+9Rsb9qBQ4V/a1wjgqu58qWI6sNdqlK/M+B2q95GITv1rszmZ+AUs3cF+hphcsY4oVJdU0D8vzKvAseRjj/Uez6NszIXlDfp+2jVaUSBnck00QbdgcYB2Nr2w0tJs=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779869766;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=XPeAw77/VqBYWO1QKVLeFzkm8QTD+ZIhsTwTCcqUn64=; \n\tb=DyVp9aIfPf9cTjLs/b9JJTpeLc4xJS0yhzv8+Gy4yFQSJs7Z6vO2igh+zPJhpzXxN0IjnqzU1yT9BHB1zhxRs5WWkO0ilWLnGkDiIDb2Jku3ZsLtUxOW5IbWb2z/wA/1LchT+mNvcPb1tR7n5EoZ8PvWcTQXeHhvTKwJ7KYZZqQ=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779869766;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=XPeAw77/VqBYWO1QKVLeFzkm8QTD+ZIhsTwTCcqUn64=;\n\tb=DBKzBBdqIYnwDGoFzHJt4J3xhtCJb+ZUWa7CJsg1y7DBClWSaSU/nD6TRp+//Guf\n\t2dsOXZbedTyF7OepMiMTyjm03vczUv9tARk0Dw3xKYf4uNL9AYNcENdVCbIdDdH/Bk1\n\tFFnKRLA2wTfu8c3+sp2IZElMRQirNbNrgyDPzzI0=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ,\n\tBryan O'Donoghue ","Subject":"[PATCH v5 3/5] egl: eGLImage: Add flag to remember dmabuf import\n\tfails","Date":"Wed, 27 May 2026 10:15:32 +0200","Message-ID":"<20260527081534.20245-4-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260527081534.20245-1-robert.mader@collabora.com>","References":"<20260527081534.20245-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation of a following commit where we will start trying dmabuf\nimport for input buffers.\nAlso turn down error log in order to avoid flodding logs going\nforward.\n\nSigned-off-by: Robert Mader \nReviewed-by: Bryan O'Donoghue \n---\n include/libcamera/internal/egl.h | 1 +\n src/libcamera/egl.cpp | 3 ++-\n 2 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex bcf09b475..57f90d93f 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -90,6 +90,7 @@ public:\n \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n \tGLuint texture_; /**< OpenGL texture object ID */\n \tGLuint fbo_; /**< OpenGL frame buffer object ID */\n+\tbool dmabuf_import_failed_ = false; /**< Previous image import failed */\n \n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage)\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 267d22c8b..c185bb7ad 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -165,7 +165,8 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n \t\t\t\t\t NULL, image_attrs);\n \n \tif (image == EGL_NO_IMAGE_KHR) {\n-\t\tLOG(eGL, Error) << \"eglCreateImageKHR fail\";\n+\t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n+\t\teglImage.dmabuf_import_failed_ = true;\n \t\treturn -ENODEV;\n \t}\n \n","prefixes":["v5","3/5"]}