[{"id":38947,"web_url":"https://patchwork.libcamera.org/comment/38947/","msgid":"<177978334540.2913565.14729487161935052694@ping.linuxembedded.co.uk>","date":"2026-05-26T08:15:45","subject":"Re: [PATCH v2 1/2] debayer_egl: Include stats computation into\n\tbenchmark","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2026-05-26 09:06:38)\n> The following commit will allow debayering on the GPU and stats\n> computation on the CPU to happen in parallel, requiring this change in\n> order to keep the benchmark meaningful.\n> \n> Do the change first in order to make before/after comparisons simpler.\n\nStefan has a plan for a new extensible 'debug metadata' type, which I\nthink we will be able to use to add more metrics like this and report\nthem on the metadata, so then we might want to measure the image\noperations and the cache operations as two separate measurements even?\n\nBut that's future ware\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Robert Mader \n> ---\n> src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index eae4c57f4..ed9a68013 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -552,14 +552,14 @@ void DebayerEGL::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n> goto error;\n> }\n> \n> - bench_.finishFrame();\n> -\n> metadata.planes()[0].bytesused = output->planes()[0].length;\n> \n> /* Calculate stats for the whole frame */\n> stats_->processFrame(frame, 0, input);\n> dmaSyncers.clear();\n> \n> + bench_.finishFrame();\n> +\n> outputBufferReady.emit(output);\n> inputBufferReady.emit(input);\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B388BC328C\n\tfor ;\n\tTue, 26 May 2026 08:15:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D89D562FD3;\n\tTue, 26 May 2026 10:15:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D27E76175A\n\tfor ;\n\tTue, 26 May 2026 10:15:47 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C99A0558;\n\tTue, 26 May 2026 10:15:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R7kFMeeo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1779783329;\n\tbh=mB2OeYFu2YnpVxTu23OybiWPWfXCmwsvMiJuFXjgJSw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=R7kFMeeo0dRQZbgnUtGyD81ELEL5edXpi3b3YHHRfru0I2kAj+wD0vsRFYNF6IKGz\n\t3e/oCx1Y+EWo1PdJ/G8qnkFn5FSpWNO4ZG1bzVq1sP83SrDP4dNMOul6y1SIUcELNr\n\td247u7w6P7AnLFtMkIsnWN7TGm72zIV8sKzDDyu8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260526080639.70173-2-robert.mader@collabora.com>","References":"<20260526080639.70173-1-robert.mader@collabora.com>\n\t<20260526080639.70173-2-robert.mader@collabora.com>","Subject":"Re: [PATCH v2 1/2] debayer_egl: Include stats computation into\n\tbenchmark","From":"Kieran Bingham ","Cc":"Robert Mader ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 26 May 2026 09:15:45 +0100","Message-ID":"<177978334540.2913565.14729487161935052694@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38950,"web_url":"https://patchwork.libcamera.org/comment/38950/","msgid":"<5f6d3b8f-35e4-4c13-a454-b5313bf4d98b@nxsw.ie>","date":"2026-05-26T17:23:39","subject":"Re: [PATCH v2 1/2] debayer_egl: Include stats computation into\n\tbenchmark","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 26/05/2026 09:06, Robert Mader wrote:\n> The following commit will allow debayering on the GPU and stats\n> computation on the CPU to happen in parallel, requiring this change in\n> order to keep the benchmark meaningful.\n> \n> Do the change first in order to make before/after comparisons simpler.\n> \n> Signed-off-by: Robert Mader \n> ---\n> src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index eae4c57f4..ed9a68013 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -552,14 +552,14 @@ void DebayerEGL::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n> \t\tgoto error;\n> \t}\n> \n> -\tbench_.finishFrame();\n> -\n> \tmetadata.planes()[0].bytesused = output->planes()[0].length;\n> \n> \t/* Calculate stats for the whole frame */\n> \tstats_->processFrame(frame, 0, input);\n> \tdmaSyncers.clear();\n> \n> +\tbench_.finishFrame();\n> +\n> \toutputBufferReady.emit(output);\n> \tinputBufferReady.emit(input);\n> \n> --\n> 2.54.0\n> \n\n\nReviewed-by: Bryan O'Donoghue \n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A86DBDCBC\n\tfor ;\n\tTue, 26 May 2026 17:23:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B2FD62FEC;\n\tTue, 26 May 2026 19:23:46 +0200 (CEST)","from mail-4320.protonmail.ch (mail-4320.protonmail.ch\n\t[185.70.43.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAAA862FB1\n\tfor ;\n\tTue, 26 May 2026 19:23:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxsw.ie header.i=@nxsw.ie header.b=\"fcvQrNM0\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxsw.ie;\n\ts=protonmail; t=1779816224; x=1780075424;\n\tbh=26nc++OuIkwtF3SaUdq+5QJUt0gAorrt/SPq/uFAnB8=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=fcvQrNM0IdsP6LpJRwbffoetbzlBmCCXVrGFKrFIAg4Y92JYDQIIESM5FgSbGAhgL\n\t9AGCrtbuhtU7lPTa6KuY8kA851ueQu5CJX6LCzPHleTWNcBu/l+Da/tsItJSbwO5nn\n\taNSOgWmpplxNedGwsZgSvytaszSO8aBIbIhHvrBTFvZnP3EIkRnYcBi9A5W7n+ObAd\n\t1QAXyg4LbEMcHfcg6dsbQTVqHfs7ydiLfWLPfjLfu4+GIdNta377gASZUjA9d8sJh4\n\tS6Q5y41z/kpmUbZsEGWbaB3lJkfBUtY3wa0uoDSx05NY7sDIDwHWhD1fyu7U6gBj7I\n\thDUhSono+C+7w==","Date":"Tue, 26 May 2026 17:23:39 +0000","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","From":"Bryan O'Donoghue ","Subject":"Re: [PATCH v2 1/2] debayer_egl: Include stats computation into\n\tbenchmark","Message-ID":"<5f6d3b8f-35e4-4c13-a454-b5313bf4d98b@nxsw.ie>","In-Reply-To":"<20260526080639.70173-2-robert.mader@collabora.com>","References":"<20260526080639.70173-1-robert.mader@collabora.com>\n\t<20260526080639.70173-2-robert.mader@collabora.com>","Feedback-ID":"136405006:user:proton","X-Pm-Message-ID":"ebba69b57bdb678af7643155e0450c3c48ac906d","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]