{"id":268,"url":"https://patchwork.libcamera.org/api/patches/268/?format=json","web_url":"https://patchwork.libcamera.org/patch/268/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190117235916.1906-3-laurent.pinchart@ideasonboard.com>","date":"2019-01-17T23:59:14","name":"[libcamera-devel,2/4] libcamera: camera_manager: Use std::unique_ptr to store event dispatcher","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1592d3b4eb88a313787a27445412e2030f45656b","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/268/mbox/","series":[{"id":90,"url":"https://patchwork.libcamera.org/api/series/90/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=90","date":"2019-01-17T23:59:12","name":"Object lifetime management","version":1,"mbox":"https://patchwork.libcamera.org/series/90/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/268/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/268/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C533860C98\n\tfor ;\n\tFri, 18 Jan 2019 00:59:20 +0100 (CET)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64211D50\n\tfor ;\n\tFri, 18 Jan 2019 00:59:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547769560;\n\tbh=Yje3AtUt21PQk4uW1VFQ9J+pN5npOrqgOgINPDRdSro=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=G2jyw+FGOZ5+hNBIdlSa97m+1Z9PVqfQ+EzjHup+w0Xt2WXI09n/3J7wGdH+z/cNd\n\t0y2Fa7UP1t9VLdLc1vk1NYBYdh7oGMLqYOiJgUpIGyTqtrvhzEqdhYzVHf9FXrQ5Vy\n\tGlWZYU32blKncBL9QzSlF+yJwSfhBp7onW9hDTgU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jan 2019 01:59:14 +0200","Message-Id":"<20190117235916.1906-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190117235916.1906-1-laurent.pinchart@ideasonboard.com>","References":"<20190117235916.1906-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/4] libcamera: camera_manager: Use\n\tstd::unique_ptr to store event dispatcher","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 23:59:20 -0000"},"content":"The CameraManager takes ownership of the dispatcher passed to the\nsetEventDispatcher() function. Enforces this by using std::unique_ptr<>.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/camera_manager.h | 4 ++--\n src/libcamera/camera_manager.cpp | 11 ++++++-----\n 2 files changed, 8 insertions(+), 7 deletions(-)","diff":"diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\nindex 6cfcba3c3933..b82a8ce95b9f 100644\n--- a/include/libcamera/camera_manager.h\n+++ b/include/libcamera/camera_manager.h\n@@ -29,7 +29,7 @@ public:\n \n \tstatic CameraManager *instance();\n \n-\tvoid setEventDispatcher(EventDispatcher *dispatcher);\n+\tvoid setEventDispatcher(std::unique_ptr dispatcher);\n \tEventDispatcher *eventDispatcher();\n \n private:\n@@ -41,7 +41,7 @@ private:\n \tstd::unique_ptr enumerator_;\n \tstd::vector pipes_;\n \n-\tEventDispatcher *dispatcher_;\n+\tstd::unique_ptr dispatcher_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 9f554be57e33..9806e399f92b 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -58,7 +58,6 @@ CameraManager::CameraManager()\n \n CameraManager::~CameraManager()\n {\n-\tdelete dispatcher_;\n }\n \n /**\n@@ -209,14 +208,14 @@ CameraManager *CameraManager::instance()\n * The CameraManager takes ownership of the event dispatcher and will delete it\n * when the application terminates.\n */\n-void CameraManager::setEventDispatcher(EventDispatcher *dispatcher)\n+void CameraManager::setEventDispatcher(std::unique_ptr dispatcher)\n {\n \tif (dispatcher_) {\n \t\tLOG(Warning) << \"Event dispatcher is already set\";\n \t\treturn;\n \t}\n \n-\tdispatcher_ = dispatcher;\n+\tdispatcher_ = std::move(dispatcher);\n }\n \n /**\n@@ -226,14 +225,16 @@ void CameraManager::setEventDispatcher(EventDispatcher *dispatcher)\n * If no dispatcher has been set, a default poll-based implementation is created\n * and returned, and no custom event dispatcher may be installed anymore.\n *\n+ * The returned event dispatcher is valid until the camera manager is destroyed.\n+ *\n * \\return Pointer to the event dispatcher\n */\n EventDispatcher *CameraManager::eventDispatcher()\n {\n \tif (!dispatcher_)\n-\t\tdispatcher_ = new EventDispatcherPoll();\n+\t\tdispatcher_.reset(new EventDispatcherPoll());\n \n-\treturn dispatcher_;\n+\treturn dispatcher_.get();\n }\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","2/4"]}