[{"id":38954,"web_url":"https://patchwork.libcamera.org/comment/38954/","msgid":"","date":"2026-05-26T17:40:56","subject":"Re: [PATCH v4 4/5] libcamera: swstats_cpu: Take MappedFrameBuffer in\n\tprocessFrame()","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 21/05/2026 16:59, Robert Mader wrote:\n> -void SwStatsCpu::processFrame(uint32_t frame, uint32_t bufferId, FrameBuffer *input)\n> +void SwStatsCpu::processFrame(uint32_t frame, uint32_t bufferId, MappedFrameBuffer *input)\n> {\n> -\tif (frame % kStatPerNumFrames) {\n> +\tif (!input || frame % kStatPerNumFrames) {\n> \t\tfinishFrame(frame, bufferId);\n> \t\treturn;\n> \t}\n\nWhy pass NULL at all ?\n\nIt just occurs to me its probably better to change the logic calling the \nfunction than make the function handle null.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 423E6C328C\n\tfor ;\n\tTue, 26 May 2026 17:41:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 946C162FD3;\n\tTue, 26 May 2026 19:41:02 +0200 (CEST)","from mail-4397.protonmail.ch (mail-4397.protonmail.ch\n\t[185.70.43.97])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1184562FB1\n\tfor ;\n\tTue, 26 May 2026 19:41:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxsw.ie header.i=@nxsw.ie header.b=\"WQi4J838\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxsw.ie;\n\ts=protonmail; t=1779817260; x=1780076460;\n\tbh=BWzyb2Ss2YuZtzuoIHsul6bmayrgF1JAH0RT53YbOkI=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=WQi4J838ohlC7ofGU9I7OgxrchwQi2lAgZfpQRVbOC3XLM7HR22LRQ+6QwJVKtNb7\n\tu8iy+o3lmiEYb4pmgJjHkvt9/WAptoOYfAjwZWRwB7YSM+CmJLGMtDcRq6jBZO0f82\n\tDR3i8I5p5kqikwDmY2vh+7mcIuQymjFKx5MOTZ0BXGwMS4azqN8afdorg6Po6rCwaa\n\ts1r4ShEyZQmdzB+RnETzBz54Cjn0mlLY1Y4SHLwXnCLbALe3rqLjVwHubHqnAjbR4X\n\tpdy75sRu6Yvl3yZhlWzB4gdZLZuMoUA0YdmaXnonBGDAVeHLgDuf5OCUhLcNSnEpwv\n\tfkVYCvPiiWLyQ==","Date":"Tue, 26 May 2026 17:40:56 +0000","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","From":"Bryan O'Donoghue ","Subject":"Re: [PATCH v4 4/5] libcamera: swstats_cpu: Take MappedFrameBuffer in\n\tprocessFrame()","Message-ID":"","In-Reply-To":"<20260521155906.120373-5-robert.mader@collabora.com>","References":"<20260521155906.120373-1-robert.mader@collabora.com>\n\t<20260521155906.120373-5-robert.mader@collabora.com>","Feedback-ID":"136405006:user:proton","X-Pm-Message-ID":"dc0fef7025bf74612cabda52a14a3402721d73d7","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38959,"web_url":"https://patchwork.libcamera.org/comment/38959/","msgid":"","date":"2026-05-27T08:21:03","subject":"Re: [PATCH v4 4/5] libcamera: swstats_cpu: Take MappedFrameBuffer in\n\tprocessFrame()","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 26.05.26 19:40, Bryan O'Donoghue wrote:\n> On 21/05/2026 16:59, Robert Mader wrote:\n>> -void SwStatsCpu::processFrame(uint32_t frame, uint32_t bufferId, FrameBuffer *input)\n>> +void SwStatsCpu::processFrame(uint32_t frame, uint32_t bufferId, MappedFrameBuffer *input)\n>> {\n>> -\tif (frame % kStatPerNumFrames) {\n>> +\tif (!input || frame % kStatPerNumFrames) {\n>> \t\tfinishFrame(frame, bufferId);\n>> \t\treturn;\n>> \t}\n> Why pass NULL at all ?\n>\n> It just occurs to me its probably better to change the logic calling the\n> function than make the function handle null.\n\nDid that in v5\n\n>\n> ---\n> bod\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 873FCBDCBC\n\tfor ;\n\tWed, 27 May 2026 08:21:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38A8E63020;\n\tWed, 27 May 2026 10:21:14 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 450C66301A\n\tfor ;\n\tWed, 27 May 2026 10:21:12 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1779870065901679.9435698474916;\n\tWed, 27 May 2026 01:21:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"fmyzGNIG\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1779870068; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=lH9Mvz92wu/jLjih1142ueR6jLK9lBd2++gw6b+z2u9lb0lm4TijG22V94RJapt1Likyziz882XASXoZJtbtq/HC7omIpKQpBrxrDDoSFGFTG/85rHMAE5sE+ctm58v9P3bNT7M9FYgYlGu3YpS05VGtCUD2PNo8EER7T5VJx/o=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779870068;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=6SZ4HAIiNPVgOCwJiHMoIoVtxdb4sDM30m5zQH4cRGg=; \n\tb=KhbmOOkMfnj8zgeFsAFFOSY5+hovG9fHK5AjNaAj8jC2+pjxL3ily6M/9zpjOk2ZwU4m1bkCwe3YwMKezpOgZc4/0U9aaGTYK1ciOkKwEPvbg2QXrMpqRIWWT2E1DyuwkB4WVh2h6UjS4Mehk04MZRhOxyKfAwAz/jebJdsE2dc=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779870068;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=6SZ4HAIiNPVgOCwJiHMoIoVtxdb4sDM30m5zQH4cRGg=;\n\tb=fmyzGNIGtUt8PEpkpM23olJA1zHY6G2xjpkKoYWTW0dBL5EtftVeCQavcXVYTuJO\n\tbkGMJIASiYbpzvdGldrV9XTMeCqPsBPPdHwZsj7FQGAR0bMOoWN0GtBdnW2CkBs+KXc\n\tJDBNTZqXaDF5xgXCsymu16VEJ1xLz0MWGWisZ2bg=","Message-ID":"","Date":"Wed, 27 May 2026 10:21:03 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 4/5] libcamera: swstats_cpu: Take MappedFrameBuffer in\n\tprocessFrame()","To":"Bryan O'Donoghue , libcamera-devel@lists.libcamera.org","References":"<20260521155906.120373-1-robert.mader@collabora.com>\n\t<20260521155906.120373-5-robert.mader@collabora.com>\n\t","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]