[{"id":38919,"web_url":"https://patchwork.libcamera.org/comment/38919/","msgid":"<20260519111121.GF16205@killaraus.ideasonboard.com>","date":"2026-05-19T11:11:21","subject":"Re: [RFC PATCH] py: Drop redundant std::move","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, May 19, 2026 at 12:54:42PM +0200, Stefan Klug wrote:\n> With gcc 14.3.0 I hit -Werror=redundant-move on that line. Drop the\n> unnecessary move.\n\nCommit 17681b75f7bad1ab80f2bd091691e1d15f7438ca disables the\nredundant-move warningfor gcc 11 and newer. Am I missing something ? Are\nyou running an old libcamera ?\n\n> Signed-off-by: Stefan Klug \n> ---\n> src/py/libcamera/py_helpers.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp\n> index b9142225c0b1..2c8e15d08c0c 100644\n> --- a/src/py/libcamera/py_helpers.cpp\n> +++ b/src/py/libcamera/py_helpers.cpp\n> @@ -25,7 +25,7 @@ static py::object valueOrTuple(const ControlValue &cv)\n> \t\tfor (size_t i = 0; i < cv.numElements(); ++i)\n> \t\t\tt[i] = v[i];\n> \n> -\t\treturn std::move(t);\n> +\t\treturn t;\n> \t}\n> \n> \treturn py::cast(cv.get());","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E53A3BDCBC\n\tfor ;\n\tTue, 19 May 2026 11:11:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2418E62FD3;\n\tTue, 19 May 2026 13:11:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CF3E62DC4\n\tfor ;\n\tTue, 19 May 2026 13:11:24 +0200 (CEST)","from killaraus.ideasonboard.com (unknown\n\t[IPv6:2a01:cb1d:8f2:800:42d6:38fa:3bdf:70df])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E4962558;\n\tTue, 19 May 2026 13:11:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GOZDeCbg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1779189071;\n\tbh=E5mwYgEqcEucophgrn3rVVC+/Fg8gwO5sXhn3INrYEk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GOZDeCbgZ7tyUQ7m17Tyg82qL9Xz44nhN2nES9PkVafdF8SkqRSf3rFsAa103gCVf\n\tNeQJWbW+Z0Rt9cQ7RHAqzDw0WkVSE5mqOzw+81exgjlSlEZMtniAk4nM1rZrJCJIBm\n\t0PX96jw75wVKfWtItpex2sg6WHp0KoT7CLeLPlkg=","Date":"Tue, 19 May 2026 13:11:21 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH] py: Drop redundant std::move","Message-ID":"<20260519111121.GF16205@killaraus.ideasonboard.com>","References":"<20260519105628.1792018-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260519105628.1792018-1-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38920,"web_url":"https://patchwork.libcamera.org/comment/38920/","msgid":"<177918931812.1809756.14099286534526059429@localhost>","date":"2026-05-19T11:15:18","subject":"Re: [RFC PATCH] py: Drop redundant std::move","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nQuoting Laurent Pinchart (2026-05-19 13:11:21)\n> On Tue, May 19, 2026 at 12:54:42PM +0200, Stefan Klug wrote:\n> > With gcc 14.3.0 I hit -Werror=redundant-move on that line. Drop the\n> > unnecessary move.\n> \n> Commit 17681b75f7bad1ab80f2bd091691e1d15f7438ca disables the\n> redundant-move warningfor gcc 11 and newer. Am I missing something ? Are\n> you running an old libcamera ?\n\nI'm running a reasonable new libcamera. Turned out to be an issue with\nmeson (the cache?). A new setup of the build directory fixed the issue.\n\nSo the patch can be ignored.\n\nRegards,\nStefan\n\n> \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/py/libcamera/py_helpers.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp\n> > index b9142225c0b1..2c8e15d08c0c 100644\n> > --- a/src/py/libcamera/py_helpers.cpp\n> > +++ b/src/py/libcamera/py_helpers.cpp\n> > @@ -25,7 +25,7 @@ static py::object valueOrTuple(const ControlValue &cv)\n> > for (size_t i = 0; i < cv.numElements(); ++i)\n> > t[i] = v[i];\n> > \n> > - return std::move(t);\n> > + return t;\n> > }\n> > \n> > return py::cast(cv.get());\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D6EEBDCBD\n\tfor ;\n\tTue, 19 May 2026 11:15:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F26CA6301A;\n\tTue, 19 May 2026 13:15:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10CFE62DC4\n\tfor ;\n\tTue, 19 May 2026 13:15:21 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a01:cb1d:8f2:800:8615:9d6a:baf:6847])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0FDBE1704; \n\tTue, 19 May 2026 13:15:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oS5QcM7C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1779189308;\n\tbh=cuGjoCDrNF1U8R2JPMhvJZNCsJ6Wp0dlSOXRjU/vmTM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oS5QcM7CQacOvAlpV/hMsPskVo3pA3RYcfqUwUuQjT+YSDIFw2fSFUltpMDz2+eMd\n\t+j/zBp8x/eqzUO3NqbeDllY7iM4O7TyoruVnuyTe1tVcPqLU7OuamfBe6+nf8eWVnN\n\to9DPYmbnImOV8Zdw9NFcfdC8EZLlnda61AbV3kn4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260519111121.GF16205@killaraus.ideasonboard.com>","References":"<20260519105628.1792018-1-stefan.klug@ideasonboard.com>\n\t<20260519111121.GF16205@killaraus.ideasonboard.com>","Subject":"Re: [RFC PATCH] py: Drop redundant std::move","From":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ","Date":"Tue, 19 May 2026 13:15:18 +0200","Message-ID":"<177918931812.1809756.14099286534526059429@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]