{"id":26779,"url":"https://patchwork.libcamera.org/api/patches/26779/?format=json","web_url":"https://patchwork.libcamera.org/patch/26779/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260519105628.1792018-1-stefan.klug@ideasonboard.com>","date":"2026-05-19T10:54:42","name":"[RFC] py: Drop redundant std::move","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"9fbb3fab9d9e26cb93cc27b571682474dc482efd","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26779/mbox/","series":[{"id":5956,"url":"https://patchwork.libcamera.org/api/series/5956/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5956","date":"2026-05-19T10:54:42","name":"[RFC] py: Drop redundant std::move","version":1,"mbox":"https://patchwork.libcamera.org/series/5956/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26779/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26779/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A8AABDCBD\n\tfor ;\n\tTue, 19 May 2026 10:56:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72F9C63024;\n\tTue, 19 May 2026 12:56:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7758D62DC4\n\tfor ;\n\tTue, 19 May 2026 12:56:33 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a01:cb1d:8f2:800:8615:9d6a:baf:6847])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1D204296;\n\tTue, 19 May 2026 12:56:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W1j2Z+Fe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1779188180;\n\tbh=xrWscAxclN/fxtCIelx/pubHcgsEzlKFUtvQgFZ2kjM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=W1j2Z+FexbKDP1N5zpE6BFzkIAjd2GcQMxmpBO4T6pir2xXfJBrefaipdcNlIO3QJ\n\tjUc9bHWE1AhOc6YO52Eb+TILotCTqok3c0OSZyd41DZ06ptrBGdRYqu4qjHVvF7rMU\n\t7jTEwarB31xxJ1EFThXs4mnq1e6n4gCQNh0ezSGA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[RFC PATCH] py: Drop redundant std::move","Date":"Tue, 19 May 2026 12:54:42 +0200","Message-ID":"<20260519105628.1792018-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"With gcc 14.3.0 I hit -Werror=redundant-move on that line. Drop the\nunnecessary move.\n\nSigned-off-by: Stefan Klug \n---\n src/py/libcamera/py_helpers.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp\nindex b9142225c0b1..2c8e15d08c0c 100644\n--- a/src/py/libcamera/py_helpers.cpp\n+++ b/src/py/libcamera/py_helpers.cpp\n@@ -25,7 +25,7 @@ static py::object valueOrTuple(const ControlValue &cv)\n \t\tfor (size_t i = 0; i < cv.numElements(); ++i)\n \t\t\tt[i] = v[i];\n \n-\t\treturn std::move(t);\n+\t\treturn t;\n \t}\n \n \treturn py::cast(cv.get());\n","prefixes":["RFC"]}