[{"id":38922,"web_url":"https://patchwork.libcamera.org/comment/38922/","msgid":"<8e1f2ded-691b-490c-b185-34b254439283@linaro.org>","date":"2026-05-19T15:56:02","subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 18/05/2026 21:15, Robert Mader wrote:\n> In order to avoid flodding logs in cases where import failure is an\n> expected result.\n> \n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> ---\n>   src/libcamera/egl.cpp | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index b8f5d9b85..df4eec757 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -152,7 +152,7 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n>   \t\t\t\t\t      NULL, image_attrs);\n> \n>   \tif (image == EGL_NO_IMAGE_KHR) {\n> -\t\tLOG(eGL, Error) << \"eglCreateImageKHR fail\";\n> +\t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n>   \t\treturn -ENODEV;\n>   \t}\n> \n> --\n> 2.54.0\n> \n\nWhy is import failure an expected result ... ?\n\n---\nbod","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED037BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 May 2026 15:56:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F48062FEC;\n\tTue, 19 May 2026 17:56:04 +0200 (CEST)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D90C962DC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 May 2026 17:56:03 +0200 (CEST)","by mail-wr1-x42d.google.com with SMTP id\n\tffacd0b85a97d-449de065cb3so3516209f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 May 2026 08:56:03 -0700 (PDT)","from [192.168.0.35] ([51.37.145.233])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-45d9adc2209sm43314696f8f.0.2026.05.19.08.56.02\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 19 May 2026 08:56:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"sqD0I+iV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1779206163; x=1779810963;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=O4oIr2Vh6feiMm7ndM3G5AhuODy53kYE8r7pm0arWP4=;\n\tb=sqD0I+iVXCFITHKnZ2H06T6KVwLC6XLt1+LK5i2w9KacsBSjKzv0iROkLDlUjcjWPh\n\tFiy+7RSNs67fQxneGxkGw8EjksuKsCxEbzA/Hte0fBWXhMYwwZZDSY2HUf7SpwsPzNUL\n\tk+Q89ZnbYRbrKKhtaxsdukl8Gvx/S7nUnkMr8roi+wgJGkqwjJcitggRNtw9Izs2Z4tA\n\tP94/OQn1oKA6I0ZvTGfgEqGmWVLN8MFu/0zsgr2TGJikM/12Q/WTuWWWIAbI+qiyJGc9\n\tPKxR3Ys2WX+lKy2WBULtU6OiVb3e1AUjgWXcqI1n30QqnbJxRU/AC6cvjpdtAwQY2P+c\n\tdfWw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1779206163; x=1779810963;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=O4oIr2Vh6feiMm7ndM3G5AhuODy53kYE8r7pm0arWP4=;\n\tb=WXFb0cpNO8e/CT8yMX67rqB0Xd/U2tXmqe5zgueBRxA8ecgholBcKz7y81a0wGWMb4\n\tnN56izpsF/nxuyHdyuXoHyGjFa9by9fJdTyvsHW1bLw2wZDwPaF+R6SRBtHyYW7cTHiv\n\tw3g2UzBAXBBk/nVEBq3jUHuFO+NzVXg0YC/pit8CxxN7z1OtqBuDvVZllYEKu2GBXlGY\n\t4E4EWSomdU7F0r+MGC5CKGV0UVy7WPcuOItdZyFh/zclxnlnWz8EX9HOOzEbzaaxZeOA\n\tw85vezEA1a6eVFBWUnRKKpXLqQBUyC2YNkn/RWx7vsvIXj83T0iQ0XgObcM2y7pQsNRD\n\tEqkQ==","X-Forwarded-Encrypted":"i=1;\n\tAFNElJ+0p0y4nvzbdsEbT//hmqIz2b4avIy9HAVaFH/bcgxJ2oEChnI2eW6OUGVn0ac5NNmE0DwaV4U8nEvjtW7FS8Q=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yx8lPPkfvTGStgnr2Tx5lbv+ze4Wu5VrHhcP3x40EZI4WztHzi2\n\tthjqscgFunEqp6hSJdGpaGh7RWPHbZMmhHn0F5UpYc6rDDlQ6hIl6vruYjoZHxKRWOU=","X-Gm-Gg":"Acq92OHjSCbyi9pJr/JDF44Md5q58qPI2JJEnhXuIDrBAYZEOnbLK+nIxLcNAz3cqig\n\tACkLOvOgyTa3sVewIA1ikdDBpImw7fLKD4AeBPzActVuK+isrQr2OR67bAqbmqHunoPLTt6AxEx\n\tr9lMB4cInMsQLAf9rid5xfzfrtRUDCxOJT2T8+necHCBZkGhrjPe+R0bnxR6NLV7RlUT6n3CN72\n\tPSa+pOD23wQ+JJIXnqimkH/niSlxD3VnbB1QNEygM/CZH/nFmAeFUdsiIUC9muYfg+XDaj78Ayo\n\tDQxpIv4A6jXJq6451aZWn1COITzBe7KCtYDrTM7/1PZMJsXAiBImkF2ojswMyaj3YcpdjCe4y/B\n\tytYDUA9LOp7BwaMYv5XsMatkV48gfeDJ4dM4IEntHe13Jiqf0ctgctRAgJGJUJ6yaLt6of3mScn\n\tB5RU4JANo38VKEMAS2NbXkxaQ3XViHvpIDHRyvKXe4v2hn","X-Received":"by 2002:a05:6000:4205:b0:43d:7dcf:ae26 with SMTP id\n\tffacd0b85a97d-45e5c5cd116mr31350104f8f.34.1779206163208; \n\tTue, 19 May 2026 08:56:03 -0700 (PDT)","Message-ID":"<8e1f2ded-691b-490c-b185-34b254439283@linaro.org>","Date":"Tue, 19 May 2026 16:56:02 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260518201508.140849-1-robert.mader@collabora.com>\n\t<Bf4PpIbYlcPDB553Av9WrSq9cGfjeFNO3wvlGMMQAtcYnbkViBrc6guiQEOIYK5EQeAJitrUoD_ZJHjOuaIq8w==@protonmail.internalid>\n\t<20260518201508.140849-3-robert.mader@collabora.com>","Content-Language":"en-US","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","In-Reply-To":"<20260518201508.140849-3-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38925,"web_url":"https://patchwork.libcamera.org/comment/38925/","msgid":"<d91f8d02b5f2005697a6efa7b1eda51e983dd768.camel@ndufresne.ca>","date":"2026-05-19T19:20:54","subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mardi 19 mai 2026 à 16:56 +0100, Bryan O'Donoghue a écrit :\n> On 18/05/2026 21:15, Robert Mader wrote:\n> > In order to avoid flodding logs in cases where import failure is an\n> > expected result.\n> > \n> > Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> > ---\n> >   src/libcamera/egl.cpp | 2 +-\n> >   1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> > index b8f5d9b85..df4eec757 100644\n> > --- a/src/libcamera/egl.cpp\n> > +++ b/src/libcamera/egl.cpp\n> > @@ -152,7 +152,7 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n> >   \t\t\t\t\t      NULL, image_attrs);\n> > \n> >   \tif (image == EGL_NO_IMAGE_KHR) {\n> > -\t\tLOG(eGL, Error) << \"eglCreateImageKHR fail\";\n> > +\t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n> >   \t\treturn -ENODEV;\n> >   \t}\n> > \n> > --\n> > 2.54.0\n> > \n> \n> Why is import failure an expected result ... ?\n\nThis is globally a fact that importing a dmabuf may fait due to constraints only\nknown by the Linux driver. For this reason we have fallback code which makes it\nwork using a slower path. If the fallback worked and you printed an error, it\nwill be confusing and spam-my.\n\nNicolas","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B7E5BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 May 2026 19:21:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B17B62FEC;\n\tTue, 19 May 2026 21:21:00 +0200 (CEST)","from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com\n\t[IPv6:2607:f8b0:4864:20::1131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 992E062FE8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 May 2026 21:20:58 +0200 (CEST)","by mail-yw1-x1131.google.com with SMTP id\n\t00721157ae682-7b6ae2ea4a1so36954467b3.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 May 2026 12:20:58 -0700 (PDT)","from ?IPv6:2606:6d00:15:e06b:3a7c:76ff:fea1:2ac0?\n\t([2606:6d00:15:e06b:3a7c:76ff:fea1:2ac0])\n\tby smtp.gmail.com with ESMTPSA id\n\t00721157ae682-7cc9d18c769sm41454027b3.47.2026.05.19.12.20.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 19 May 2026 12:20:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20251104.gappssmtp.com\n\theader.i=@ndufresne-ca.20251104.gappssmtp.com\n\theader.b=\"ZppbN6Z3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20251104.gappssmtp.com; s=20251104; t=1779218457;\n\tx=1779823257; darn=lists.libcamera.org; \n\th=mime-version:user-agent:autocrypt:references:in-reply-to:date:to\n\t:from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; \n\tbh=2I2iqhktoMuFrtMIaZB5OBTGfs3WG0FIYkHdqbp17jE=;\n\tb=ZppbN6Z3qErDx7Gm76V9jyaj33sNxqC7CY/D3m41WfLzzbRZRF+HPdn4jR6JbpYcd4\n\tPLYnSrj6J6JxDExdtPTTF/BgCR4NyGTRF+PbJ53BEB0COMsID58qbAyWxC4ABD1sKx0G\n\tLlWi5A9cGa/cM/7hePNUNvQXMEIb943RgOv0kA6nVRU4ir528LgWkSq7YCp63NYHFnDE\n\tibJ7iUmYdRCaubmCbQnCwCU9jq0iq+aq/mNHJCwMOYlkne4dxA2SaKOan124nJKJTWsJ\n\tR6otSVyWt2kPziFvoxxnX3/ScDBlXteA7CNDGGx3qtHgeYwbAmmtItIw2ds0PRUVwaX3\n\tXzLQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1779218457; x=1779823257;\n\th=mime-version:user-agent:autocrypt:references:in-reply-to:date:to\n\t:from:subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=2I2iqhktoMuFrtMIaZB5OBTGfs3WG0FIYkHdqbp17jE=;\n\tb=IG1guW8cVAjR/4k+KkFg1pGB7f3iMnngmqwsV2614w2SXwJPElUONVFPCKzgKMkRlD\n\t563JBnyVUXYLcdiOTaI97tKF18LYPpzNdrA/vceoXya4W06yauO/u413P0x849YhX2B4\n\tHbMvHOwWokEycJRZXybVl/0tidoD0yG7cx67v6cb9hKlluE1cxOtcIIYM/xKzhNgYXuU\n\t/nx09L9PINPagAbdLXHuOAyP6v0eX7M/OuIZIrOsMdYXGnPZrMS1QN/aOCIwui4MDPOM\n\tjNt+ZCnWwQmtil5MSVKtbcyRkybFPQqlCiTRNwG1n05wfVgv3TNvkkeosbUWI3j7okU8\n\tRb7g==","X-Forwarded-Encrypted":"i=1;\n\tAFNElJ8if7wqD4AjhV942cLcKjDaNyy62hAwwG/OlFcSFBWxpTsahiLsvqzMw+fnQuL9PeL2JuarhuMGDnunbd8zNAU=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YypQyqfO3y9lPQ2j3ZxvPjk8OO4+bzCXcE+dvZQyE/xep+zvuDw\n\tM79U/7MqKAJzU8J+8JnhcCy7AzEyfeG2v+HDsE+Nj+1uWDPOFUTanGCRZk8HnWCikXg=","X-Gm-Gg":"Acq92OH3FV/cFA5a/wHTrTeCkxhU881+YihzYg9MjtV9pncQgz8vU2TXdy54TEFNkXj\n\tubgNsyHwxBBkc0I1tJnf4hI4G6QidPKErQwqhxRleupJHExmRmO/2kqIsqmMCLj9NgMiMknwSq5\n\tu8J6VEPWo1GRGJpmw36rDOWWl5ygbt4GhIZO7E3Kko5b4RmXhJo3H0equJGW6Yne2WosbnHYDYT\n\tNFaa/dedJHwbkAYtf4Ow1+Fo/W9MjVSOjcNYsnfPBT2bO3x0Uyjn65dGfGz2vhiZgPyIBOhk5l0\n\tjjkVC80N+EAuxr3css9+TMJjr9x7bw0ykoX7D8nc04lfo4uxlX+eZY2xlwDXx0m0dE8IUWiZhhX\n\tqlw6I2jODLrxlbr6FLiC4VFuB6fkbKjUBq6ppjvtqwfqqKtiGEK5CZpgfetIRfSc4RXkpBbyugN\n\tDnJnmX6TaGZCAkm+gBVOonFwz4hk/si+UNKZvvmk05/8TueIy+bfDW9c87/W1P/o7tRJ6yyMc82\n\tFWSpLw=","X-Received":"by 2002:a05:690c:e1c3:20b0:7b9:39f:62c8 with SMTP id\n\t00721157ae682-7c95c200ee9mr190179727b3.27.1779218457227; \n\tTue, 19 May 2026 12:20:57 -0700 (PDT)","Message-ID":"<d91f8d02b5f2005697a6efa7b1eda51e983dd768.camel@ndufresne.ca>","Subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","From":"Nicolas Dufresne <nicolas@ndufresne.ca>","To":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>, Robert Mader\n\t<robert.mader@collabora.com>, libcamera-devel@lists.libcamera.org","Date":"Tue, 19 May 2026 15:20:54 -0400","In-Reply-To":"<8e1f2ded-691b-490c-b185-34b254439283@linaro.org>","References":"<20260518201508.140849-1-robert.mader@collabora.com>\n\t<Bf4PpIbYlcPDB553Av9WrSq9cGfjeFNO3wvlGMMQAtcYnbkViBrc6guiQEOIYK5EQeAJitrUoD_ZJHjOuaIq8w==@protonmail.internalid>\n\t<20260518201508.140849-3-robert.mader@collabora.com>\n\t<8e1f2ded-691b-490c-b185-34b254439283@linaro.org>","Autocrypt":"addr=nicolas@ndufresne.ca; prefer-encrypt=mutual;\n\tkeydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD\n\t/e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA\n\tcCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo\n\tCGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN\n\tabIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z\n\tnJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4\n\tAWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ\n\tsmBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC\n\tAAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF\n\tiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw\n\tECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8\n\tbRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-G+vXhqp/9MhxaTsvQqHN\"","User-Agent":"Evolution 3.60.1 (3.60.1-1.fc44) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38927,"web_url":"https://patchwork.libcamera.org/comment/38927/","msgid":"<b8849b10-d64f-4782-b769-a003c718810b@collabora.com>","date":"2026-05-19T19:41:43","subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 19.05.26 17:56, Bryan O'Donoghue wrote:\n>\n> Why is import failure an expected result ... ? \nTried to make that more clear in v3","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61BB4BDCBC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 May 2026 19:41:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 102A96302D;\n\tTue, 19 May 2026 21:41:51 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 054DC62FEC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 May 2026 21:41:49 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1779219705946317.0293311986255;\n\tTue, 19 May 2026 12:41:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"hL409Y+s\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1779219707; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=JdNsY6FYn+TnvOmrWPZ7aBZLM5PfU46hEcOev5sHOnpOrBWEmi1LYmyvl5REqQrxGTJ5S8Ge1ZuFmO42Rgkdsl4f/0djYmRC/5+GaWDIOPvTt7w7TbiZXbs7n8L/LpmcKP61MkJ9P8PtfdZRah7MZzJYTN1ZeHIjGXpN+to135c=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779219707;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=E9Q8pT7YrXxUudbyerIv3Tp3fyhWRnZwKXweKrj6Hx0=; \n\tb=JfFvoQZib/TypoggSVW3J0ZyukeDl8hfxO16LGFCTeOI/X8Cwu5pCVfpvRxiSFMQ+rtyDvEb7mzDesvdWe2IWWJBn+XRhNjODEkA0NXl5nF5r9AxMbDb++XPI2/J29e7RrLIQV7ysV5bFGvaMPj6An/UCnUchpx5NMJfOdiuV/A=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass  header.i=collabora.com;\n\tspf=pass  smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779219707;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=E9Q8pT7YrXxUudbyerIv3Tp3fyhWRnZwKXweKrj6Hx0=;\n\tb=hL409Y+sb9PVZPRUy7fsEZ6Vi1AC4KcvU1/Ywt8D76KavqtCUEHvUxlwBGbvbZbL\n\tCRy5dpZRlpqAcYwQttG9ds1bxQFQK+7XslTjZ9ZvQ66eE/uXgYAjtZ0OGKoJ+QRA6O/\n\tl+oKjcDKZEUS2VX6G6zBLwBxj+0Cam0jOAm8eNQQ=","Message-ID":"<b8849b10-d64f-4782-b769-a003c718810b@collabora.com>","Date":"Tue, 19 May 2026 21:41:43 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","To":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260518201508.140849-1-robert.mader@collabora.com>\n\t<Bf4PpIbYlcPDB553Av9WrSq9cGfjeFNO3wvlGMMQAtcYnbkViBrc6guiQEOIYK5EQeAJitrUoD_ZJHjOuaIq8w==@protonmail.internalid>\n\t<20260518201508.140849-3-robert.mader@collabora.com>\n\t<8e1f2ded-691b-490c-b185-34b254439283@linaro.org>","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader <robert.mader@collabora.com>","In-Reply-To":"<8e1f2ded-691b-490c-b185-34b254439283@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38934,"web_url":"https://patchwork.libcamera.org/comment/38934/","msgid":"<5ebe33ea-c77c-475f-813b-0289de113c20@linaro.org>","date":"2026-05-20T08:45:53","subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 19/05/2026 20:20, Nicolas Dufresne wrote:\n> Le mardi 19 mai 2026 à 16:56 +0100, Bryan O'Donoghue a écrit :\n>> On 18/05/2026 21:15, Robert Mader wrote:\n>>> In order to avoid flodding logs in cases where import failure is an\n>>> expected result.\n>>>\n>>> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n>>> ---\n>>>    src/libcamera/egl.cpp | 2 +-\n>>>    1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n>>> index b8f5d9b85..df4eec757 100644\n>>> --- a/src/libcamera/egl.cpp\n>>> +++ b/src/libcamera/egl.cpp\n>>> @@ -152,7 +152,7 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n>>>    \t\t\t\t\t      NULL, image_attrs);\n>>>\n>>>    \tif (image == EGL_NO_IMAGE_KHR) {\n>>> -\t\tLOG(eGL, Error) << \"eglCreateImageKHR fail\";\n>>> +\t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n>>>    \t\treturn -ENODEV;\n>>>    \t}\n>>>\n>>> --\n>>> 2.54.0\n>>>\n>>\n>> Why is import failure an expected result ... ?\n> \n> This is globally a fact that importing a dmabuf may fait due to constraints only\n> known by the Linux driver. For this reason we have fallback code which makes it\n> work using a slower path. If the fallback worked and you printed an error, it\n> will be confusing and spam-my.\n> \n> Nicolas\n\nSo long as the fallback gives a meaningful deterministic fail string \nthen, that's fine.\n\n---\nbod","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F7F4BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 May 2026 08:45:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3249A63021;\n\tWed, 20 May 2026 10:45:57 +0200 (CEST)","from mail-ed1-x531.google.com (mail-ed1-x531.google.com\n\t[IPv6:2a00:1450:4864:20::531])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72E0D6175A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 May 2026 10:45:55 +0200 (CEST)","by mail-ed1-x531.google.com with SMTP id\n\t4fb4d7f45d1cf-6804e24803bso10304852a12.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 May 2026 01:45:55 -0700 (PDT)","from [192.168.0.35] ([109.76.255.129])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-bd4f4ded942sm825545766b.36.2026.05.20.01.45.53\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 20 May 2026 01:45:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Znib/Pt3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1779266755; x=1779871555;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Z+DAmvw4cejLtOHhIXMJe/vfThiLNtqrdCjJvJdK868=;\n\tb=Znib/Pt334W7MfL/PPU1bm+yWSmvX8k8iNeGNOan+CjI7A6aujkil7Wbm6Ow/Fy24Y\n\tF2bqGW3sQrbzpJKZuBr/WjUFhs0KXnG0xbaoAVmJXCvxHPsKjvJRvSgsgXNYE0PWx7vh\n\tkks4NvnIBLTuYM/M7YAYAEW23iKjbCKwxKLbbCemRJbnNGrot1GjSxe1iyBpwgSaOoqF\n\t+9w39I1BkWQldK4iGcluxc+LtZ9Yoqmp5ny3ZPjEzhhQNHsiEFOKOVr+n+Avx6e4cEZQ\n\tAaLSHnfFhi9AWNfbJXj2+UQrrtsjtRWQL6AE0thRYyXXFJ8U7f8eP5MaqyKLUZWz4++k\n\twRSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1779266755; x=1779871555;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=Z+DAmvw4cejLtOHhIXMJe/vfThiLNtqrdCjJvJdK868=;\n\tb=Y8Fk3tztqVVcvuAb31TxGP1hn5iwVOyIhd5TNQcQkNCOHDtv5p0JVHZ0JVxL8SyzsL\n\tkGssZ7+eeZYj3D5Y61EtQheTH3zzECFuRgcHYRFKYzo0oc0hoWveSLGFnBJhvvc+h7VG\n\tjk5rtfsu7SThWiJ18AH1P194uUodew7FppyAGAsMGxrJT4KA2bU7OEeMgdrWz+AA8a7z\n\tYB8Ur54/ss7g3a7Q0dFGSqw2ASAC7ixgiEsWgXxZNx6iyNozQYl5PDNZ2jdK7iVzCJ+E\n\taCbA24ta1jMQ94bsfHE201I2K9Pbb4fUmca1E1BtlLelzQpvsGzC3UmRfhdkVCWEcWKb\n\tlWxA==","X-Forwarded-Encrypted":"i=1;\n\tAFNElJ9TXdrB7BeQxWc3OmNXTxwiyIP5zTj4OvmGl+iUr52sm8Y8brMJCOeXVSD8EMjx3pZBaG6/s6/XCNEedLnw8GM=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwqOFJ64xHnAU2CAUPuZ73RmBut9+2ZHCVaJIdEAWkpEoSASOmc\n\tqgLrkfJmYDSDm/+tD6unkijxQXsVX/EFF4QxKkH7x/vK7ABcycOzXbeHNljOPbAPE0w=","X-Gm-Gg":"Acq92OEB+/IfmGDoHGSTRSrkDRq1/8kD2ByNU/dNH8xYcRRRO7sM5eAzSxpYHpHBT4o\n\tVjAMvykJkeHy57TSZnBL2H4Z9kf1cT5Gi1OctPYQUL+cQu5bKsma5lmYQ7isFwoGlisUI4u/9QZ\n\t7hgcfTdI9uO9gVMCQTQnEVDZvISw2VGtD1xN9O7V6lxVdmc6yC6VPGJvivIL2YG3S14T34yrpw2\n\tWL8OKmdBDYhphk78GLWaKXXsHNNRclrzvt8lI53W+WKyPeQgfXc/pHrc5LlTU9/ICMomdeTjCba\n\tP+novB2Lew1jsFuqOY6DNCCry8dF++Zs3IEhTMg7mjoGAnn45okCMoHfYlVec6jI1hdcKkG+BPt\n\tmIlTxkPcVlL+f180uZ7t5EUIEpmNALzUvbwoTIhkWtiIs/q4mZkfH1xRmHWzis20v0gNoMfkNRe\n\tnPHRBq7n3k7i7sSBdwitcdoVbVH2ti2KhmFKK888XsgH2I3A==","X-Received":"by 2002:a17:907:c986:b0:bd4:4593:33b9 with SMTP id\n\ta640c23a62f3a-bd517906724mr1060687866b.29.1779266754608; \n\tWed, 20 May 2026 01:45:54 -0700 (PDT)","Message-ID":"<5ebe33ea-c77c-475f-813b-0289de113c20@linaro.org>","Date":"Wed, 20 May 2026 09:45:53 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/4] egl: Demote an error log to debug","To":"Nicolas Dufresne <nicolas@ndufresne.ca>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260518201508.140849-1-robert.mader@collabora.com>\n\t<Bf4PpIbYlcPDB553Av9WrSq9cGfjeFNO3wvlGMMQAtcYnbkViBrc6guiQEOIYK5EQeAJitrUoD_ZJHjOuaIq8w==@protonmail.internalid>\n\t<20260518201508.140849-3-robert.mader@collabora.com>\n\t<8e1f2ded-691b-490c-b185-34b254439283@linaro.org>\n\t<d91f8d02b5f2005697a6efa7b1eda51e983dd768.camel@ndufresne.ca>","Content-Language":"en-US","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","In-Reply-To":"<d91f8d02b5f2005697a6efa7b1eda51e983dd768.camel@ndufresne.ca>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]