[{"id":38889,"web_url":"https://patchwork.libcamera.org/comment/38889/","msgid":"","date":"2026-05-13T14:50:37","subject":"Re: [PATCH v5 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Hans\n\nOn Tue, May 12, 2026 at 07:53:40PM +0200, Hans de Goede wrote:\n> Explicitly specify the \"simple\" IPA name when loading the IPA so that\n> the softISP can be used with other pipeline-handlers too.\n>\n> Signed-off-by: Hans de Goede \n\nJust to complete the series' review\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/software_isp/software_isp.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 781cf02f8..4f30aa180 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -129,7 +129,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n> \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n>\n> -\tipa_ = pipe->createIPA(0, 0);\n> +\tipa_ = pipe->createIPA(\"simple\", 0, 0);\n> \tif (!ipa_) {\n> \t\tLOG(SoftwareIsp, Error)\n> \t\t\t<< \"Creating IPA for software ISP failed\";\n> --\n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2479BDCBD\n\tfor ;\n\tWed, 13 May 2026 14:50:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA7B062FEC;\n\tWed, 13 May 2026 16:50:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62AFE62010\n\tfor ;\n\tWed, 13 May 2026 16:50:40 +0200 (CEST)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FD6256D;\n\tWed, 13 May 2026 16:50:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cPkOdAsL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778683831;\n\tbh=3E7aCrH9h5gntG5R/Q9p6zD1QZBEp0rVHD/9fFdJuNI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cPkOdAsLt++udw13uQVPA/N0SSWoCnoA13wOPYY6R3u16bVPJXNY/xYek+vPvQIgi\n\tjmmn9ZBwf53p/FWxwILwNpiNKJ0EsCKUL7BW8F5CPhW0VvZQ/5mBZxJDUrs90JbG75\n\tPTlmFewJ6bDsg+XbwWkYxcka2zhYUa4jTTWS1Gpc=","Date":"Wed, 13 May 2026 16:50:37 +0200","From":"Jacopo Mondi ","To":"Hans de Goede ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v5 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","Message-ID":"","References":"<20260512175340.115153-1-johannes.goede@oss.qualcomm.com>\n\t<20260512175340.115153-5-johannes.goede@oss.qualcomm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260512175340.115153-5-johannes.goede@oss.qualcomm.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38890,"web_url":"https://patchwork.libcamera.org/comment/38890/","msgid":"","date":"2026-05-13T15:22:29","subject":"Re: [PATCH v5 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 12. 19:53 keltezéssel, Hans de Goede írta:\n> Explicitly specify the \"simple\" IPA name when loading the IPA so that\n> the softISP can be used with other pipeline-handlers too.\n> \n> Signed-off-by: Hans de Goede \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/software_isp/software_isp.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 781cf02f8..4f30aa180 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -129,7 +129,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n> \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n> \n> -\tipa_ = pipe->createIPA(0, 0);\n> +\tipa_ = pipe->createIPA(\"simple\", 0, 0);\n> \tif (!ipa_) {\n> \t\tLOG(SoftwareIsp, Error)\n> \t\t\t<< \"Creating IPA for software ISP failed\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9CE8CBDCBD\n\tfor ;\n\tWed, 13 May 2026 15:22:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C19863025;\n\tWed, 13 May 2026 17:22:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4716262010\n\tfor ;\n\tWed, 13 May 2026 17:22:33 +0200 (CEST)","from [192.168.33.19] (185.182.215.166.nat.pool.zt.hu\n\t[185.182.215.166])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9366256D;\n\tWed, 13 May 2026 17:22:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TCW3FWIk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778685744;\n\tbh=sjJilyY3Dz5kCo8tXcXQIP/l0iSCWO3wa2mYM0mB5Tg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=TCW3FWIkQ8LZs4KlxCnBQRavSWiD0M4fyTWff0WjSVP6X37Yvvkmdof/agHWEtwmi\n\tDsHd7B5AsRsTtqiubc4o9rbBfGWEs6R+2NR1ee3jdC9gCi2nyYTGLs/YSvA+2ZzQUi\n\tWlt2p20V4mMTOTq6+mNbUrg8Hi8+W6HZcblxdA4g=","Message-ID":"","Date":"Wed, 13 May 2026 17:22:29 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","To":"Hans de Goede ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260512175340.115153-1-johannes.goede@oss.qualcomm.com>\n\t<20260512175340.115153-5-johannes.goede@oss.qualcomm.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260512175340.115153-5-johannes.goede@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]