{"id":26737,"url":"https://patchwork.libcamera.org/api/patches/26737/?format=json","web_url":"https://patchwork.libcamera.org/patch/26737/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260512141840.166903-1-laurent.pinchart@ideasonboard.com>","date":"2026-05-12T14:18:40","name":"apps: common: options: Use character literal instead of string","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d3fa58a672dd8e5c2dcd26d17779bca3b90194ac","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26737/mbox/","series":[{"id":5938,"url":"https://patchwork.libcamera.org/api/series/5938/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5938","date":"2026-05-12T14:18:40","name":"apps: common: options: Use character literal instead of string","version":1,"mbox":"https://patchwork.libcamera.org/series/5938/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26737/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26737/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC701BDCBD\n\tfor ;\n\tTue, 12 May 2026 14:18:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19BB36301E;\n\tTue, 12 May 2026 16:18:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 338936271A\n\tfor ;\n\tTue, 12 May 2026 16:18:42 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A7DF56D\n\tfor ;\n\tTue, 12 May 2026 16:18:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VlIhGuBE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778595514;\n\tbh=0C7NkGZXHeneZuf+01W6/3zH1d/tX4LVvPDffTiLd1s=;\n\th=From:To:Subject:Date:From;\n\tb=VlIhGuBE4wKlngKAfO08fMqfIEs2Mj+zsUZELcKXY+l4ysC9Fe+5BSkLlW1EoZiV6\n\tZ7r+4d+51BXxCwotCJLx7KNf0MOT9rERDV3psbr7rhcbObGltAlUQrhsZVH6CcjMiJ\n\trZlis5MattDSUzlvHHSc/qjb9gIp7Ph91UfpNwHU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH] apps: common: options: Use character literal instead of\n\tstring","Date":"Tue, 12 May 2026 17:18:40 +0300","Message-ID":"<20260512141840.166903-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"gcc 12 generates a `-Wrestrict` warning at -O3 optimization levels in\nC++20:\n\ng++-12 -Isrc/apps/common/libapps.a.p -Isrc/apps/common -I../src/apps/common -Iinclude -I../include -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++20 -O3 -Wnon-virtual-dtor -Wno-redundant-move -Wmissing-declarations -Wshadow -include /builds/pinchartl/libcamera/build/config.h -fPIC -DHAVE_TIFF -MD -MQ src/apps/common/libapps.a.p/options.cpp.o -MF src/apps/common/libapps.a.p/options.cpp.o.d -o src/apps/common/libapps.a.p/options.cpp.o -c ../src/apps/common/options.cpp\nIn file included from /usr/include/c++/12/string:40,\n from /usr/include/c++/12/bits/locale_classes.h:40,\n from /usr/include/c++/12/bits/ios_base.h:41,\n from /usr/include/c++/12/iomanip:40,\n from ../src/apps/common/options.cpp:10:\nIn static member function ‘static constexpr std::char_traits::char_type* std::char_traits::copy(char_type*, const char_type*, std::size_t)’,\n inlined from ‘static constexpr void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_S_copy(_CharT*, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:423:21,\n inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Allocator>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_replace(size_type, size_type, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.tcc:532:22,\n inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::replace(size_type, size_type, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:2171:19,\n inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::insert(size_type, const _CharT*) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:1928:22,\n inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Allocator> std::operator+(const _CharT*, __cxx11::basic_string<_CharT, _Traits, _Allocator>&&) [with _CharT = char; _Traits = char_traits; _Alloc = allocator]’ at /usr/include/c++/12/bits/basic_string.h:3541:36,\n inlined from ‘std::string Option::optionName() const’ at ../src/apps/common/options.cpp:149:34:\n/usr/include/c++/12/bits/char_traits.h:431:56: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ accessing 9223372036854775810 or more bytes at offsets [18, 9223372036854775807] and 17 may overlap up to 9223372036854775813 bytes at offset -3 [-Werror=restrict]\n 431 | return static_cast(__builtin_memcpy(__s1, __s2, __n));\n | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~\n\nWork around the issue by using a character literal instead of a string\nliteral for single character strings.\n\nSigned-off-by: Laurent Pinchart \n---\n src/apps/common/options.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: b0dbd5100b1b1665dd2bc839d06263d55a89a6bd","diff":"diff --git a/src/apps/common/options.cpp b/src/apps/common/options.cpp\nindex b95f95afadf3..be0c161165ea 100644\n--- a/src/apps/common/options.cpp\n+++ b/src/apps/common/options.cpp\n@@ -146,7 +146,7 @@ std::string Option::optionName() const\n \tif (name)\n \t\treturn \"--\" + std::string(name);\n \telse\n-\t\treturn \"-\" + std::string(1, opt);\n+\t\treturn '-' + std::string(1, opt);\n }\n \n /* -----------------------------------------------------------------------------\n","prefixes":[]}