[{"id":38822,"web_url":"https://patchwork.libcamera.org/comment/38822/","msgid":"<20260508120033.GI2176058@killaraus.ideasonboard.com>","date":"2026-05-08T12:00:33","subject":"Re: [PATCH v1 1/2] libcamera: base: bound_method: Strip qualifiers\n\tin argument pack","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 08, 2026 at 11:28:15AM +0200, Barnabás Pőcze wrote:\n> Having extra qualifiers, especially `const`, simply inhibits optimization\n> opportunities as it prevents e.g. moving values out of pack object. So\n> strip the qualifiers.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/bound_method.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/base/bound_method.h b/include/libcamera/base/bound_method.h\n> index 91fe8b8cb9..cb642e0a9b 100644\n> --- a/include/libcamera/base/bound_method.h\n> +++ b/include/libcamera/base/bound_method.h\n> @@ -39,7 +39,7 @@ public:\n> \t{\n> \t}\n> \n> -\tstd::tuple...> args_;\n> +\tstd::tuple>...> args_;\n> \tR ret_;\n> };\n> \n> @@ -53,7 +53,7 @@ public:\n> \t{\n> \t}\n> \n> -\tstd::tuple...> args_;\n> +\tstd::tuple>...> args_;\n> };\n> \n> class BoundMethodBase","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1F01BE173\n\tfor ;\n\tFri, 8 May 2026 12:00:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00A0C6301A;\n\tFri, 8 May 2026 14:00:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 248A062FD3\n\tfor ;\n\tFri, 8 May 2026 14:00:35 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37DC8BCA;\n\tFri, 8 May 2026 14:00:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XSdwcpOU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778241630;\n\tbh=KbfxQaaW/iAixjXLlOHfmJ1NE5IQ51WJXJhg2y+26yU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XSdwcpOUtMg/3PTw5SxiVwGXtpR/0ZpgkqlPWe6tPFH3/BwWmPYx+EuUfgMXGl/u6\n\txS6hNGPcpYzGYbmOCGyhKo9A+Oqd8T0FIgGDmQb9QNRIdFc5Rdbm0uPCh5mBzw1a92\n\tZe+zpmLQ5NN0XOkmj78Mo04P/TzWQAELdQuV50WU=","Date":"Fri, 8 May 2026 15:00:33 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStefan Klug ,\n\tKieran Bingham ","Subject":"Re: [PATCH v1 1/2] libcamera: base: bound_method: Strip qualifiers\n\tin argument pack","Message-ID":"<20260508120033.GI2176058@killaraus.ideasonboard.com>","References":"<20260508092816.119642-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260508092816.119642-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]