{"id":26687,"url":"https://patchwork.libcamera.org/api/patches/26687/?format=json","web_url":"https://patchwork.libcamera.org/patch/26687/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260508092816.119642-1-barnabas.pocze@ideasonboard.com>","date":"2026-05-08T09:28:15","name":"[v1,1/2] libcamera: base: bound_method: Strip qualifiers in argument pack","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"37f9f584c403afac08de3c7d9f5ef5cd5138511a","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26687/mbox/","series":[{"id":5922,"url":"https://patchwork.libcamera.org/api/series/5922/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5922","date":"2026-05-08T09:28:15","name":"[v1,1/2] libcamera: base: bound_method: Strip qualifiers in argument pack","version":1,"mbox":"https://patchwork.libcamera.org/series/5922/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26687/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26687/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A559DBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  8 May 2026 09:28:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E64D763029;\n\tFri,  8 May 2026 11:28:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 455F362FE1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 May 2026 11:28:19 +0200 (CEST)","from pb-laptop.local (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B5CCBCA;\n\tFri,  8 May 2026 11:28:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FOwBU0gM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778232494;\n\tbh=BI3SjSAZondlzdkfkIM04C0kXY4bBXbfbn6fyfc1HL4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FOwBU0gM4mbe+f20fy6jjTv3S+QVEPr63IG8BxZ21tuDnHsSwxzTXeJol4ZXOzuJN\n\t75oSd5OdEWFn7BsJKHz0L7HnddjArrRhWXhqHPAUmp+jI2Ljcv4YmOn7MzAlk9xkhz\n\tiXECyO5PpdGY03El0sdSQVd9yH9uLcZxU9lvfXTs=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"[PATCH v1 1/2] libcamera: base: bound_method: Strip qualifiers in\n\targument pack","Date":"Fri,  8 May 2026 11:28:15 +0200","Message-ID":"<20260508092816.119642-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Having extra qualifiers, especially `const`, simply inhibits optimization\nopportunities as it prevents e.g. moving values out of pack object. So\nstrip the qualifiers.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/base/bound_method.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/base/bound_method.h b/include/libcamera/base/bound_method.h\nindex 91fe8b8cb9..cb642e0a9b 100644\n--- a/include/libcamera/base/bound_method.h\n+++ b/include/libcamera/base/bound_method.h\n@@ -39,7 +39,7 @@ public:\n \t{\n \t}\n \n-\tstd::tuple<typename std::remove_reference_t<Args>...> args_;\n+\tstd::tuple<std::remove_cv_t<std::remove_reference_t<Args>>...> args_;\n \tR ret_;\n };\n \n@@ -53,7 +53,7 @@ public:\n \t{\n \t}\n \n-\tstd::tuple<typename std::remove_reference_t<Args>...> args_;\n+\tstd::tuple<std::remove_cv_t<std::remove_reference_t<Args>>...> args_;\n };\n \n class BoundMethodBase\n","prefixes":["v1","1/2"]}