[{"id":38799,"web_url":"https://patchwork.libcamera.org/comment/38799/","msgid":"<5f15712a-2139-4317-ba7a-92638a4f9bfa@ideasonboard.com>","date":"2026-05-08T08:31:30","subject":"Re: [PATCH 1/3] ipa: libipa: v4l2_params: Mention ISP in file\n\tone-line description","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 07. 23:37 keltezéssel, Laurent Pinchart írta:\n> The v4l2_params.{cpp,h} files are helpers classes for the V4L2 ISP\n> parameters buffers. Mention \"ISP\" in the one-line file description to\n> clarify this.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/libipa/v4l2_params.cpp | 2 +-\n> src/ipa/libipa/v4l2_params.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/v4l2_params.cpp b/src/ipa/libipa/v4l2_params.cpp\n> index a1eeeb1b0e6a..c2971f1caf28 100644\n> --- a/src/ipa/libipa/v4l2_params.cpp\n> +++ b/src/ipa/libipa/v4l2_params.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2025, Ideas On Board\n> *\n> - * V4L2 Parameters\n> + * V4L2 ISP Parameters\n> */\n> \n> #include \"v4l2_params.h\"\n> diff --git a/src/ipa/libipa/v4l2_params.h b/src/ipa/libipa/v4l2_params.h\n> index b9ef6cfb3b5b..f400b37d74b5 100644\n> --- a/src/ipa/libipa/v4l2_params.h\n> +++ b/src/ipa/libipa/v4l2_params.h\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2025, Ideas On Board\n> *\n> - * V4L2 Parameters\n> + * V4L2 ISP Parameters\n> */\n> \n> #pragma once\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30B4CBE173\n\tfor ;\n\tFri, 8 May 2026 08:31:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 603DB63025;\n\tFri, 8 May 2026 10:31:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8FEA62E6A\n\tfor ;\n\tFri, 8 May 2026 10:31:33 +0200 (CEST)","from [192.168.33.85] (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 363D7ABF;\n\tFri, 8 May 2026 10:31:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g8xVi56u\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778229089;\n\tbh=+M+FwPEgbLYl/QnTMl8Rh9cvrWLXkemzTh1urweBeXQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=g8xVi56u8QzgcyG9JfzAJxFWWVP5edo0/uYN4bSivDcxciMI6SDz67ynA23vsaCBf\n\tBMkcgwpxxidlUHh/TVKZ3Cu630QHKO7eAm+8hiDGu0ZtnidGkHfQ3lr4H4hyZ+pXMS\n\tdRBfsy0oP76VSprYzK9RrC9Zeoy5CpOhUo5/7oZo=","Message-ID":"<5f15712a-2139-4317-ba7a-92638a4f9bfa@ideasonboard.com>","Date":"Fri, 8 May 2026 10:31:30 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/3] ipa: libipa: v4l2_params: Mention ISP in file\n\tone-line description","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260507213721.2137448-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20260507213721.2137448-2-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260507213721.2137448-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38806,"web_url":"https://patchwork.libcamera.org/comment/38806/","msgid":"<177823142258.3304204.12136432379043306371@ping.linuxembedded.co.uk>","date":"2026-05-08T09:10:22","subject":"Re: [PATCH 1/3] ipa: libipa: v4l2_params: Mention ISP in file\n\tone-line description","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-05-07 22:37:19)\n> The v4l2_params.{cpp,h} files are helpers classes for the V4L2 ISP\n> parameters buffers. Mention \"ISP\" in the one-line file description to\n> clarify this.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/libipa/v4l2_params.cpp | 2 +-\n> src/ipa/libipa/v4l2_params.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/v4l2_params.cpp b/src/ipa/libipa/v4l2_params.cpp\n> index a1eeeb1b0e6a..c2971f1caf28 100644\n> --- a/src/ipa/libipa/v4l2_params.cpp\n> +++ b/src/ipa/libipa/v4l2_params.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2025, Ideas On Board\n> *\n> - * V4L2 Parameters\n> + * V4L2 ISP Parameters\n> */\n> \n> #include \"v4l2_params.h\"\n> diff --git a/src/ipa/libipa/v4l2_params.h b/src/ipa/libipa/v4l2_params.h\n> index b9ef6cfb3b5b..f400b37d74b5 100644\n> --- a/src/ipa/libipa/v4l2_params.h\n> +++ b/src/ipa/libipa/v4l2_params.h\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2025, Ideas On Board\n> *\n> - * V4L2 Parameters\n> + * V4L2 ISP Parameters\n> */\n> \n> #pragma once\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0949BDCBD\n\tfor ;\n\tFri, 8 May 2026 09:10:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A1A062FE8;\n\tFri, 8 May 2026 11:10:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F30062FE1\n\tfor ;\n\tFri, 8 May 2026 11:10:25 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C138EBCA;\n\tFri, 8 May 2026 11:10:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C73HiO1f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778231420;\n\tbh=hzMAE16zWPSALRq2BR3B7duaDR+hXXpmmnqm4JXMXvc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=C73HiO1f6XZhkuu807/B2vgoKcO9MsnROaUsyaR5uCRTeh8KQh42d7KkR5Qhhw8tc\n\tIHx86dPxsZYzHNC82BkKRbmO4PA3ATmRLPRkNX5Vorx6+Pb8vetzIEasxSH3BOF8P8\n\tsm19G6RiXfJI96Z/l2bXDmtsTrywpyI34VFmVvm0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260507213721.2137448-2-laurent.pinchart@ideasonboard.com>","References":"<20260507213721.2137448-1-laurent.pinchart@ideasonboard.com>\n\t<20260507213721.2137448-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 1/3] ipa: libipa: v4l2_params: Mention ISP in file\n\tone-line description","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 08 May 2026 10:10:22 +0100","Message-ID":"<177823142258.3304204.12136432379043306371@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]