[{"id":38794,"web_url":"https://patchwork.libcamera.org/comment/38794/","msgid":"","date":"2026-05-08T06:59:32","subject":"Re: [PATCH v1 1/2] libcamera: software_isp: Drop redundant sumShift_\n\tguard in finishFrame","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 07. 18:03 keltezéssel, Javier Tia írta:\n> Right-shifting by zero is a no-op, so the if (sumShift_) check before\n> the three >>= sumShift_ assignments is unnecessary. Remove it.\n> \n> Suggested-by: Laurent Pinchart \n> Suggested-by: Barnabas Pocze \n> Signed-off-by: Javier Tia \n> ---\n> src/libcamera/software_isp/swstats_cpu.cpp | 8 +++-----\n> 1 file changed, 3 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> index b40d3334..d9011f41 100644\n> --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> @@ -362,11 +362,9 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n> \t\t\tfor (unsigned int j = 0; j < SwIspStats::kYHistogramSize; j++)\n> \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n> \t\t}\n> -\t\tif (sumShift_) {\n> -\t\t\tsharedStats_->sum_.r() >>= sumShift_;\n> -\t\t\tsharedStats_->sum_.g() >>= sumShift_;\n> -\t\t\tsharedStats_->sum_.b() >>= sumShift_;\n> -\t\t}\n> +\t\tsharedStats_->sum_.r() >>= sumShift_;\n> +\t\tsharedStats_->sum_.g() >>= sumShift_;\n> +\t\tsharedStats_->sum_.b() >>= sumShift_;\n\nI kind of wanted to suggest adding `operator>>{,=}` to the `Vector` class\nbut let's not get too carried away.\n\nReviewed-by: Barnabás Pőcze \n\n\n> \t}\n> \n> \tsharedStats_->valid = valid;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1DE3FBE173\n\tfor ;\n\tFri, 8 May 2026 06:59:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7268663021;\n\tFri, 8 May 2026 08:59:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B48262FE1\n\tfor ;\n\tFri, 8 May 2026 08:59:35 +0200 (CEST)","from [192.168.33.85] (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8584CABF;\n\tFri, 8 May 2026 08:59:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mDwDuX4r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778223570;\n\tbh=sgxRU+lxIPqSL/twoe79i66936Euwmv/A5xN7sf3dtI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=mDwDuX4r/ejWWuT2nQJIrwsnPJVW6ai8LeulxsQpXkp6bI/WtKA4PG+uQio4uy8Qo\n\t9tmuSHV2+i9hAn90SzwJQ6v7fwaPmxXLSBvX1zWzDJrBLlBc+cwG7cyUTaMH4Xwvje\n\trTafXatb9TMFR4I1JVovjYDhYODHvJAC0FzRgXY0=","Message-ID":"","Date":"Fri, 8 May 2026 08:59:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/2] libcamera: software_isp: Drop redundant sumShift_\n\tguard in finishFrame","To":"Javier Tia , libcamera-devel@lists.libcamera.org","Cc":"mzamazal@redhat.com, kieran.bingham@ideasonboard.com,\n\tlaurent.pinchart@ideasonboard.com","References":"<177817025814.1112523.8335692307235726369@jetm.me>\n\t<20260507161101.7D2CD1EA006B@mailuser.phl.internal>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260507161101.7D2CD1EA006B@mailuser.phl.internal>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38810,"web_url":"https://patchwork.libcamera.org/comment/38810/","msgid":"<20260508093152.GA2176058@killaraus.ideasonboard.com>","date":"2026-05-08T09:31:52","subject":"Re: [PATCH v1 1/2] libcamera: software_isp: Drop redundant sumShift_\n\tguard in finishFrame","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 08, 2026 at 08:59:32AM +0200, Barnabás Pőcze wrote:\n> 2026. 05. 07. 18:03 keltezéssel, Javier Tia írta:\n> > Right-shifting by zero is a no-op, so the if (sumShift_) check before\n> > the three >>= sumShift_ assignments is unnecessary. Remove it.\n> > \n> > Suggested-by: Laurent Pinchart \n> > Suggested-by: Barnabas Pocze \n> > Signed-off-by: Javier Tia \n> > ---\n> > src/libcamera/software_isp/swstats_cpu.cpp | 8 +++-----\n> > 1 file changed, 3 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> > index b40d3334..d9011f41 100644\n> > --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> > +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> > @@ -362,11 +362,9 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n> > \t\t\tfor (unsigned int j = 0; j < SwIspStats::kYHistogramSize; j++)\n> > \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n> > \t\t}\n> > -\t\tif (sumShift_) {\n> > -\t\t\tsharedStats_->sum_.r() >>= sumShift_;\n> > -\t\t\tsharedStats_->sum_.g() >>= sumShift_;\n> > -\t\t\tsharedStats_->sum_.b() >>= sumShift_;\n> > -\t\t}\n> > +\t\tsharedStats_->sum_.r() >>= sumShift_;\n> > +\t\tsharedStats_->sum_.g() >>= sumShift_;\n> > +\t\tsharedStats_->sum_.b() >>= sumShift_;\n> \n> I kind of wanted to suggest adding `operator>>{,=}` to the `Vector` class\n> but let's not get too carried away.\n\nI thought about the same :-) On top of this patch of course.\n\n> Reviewed-by: Barnabás Pőcze \n> \n> > \t}\n> > \n> > \tsharedStats_->valid = valid;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EF10BE173\n\tfor ;\n\tFri, 8 May 2026 09:31:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 483126301E;\n\tFri, 8 May 2026 11:31:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C29962FEC\n\tfor ;\n\tFri, 8 May 2026 11:31:54 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 906A2BCA;\n\tFri, 8 May 2026 11:31:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qIHF+jT2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778232709;\n\tbh=MDmT/rfb5HQFrbzdh0Hqj+8EueI84XPkL8KEozo4YJU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qIHF+jT2ol/KP7u4CgT+T5FRfguY9CGgzCxQbkV5nN4pWn8kARslzV2wM0OWyQV+X\n\tmO1NBTgZtqJ3y6K06O6Ch6TNQrbKhLAW4QzVPBFRxrgQiQmfy//cYOBsQLKjMljKY9\n\tpQnhbKt4WegjfVsYMCNke96OdWUXFuG/C9rboBdI=","Date":"Fri, 8 May 2026 12:31:52 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Javier Tia , libcamera-devel@lists.libcamera.org,\n\tmzamazal@redhat.com, kieran.bingham@ideasonboard.com","Subject":"Re: [PATCH v1 1/2] libcamera: software_isp: Drop redundant sumShift_\n\tguard in finishFrame","Message-ID":"<20260508093152.GA2176058@killaraus.ideasonboard.com>","References":"<177817025814.1112523.8335692307235726369@jetm.me>\n\t<20260507161101.7D2CD1EA006B@mailuser.phl.internal>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]