[{"id":3505,"web_url":"https://patchwork.libcamera.org/comment/3505/","msgid":"<20200118174330.GA5095@pendragon.ideasonboard.com>","date":"2020-01-18T17:43:30","subject":"Re: [libcamera-devel] [PATCH v3 1/6] checkstyle: Move from pep8 to\n\tpycodestyle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Fri, Jan 17, 2020 at 10:54:43PM -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> The tool has been renamed in 2016 to make it more obvious what it\n> is doing. There is no other changes needed on our side.\n> \n> See https://github.com/PyCQA/pycodestyle/issues/466\n> \n> Signed-off-by: Nicolas Dufresne \n> Reviewed-by: Kieran Bingham \n> ---\n> utils/checkstyle.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 93f0291..7edea25 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):\n> data = ''.join(self.__content).encode('utf-8')\n> \n> try:\n> - ret = subprocess.run(['pep8', '--ignore=E501', '-'],\n> + ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],\n> input=data, stdout=subprocess.PIPE)\n> except FileNotFoundError:\n> - issues.append(StyleIssue(0, None, \"Please install pep8 to validate python additions\"))\n> + issues.append(StyleIssue(0, None, \"Please install pycodestyle to validate python additions\"))\n> return issues\n> \n> results = ret.stdout.decode('utf-8').splitlines()","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37ECD60455\n\tfor ;\n\tSat, 18 Jan 2020 18:43:45 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA26897A;\n\tSat, 18 Jan 2020 18:43:44 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579369424;\n\tbh=0S0rMhcKXRIe6TpFIHEeqnwBaWbNooVYLyqZNAapbSs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VlslEAmvdrz32+dX60xJoaKaZJyqRcbWHFclnayyvNvcqf3/aNHvkgsgqpVFzw8Mq\n\tGjKWkX7XhMF5rDWpCRpRO7gvxnNL/NjG671Kld/Wv0lZoamhLVQ7fe79UjoOZ8fA0G\n\t4ggOkMmi7Rvf5TNGBkeb+Ak+ZgHTNF5bNh0v8pOQ=","Date":"Sat, 18 Jan 2020 19:43:30 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Message-ID":"<20200118174330.GA5095@pendragon.ideasonboard.com>","References":"<20200118035448.230530-1-nicolas@ndufresne.ca>\n\t<20200118035448.230530-2-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200118035448.230530-2-nicolas@ndufresne.ca>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 1/6] checkstyle: Move from pep8 to\n\tpycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 Jan 2020 17:43:45 -0000"}},{"id":3510,"web_url":"https://patchwork.libcamera.org/comment/3510/","msgid":"<20200118181607.GF5095@pendragon.ideasonboard.com>","date":"2020-01-18T18:16:07","subject":"Re: [libcamera-devel] [PATCH v3 1/6] checkstyle: Move from pep8 to\n\tpycodestyle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Jan 18, 2020 at 07:43:30PM +0200, Laurent Pinchart wrote:\n> On Fri, Jan 17, 2020 at 10:54:43PM -0500, Nicolas Dufresne wrote:\n> > From: Nicolas Dufresne \n> > \n> > The tool has been renamed in 2016 to make it more obvious what it\n> > is doing. There is no other changes needed on our side.\n> > \n> > See https://github.com/PyCQA/pycodestyle/issues/466\n> > \n> > Signed-off-by: Nicolas Dufresne \n> > Reviewed-by: Kieran Bingham \n\nI forgot to say\n\nReviewed-by: Laurent Pinchart \n\n:-)\n\n> > ---\n> > utils/checkstyle.py | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> > index 93f0291..7edea25 100755\n> > --- a/utils/checkstyle.py\n> > +++ b/utils/checkstyle.py\n> > @@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):\n> > data = ''.join(self.__content).encode('utf-8')\n> > \n> > try:\n> > - ret = subprocess.run(['pep8', '--ignore=E501', '-'],\n> > + ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],\n> > input=data, stdout=subprocess.PIPE)\n> > except FileNotFoundError:\n> > - issues.append(StyleIssue(0, None, \"Please install pep8 to validate python additions\"))\n> > + issues.append(StyleIssue(0, None, \"Please install pycodestyle to validate python additions\"))\n> > return issues\n> > \n> > results = ret.stdout.decode('utf-8').splitlines()","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B738D60455\n\tfor ;\n\tSat, 18 Jan 2020 19:16:22 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3834097A;\n\tSat, 18 Jan 2020 19:16:22 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579371382;\n\tbh=8/jJXty5APgvImeVQVE3+F/xP7k0MmdiKPJTdejmMmk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UuYnitgQvG1auCs9RlYwRfYcdl6hcqMJyZLQEfDQZ/6q7cRMFyZJiI6K1KnkCdRV5\n\tf+Je/w/dGDgO+H+M+vEEZYnLVd54hKRT4GmYuBkVqaAYr2L+uhPSXv7D5C+YgA1oBM\n\tJTig1sduc9rbm6f0y2+ZUrBjFM3Vfd6oxWgodLjM=","Date":"Sat, 18 Jan 2020 20:16:07 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Message-ID":"<20200118181607.GF5095@pendragon.ideasonboard.com>","References":"<20200118035448.230530-1-nicolas@ndufresne.ca>\n\t<20200118035448.230530-2-nicolas@ndufresne.ca>\n\t<20200118174330.GA5095@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200118174330.GA5095@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 1/6] checkstyle: Move from pep8 to\n\tpycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 Jan 2020 18:16:22 -0000"}}]