{"id":2666,"url":"https://patchwork.libcamera.org/api/patches/2666/?format=json","web_url":"https://patchwork.libcamera.org/patch/2666/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200117191733.198897-7-nicolas@ndufresne.ca>","date":"2020-01-17T19:17:33","name":"[libcamera-devel,v2,6/6] checkstyle: Add a pre-commit hook script","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ff501fc42bac09c4817e182aad2560583a36b82b","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2666/mbox/","series":[{"id":634,"url":"https://patchwork.libcamera.org/api/series/634/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=634","date":"2020-01-17T19:17:27","name":"Add the ability to do pre-commit style check","version":2,"mbox":"https://patchwork.libcamera.org/series/634/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2666/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2666/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2EAB6078C\n\tfor ;\n\tFri, 17 Jan 2020 20:18:01 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::127])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 39D812949D4;\n\tFri, 17 Jan 2020 19:18:01 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","Date":"Fri, 17 Jan 2020 14:17:33 -0500","Message-Id":"<20200117191733.198897-7-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200117191733.198897-1-nicolas@ndufresne.ca>","References":"<20200117191733.198897-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 6/6] checkstyle: Add a pre-commit hook\n\tscript","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Jan 2020 19:18:02 -0000"},"content":"From: Nicolas Dufresne \n\nThis adds support for pre-commit hook workflow. In pre-commit hook we\ncheck the style on the changes currently staged or the combination\nof the index and the last commit if \"git commit --amend\" is being used.\n\nSigned-off-by: Nicolas Dufresne \n---\n utils/hooks/pre-commit | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)\n create mode 100755 utils/hooks/pre-commit","diff":"diff --git a/utils/hooks/pre-commit b/utils/hooks/pre-commit\nnew file mode 100755\nindex 0000000..be2f8b3\n--- /dev/null\n+++ b/utils/hooks/pre-commit\n@@ -0,0 +1,17 @@\n+#!/bin/sh\n+\n+# Execute the checkstyle script after committing any code. This allows the\n+# commit to succeed, but ensures that the developer is aware of any potential\n+# issues immediately, and can resolve them and fix rapidly with:\n+# git commit --amend\n+#\n+# To utilise this hook, install this file with:\n+# cp utils/hooks/post-commit .git/hooks/post-commit\n+\n+args=\"--staged\"\n+if ps -ocommand= -p $PPID | grep -- \"--amend\"\n+then\n+ commit=\"--amend\"\n+fi\n+\n+./utils/checkstyle.py $args\n","prefixes":["libcamera-devel","v2","6/6"]}