{"id":26659,"url":"https://patchwork.libcamera.org/api/patches/26659/?format=json","web_url":"https://patchwork.libcamera.org/patch/26659/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260506230722.1041596-3-devve.3@gmail.com>","date":"2026-05-06T23:07:14","name":"[v2,02/10] ipa: simple: awb: Add temporal smoothing and per-channel gain limits","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"64ac7184e713ef556b1bc74a9066bbab4453895d","submitter":{"id":271,"url":"https://patchwork.libcamera.org/api/people/271/?format=json","name":"devve","email":"devve.3@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26659/mbox/","series":[{"id":5915,"url":"https://patchwork.libcamera.org/api/series/5915/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5915","date":"2026-05-06T23:07:12","name":"OV01A10 sensor support and simple IPA improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5915/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26659/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26659/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5CCCC32FE\n\tfor ;\n\tWed, 6 May 2026 23:07:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0DCC63040;\n\tThu, 7 May 2026 01:07:30 +0200 (CEST)","from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com\n\t[IPv6:2607:f8b0:4864:20::72f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ED076303C\n\tfor ;\n\tThu, 7 May 2026 01:07:29 +0200 (CEST)","by mail-qk1-x72f.google.com with SMTP id\n\taf79cd13be357-8ec9f099fc6so28039985a.0\n\tfor ;\n\tWed, 06 May 2026 16:07:29 -0700 (PDT)","from dexps.speedport.ip\n\t(p200300eda74453cf3cf3f7929e513b94.dip0.t-ipconnect.de.\n\t[2003:ed:a744:53cf:3cf3:f792:9e51:3b94])\n\tby smtp.gmail.com with ESMTPSA id\n\taf79cd13be357-8fc2c25324esm2035266385a.23.2026.05.06.16.07.27\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 May 2026 16:07:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mW8fESsE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20251104; t=1778108848; x=1778713648;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=vpT2omGvrrBC/UWz9mRqAkO01quAcHHbvl8N34ZIhJU=;\n\tb=mW8fESsE77c75Pp5SGeBgfUJam1cwdkUVOpyts8V2/qpnLAIZkti5BerdlzDgYJC8p\n\t/pGnBtml4Cdr1fYcQVHX2giRRJaZ9sZLcm+xKgQkBwyJ56QMNuTRTropBbkZ4MEMq7hK\n\t8kxbF1Wwl65esQKw/T2/+RcHbt5+CuXCZarOy3oHSD+ZgJwXoyXy+cZ8Y2zN5DYPKakn\n\twiEEL6xW6ZSUI2mjU2qIG1zPd8cZgXe28eDbwfLWsmx4OffvrgNavipZq6pkfqgdq4WM\n\tXDq0QQU7Arq/I5BB6l+1nUH6IVYR5SU+DO2e/S52RnnNxkNCJjEBeDBOp2ngjzPh4o9X\n\tX6Gw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1778108848; x=1778713648;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=vpT2omGvrrBC/UWz9mRqAkO01quAcHHbvl8N34ZIhJU=;\n\tb=mmCN4s/Zv/jiXNg7Dh6bmulDVN1lW8BEnxHZ4l8EOrAh/A9bY3P41j5snKQb/EiMRE\n\tOx60yPNLtZ0guyFVFbdsj6kX4OWXFtWIT8wlAgCXoTdiO6TqpuNf0K8cB0Q+5NEIuvaT\n\t58In7D4R6X/JRUGy4wznSy+prcXw5rjQEo71Cie7K34JI3ktvBXu3iq4z2FpBcQifiUZ\n\tZj+rP13+Npuzp9FNiBlmaSs/KEqQSYv3lPEihoueOihzI4LbRRHBqEzz3ZW+SD0CVcUy\n\te1eO+tBvD1Hib4WzBWTKY7EQ+L2a4L+GG2xNHQ+4fI0u+1mq5UlCwhxy9v+rzjUVaFtD\n\tetHQ==","X-Gm-Message-State":"AOJu0YwYZXJjr7+rcyoplNG+3zbZshpYM1MNwnjKZHkCDNjGkTqrqJ0J\n\tiWl2oECIjWjYIwBiz2LCviJ5dk/K7c98dsmNC5j0SOXVxqmVZDieVL/c4xVsGA==","X-Gm-Gg":"AeBDietHxba0+bJaP1zRS9rgLd/eJqijknt3V8iUvcFRv03Mt4rGsOGyToZsNamN2v0\n\tF/h6aNt9SRPGYiQY9El1afriHiGwc73n7ShvvDd9akckklK3Rl63xNOTrEhrVF0uEF/C6t2jJw7\n\teYkignrfY1oEI40AkimFfwOO3tV7odT0Y7sz9PWLN0XjUnxSlT9ngwZDsG0DuGnL00omqHn1FhH\n\tlQHe/48ep+w82q08rIv76Sa/aITO6erwcP7P+1caPFX3sIEdLI9gom8Myqmc/uO8CIxEpDM+pmP\n\tkx50yZODT3UC5F/ZJYd6N4BLCvmecGoEdYnQWIcDLxvZOyBFR5/u/oDDkGpixvt0N5Nw11TRJD7\n\to9b5ZgZsBWFAcbtJzosvVARCwOWDzym7gVzaJJf9ijOiXBDZKQPXQLgAFc29UDadUrbAwm+FHEJ\n\tb/6xKcQlvqQXuklwmhBA/hMypPxpLjohp8T8HuUFfAPULia2PNg0QL3IgPrQ5mPKKA2ex4ySKj3\n\t5R1nB2aPCxbCyUjaooI+CeSKkRsGEog","X-Received":"by 2002:a05:620a:4591:b0:8eb:d38d:2013 with SMTP id\n\taf79cd13be357-904d496d4b6mr849920385a.17.1778108847994; \n\tWed, 06 May 2026 16:07:27 -0700 (PDT)","From":"d3vv3 ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 02/10] ipa: simple: awb: Add temporal smoothing and\n\tper-channel gain limits","Date":"Thu, 7 May 2026 01:07:14 +0200","Message-ID":"<20260506230722.1041596-3-devve.3@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260506230722.1041596-1-devve.3@gmail.com>","References":"<20260506230722.1041596-1-devve.3@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add configurable YAML parameters maxGainR, maxGainB, and speed to AWB.\nReplace the single hardcoded max gain (4.0x) with per-channel limits,\nand apply exponential moving average smoothing to reduce colour\ntemperature oscillation between frames.\n\nSigned-off-by: d3vv3 \n---\n src/ipa/simple/algorithms/awb.cpp | 34 ++++++++++++++++++++++++++-----\n src/ipa/simple/algorithms/awb.h | 6 ++++++\n 2 files changed, 35 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex f5c88ea6..937aabc8 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -14,6 +14,8 @@\n \n #include \n \n+#include \"libcamera/internal/yaml_parser.h\"\n+\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n@@ -23,6 +25,21 @@ LOG_DEFINE_CATEGORY(IPASoftAwb)\n \n namespace ipa::soft::algorithms {\n \n+int Awb::init([[maybe_unused]] IPAContext &context,\n+\t const ValueNode &tuningData)\n+{\n+\tmaxGainR_ = tuningData[\"maxGainR\"].get().value_or(4.0f);\n+\tmaxGainB_ = tuningData[\"maxGainB\"].get().value_or(4.0f);\n+\tspeed_ = tuningData[\"speed\"].get().value_or(1.0f);\n+\n+\tLOG(IPASoftAwb, Debug)\n+\t\t<< \"AWB: maxGainR \" << maxGainR_\n+\t\t<< \", maxGainB \" << maxGainB_\n+\t\t<< \", speed \" << speed_;\n+\n+\treturn 0;\n+}\n+\n int Awb::configure(IPAContext &context,\n \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n {\n@@ -84,14 +101,21 @@ void Awb::process(IPAContext &context,\n \tconst RGB sum = stats->sum_.max(offset + minValid) - offset;\n \n \t/*\n-\t * Calculate red and blue gains for AWB.\n-\t * Clamp max gain at 4.0, this also avoids 0 division.\n+\t * Calculate red and blue gains for AWB. Clamp max gain to avoid\n+\t * division by zero and extreme color casts.\n \t */\n \tauto &gains = context.activeState.awb.gains;\n+\tfloat rawRGain = sum.r() <= sum.g() / maxGainR_ ? maxGainR_ :\n+\t\t\t\tstatic_cast(sum.g()) / sum.r();\n+\tfloat rawBGain = sum.b() <= sum.g() / maxGainB_ ? maxGainB_ :\n+\t\t\t\tstatic_cast(sum.g()) / sum.b();\n+\n+\t/* Apply temporal smoothing to avoid rapid white balance changes. */\n+\tfloat alpha = std::clamp(speed_, 0.01f, 1.0f);\n \tgains = { {\n-\t\tsum.r() <= sum.g() / 4 ? 4.0f : static_cast(sum.g()) / sum.r(),\n-\t\t1.0,\n-\t\tsum.b() <= sum.g() / 4 ? 4.0f : static_cast(sum.g()) / sum.b(),\n+\t\tgains.r() * (1.0f - alpha) + rawRGain * alpha,\n+\t\t1.0f,\n+\t\tgains.b() * (1.0f - alpha) + rawBGain * alpha,\n \t} };\n \n \tRGB rgbGains{ { 1 / gains.r(), 1 / gains.g(), 1 / gains.b() } };\ndiff --git a/src/ipa/simple/algorithms/awb.h b/src/ipa/simple/algorithms/awb.h\nindex ad993f39..0aedc1d1 100644\n--- a/src/ipa/simple/algorithms/awb.h\n+++ b/src/ipa/simple/algorithms/awb.h\n@@ -19,6 +19,7 @@ public:\n \tAwb() = default;\n \t~Awb() = default;\n \n+\tint init(IPAContext &context, const ValueNode &tuningData) override;\n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n \tvoid prepare(IPAContext &context,\n \t\t const uint32_t frame,\n@@ -29,6 +30,11 @@ public:\n \t\t IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n \t\t ControlList &metadata) override;\n+\n+private:\n+\tfloat maxGainR_;\n+\tfloat maxGainB_;\n+\tfloat speed_;\n };\n \n } /* namespace ipa::soft::algorithms */\n","prefixes":["v2","02/10"]}