[{"id":39653,"web_url":"https://patchwork.libcamera.org/comment/39653/","msgid":"<178360076077.1021520.12661562145617401065@ping.linuxembedded.co.uk>","date":"2026-07-09T12:39:20","subject":"Re: [PATCH v2 01/10] ipa: libipa: camera_sensor_helper: Add OV01A10","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting d3vv3 (2026-05-07 00:07:13)\n> From: Stuart J Mackintosh \n> \n> Add a CameraSensorHelper for the OmniVision OV01A10 image sensor,\n> used in Dell XPS 13 and other laptops with the Intel IPU6 camera\n> subsystem.\n> \n> The analogue gain register (0x3508) uses a Q6.8 fixed-point format,\n> with the minimum value OV01A10_ANAL_GAIN_MIN = 0x100 representing\n> unity gain. This gives the linear model:\n> \n> gain = code / 256\n> \n> Hans de Goede confirmed linear behaviour by monitoring the 18% grey\n> patch of a Macbeth chart under controlled lighting while stepping the\n> gain control.\n> \n> The black level of 0x40 at 10 bits (4096 scaled to 16 bits) was\n> confirmed by dark frame measurement with the lens covered.\n> \n> Without this helper, libcamera's AGC algorithm cannot convert between\n> gain codes and real gain values, causing auto-exposure oscillation and\n> the following warning:\n> \n> IPASoft: Failed to create camera sensor helper for ov01a10\n> \n> Signed-off-by: Stuart J Mackintosh \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index e3e3e535..72466867 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -653,6 +653,18 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n> \n> +class CameraSensorHelperOv01a10 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperOv01a10()\n> + {\n> + /* From dark frame measurement: 0x40 at 10bits. */\n> + blackLevel_ = 4096;\n> + gain_ = AnalogueGainLinear{ 1, 0, 0, 256 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov01a10\", CameraSensorHelperOv01a10)\n\nov01a10 is upstream, and the above looks reasonable so\n\n\nReviewed-by: Kieran Bingham \n\n> +\n> class CameraSensorHelperOv2685 : public CameraSensorHelper\n> {\n> public:\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90733BF415\n\tfor ;\n\tThu, 9 Jul 2026 12:39:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B258660E3;\n\tThu, 9 Jul 2026 14:39:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACDA165FA2\n\tfor ;\n\tThu, 9 Jul 2026 14:39:23 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 276C3289;\n\tThu, 9 Jul 2026 14:38:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HkONP6bI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783600713;\n\tbh=Bqhwqs7tlmiRpCnobltQT+5iSl2z2T6xHxyAwxW+sgw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=HkONP6bIO6fTw7SkkG5CxWfSLQ/VLvxXuN2Yi60eS3/K9jLvoOYQDlDusK92RmFef\n\tve+X9pHH49GkY850R/Y03o48jHUcnxfE4+AZADRXwONS4I2aSsN0zrUh3kfckPQ1/T\n\tiTNNQw6WTNrxPZDa0WF4ttLwG1cX8B1+g/RmtTWE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260506230722.1041596-2-devve.3@gmail.com>","References":"<20260506230722.1041596-1-devve.3@gmail.com>\n\t<20260506230722.1041596-2-devve.3@gmail.com>","Subject":"Re: [PATCH v2 01/10] ipa: libipa: camera_sensor_helper: Add OV01A10","From":"Kieran Bingham ","To":"d3vv3 , libcamera-devel@lists.libcamera.org","Date":"Thu, 09 Jul 2026 13:39:20 +0100","Message-ID":"<178360076077.1021520.12661562145617401065@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]