{"id":26653,"url":"https://patchwork.libcamera.org/api/patches/26653/?format=json","web_url":"https://patchwork.libcamera.org/patch/26653/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260506230649.1040794-3-devve.3@gmail.com>","date":"2026-05-06T23:06:41","name":"[v2,02/10] ipa: simple: awb: Add temporal smoothing and per-channel gain limits","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"64ac7184e713ef556b1bc74a9066bbab4453895d","submitter":{"id":271,"url":"https://patchwork.libcamera.org/api/people/271/?format=json","name":"devve","email":"devve.3@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26653/mbox/","series":[{"id":5914,"url":"https://patchwork.libcamera.org/api/series/5914/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5914","date":"2026-05-06T23:06:39","name":"OV01A10 sensor support and simple IPA improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5914/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26653/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26653/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10D0AC32F7\n\tfor ;\n\tWed, 6 May 2026 23:06:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 546AB6302D;\n\tThu, 7 May 2026 01:06:57 +0200 (CEST)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 090A36301E\n\tfor ;\n\tThu, 7 May 2026 01:06:51 +0200 (CEST)","by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-48d102471a4so1771885e9.2\n\tfor ;\n\tWed, 06 May 2026 16:06:51 -0700 (PDT)","from dexps.speedport.ip\n\t(p200300eda74453cf3cf3f7929e513b94.dip0.t-ipconnect.de.\n\t[2003:ed:a744:53cf:3cf3:f792:9e51:3b94])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-48e538a547bsm85951935e9.5.2026.05.06.16.06.50\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 May 2026 16:06:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CsnUkxWx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20251104; t=1778108811; x=1778713611;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=vpT2omGvrrBC/UWz9mRqAkO01quAcHHbvl8N34ZIhJU=;\n\tb=CsnUkxWxTOKysjUu84w1+oJ5RWQRZambNaeSw7vogpsyoke0dzLYbwSOhX0yRQZy7Z\n\tCaiXeii6CiUbVivYjqua1M58ZDnIZnrpzrhiGL4ZglzlFv4HaRXu1rHGPyqinL/VqbKz\n\t6PAt93QvYfzizOb5YpgGTHNI4gtRtJBb0d+S1TfrQCyvR9nm6Z9JtvIR0DOfvEkS4MeU\n\t/bedNH3V34QnmyCRXErDah4YnzKQmGCbhvwY+UHj2hw0Zb3gUnLmqCu6xfq3czIE7+KP\n\tAzs6mP0YamkfuqnQamWoz45Yh7lkCOBbfyv7z+m5ufryxRtMGo6OfsMzXkOdEtPDPrnl\n\tggCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1778108811; x=1778713611;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=vpT2omGvrrBC/UWz9mRqAkO01quAcHHbvl8N34ZIhJU=;\n\tb=OF/Z2yP6rIZPFulxhRoMxNUxiimfATifqRlI9PS5vqp+ncNlBCX12iSAbEa15D1REf\n\twUNn7TE7g78hCgA/CZDvCOuO56F6zyEGFGrRHBKixUIpWUKM9OXympVrd8mHIpG7BFJM\n\t1oaZib+A0tKwDKDBl604Kfjy9mcP4VRlxD+vweb5T9n6hQWYR+Wo5q1ovXV0+74GF8Qz\n\t9EzRnG+7Hjky0mhOpm7K4M/3DIVoS1pAWFr0iVVDQHB1iwW9drBFoZEFPxKVATc9o8R6\n\tD8+7F8PyVZLgWwZlafrS28dS/SQhBY5vSfwzGSrT3hIF2uECJlXZrI7BvDVmL3uKphV9\n\tY0fQ==","X-Gm-Message-State":"AOJu0YzGwr0PYawcyY6Mh9arFL1OP8vc/15Thhb8izARdX2oFP8x3xoP\n\tu9l42wLCFgGFKJgMFryBi3D8ryh+r2axroY/Ry+xJDZPRNykeS+BwJvWqRo1LQ==","X-Gm-Gg":"AeBDieuKqVn5UTgPNyAw0W8HYITSZsad0elYRmfgIiw1HTFrE00aDq7AfKqHdhDTrRR\n\tgfpWlsZeiQpbtjBS4A08uT17FMA68UxUBQ1qqAGore4+9wClT0NaO4ZxPNa8ZD091mfMlSnHvKG\n\tdp2Djr32okxU4L6V8iMnsgZhgGsZLL3MYE7wy4GqpasO2vQgy7jPKQbE0HotDsVAkROdfx0LmRW\n\tj4apAM2I9zSV4+6DcdANSv58QJi2M6yVUUTajqfC5uAzbBk3KAbpyQQoENzkjEcF8/iYuJPSq7I\n\tWXEHbod3RmjywqXLuW7+XMoE6M6soxXUqYN7xJVf5Zka3tRwZgqq37hZsyKOpjAHc2aAwMTYssf\n\thuenGcc7uGaXzY6fEc6OQmf8OxXP2S9Vm51no3Pa5MIlHZbZumWSwRVrxyWaueQEyPZQ8SD/m/R\n\tJsWo8zahfE78O/WkYFc/JpikNo+AyrMPvdpTKVquAougna3z/dr+ibKS9wQZb+mAwj1CsOqU0o3\n\tHjL7tDsS/zRNErkSRy9YWboGbB6Ie2x","X-Received":"by 2002:a05:600c:c094:b0:48a:592c:e63d with SMTP id\n\t5b1f17b1804b1-48e51f3fab1mr64868415e9.14.1778108810930; \n\tWed, 06 May 2026 16:06:50 -0700 (PDT)","From":"d3vv3 ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 02/10] ipa: simple: awb: Add temporal smoothing and\n\tper-channel gain limits","Date":"Thu, 7 May 2026 01:06:41 +0200","Message-ID":"<20260506230649.1040794-3-devve.3@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260506230649.1040794-1-devve.3@gmail.com>","References":"<20260506230649.1040794-1-devve.3@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add configurable YAML parameters maxGainR, maxGainB, and speed to AWB.\nReplace the single hardcoded max gain (4.0x) with per-channel limits,\nand apply exponential moving average smoothing to reduce colour\ntemperature oscillation between frames.\n\nSigned-off-by: d3vv3 \n---\n src/ipa/simple/algorithms/awb.cpp | 34 ++++++++++++++++++++++++++-----\n src/ipa/simple/algorithms/awb.h | 6 ++++++\n 2 files changed, 35 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex f5c88ea6..937aabc8 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -14,6 +14,8 @@\n \n #include \n \n+#include \"libcamera/internal/yaml_parser.h\"\n+\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n@@ -23,6 +25,21 @@ LOG_DEFINE_CATEGORY(IPASoftAwb)\n \n namespace ipa::soft::algorithms {\n \n+int Awb::init([[maybe_unused]] IPAContext &context,\n+\t const ValueNode &tuningData)\n+{\n+\tmaxGainR_ = tuningData[\"maxGainR\"].get().value_or(4.0f);\n+\tmaxGainB_ = tuningData[\"maxGainB\"].get().value_or(4.0f);\n+\tspeed_ = tuningData[\"speed\"].get().value_or(1.0f);\n+\n+\tLOG(IPASoftAwb, Debug)\n+\t\t<< \"AWB: maxGainR \" << maxGainR_\n+\t\t<< \", maxGainB \" << maxGainB_\n+\t\t<< \", speed \" << speed_;\n+\n+\treturn 0;\n+}\n+\n int Awb::configure(IPAContext &context,\n \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n {\n@@ -84,14 +101,21 @@ void Awb::process(IPAContext &context,\n \tconst RGB sum = stats->sum_.max(offset + minValid) - offset;\n \n \t/*\n-\t * Calculate red and blue gains for AWB.\n-\t * Clamp max gain at 4.0, this also avoids 0 division.\n+\t * Calculate red and blue gains for AWB. Clamp max gain to avoid\n+\t * division by zero and extreme color casts.\n \t */\n \tauto &gains = context.activeState.awb.gains;\n+\tfloat rawRGain = sum.r() <= sum.g() / maxGainR_ ? maxGainR_ :\n+\t\t\t\tstatic_cast(sum.g()) / sum.r();\n+\tfloat rawBGain = sum.b() <= sum.g() / maxGainB_ ? maxGainB_ :\n+\t\t\t\tstatic_cast(sum.g()) / sum.b();\n+\n+\t/* Apply temporal smoothing to avoid rapid white balance changes. */\n+\tfloat alpha = std::clamp(speed_, 0.01f, 1.0f);\n \tgains = { {\n-\t\tsum.r() <= sum.g() / 4 ? 4.0f : static_cast(sum.g()) / sum.r(),\n-\t\t1.0,\n-\t\tsum.b() <= sum.g() / 4 ? 4.0f : static_cast(sum.g()) / sum.b(),\n+\t\tgains.r() * (1.0f - alpha) + rawRGain * alpha,\n+\t\t1.0f,\n+\t\tgains.b() * (1.0f - alpha) + rawBGain * alpha,\n \t} };\n \n \tRGB rgbGains{ { 1 / gains.r(), 1 / gains.g(), 1 / gains.b() } };\ndiff --git a/src/ipa/simple/algorithms/awb.h b/src/ipa/simple/algorithms/awb.h\nindex ad993f39..0aedc1d1 100644\n--- a/src/ipa/simple/algorithms/awb.h\n+++ b/src/ipa/simple/algorithms/awb.h\n@@ -19,6 +19,7 @@ public:\n \tAwb() = default;\n \t~Awb() = default;\n \n+\tint init(IPAContext &context, const ValueNode &tuningData) override;\n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n \tvoid prepare(IPAContext &context,\n \t\t const uint32_t frame,\n@@ -29,6 +30,11 @@ public:\n \t\t IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n \t\t ControlList &metadata) override;\n+\n+private:\n+\tfloat maxGainR_;\n+\tfloat maxGainB_;\n+\tfloat speed_;\n };\n \n } /* namespace ipa::soft::algorithms */\n","prefixes":["v2","02/10"]}