[{"id":38729,"web_url":"https://patchwork.libcamera.org/comment/38729/","msgid":"<20260505164334.GG1547435@killaraus.ideasonboard.com>","date":"2026-05-05T16:43:34","subject":"Re: [PATCH 3/3] ipa: libipa: v4l2_params: Fix code example in doc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, May 05, 2026 at 06:11:11PM +0200, Jacopo Mondi wrote:\n> Fix the code example in documentation to actually use the myISPBlocks\n> type define a few lines above instead of the mis-spelled myISPBlock\n\nThe most common form is s/mis-spelled/misspelled/\n\n> type.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/v4l2_params.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/v4l2_params.cpp b/src/ipa/libipa/v4l2_params.cpp\n> index a1eeeb1b0e6a..b756bfee4de2 100644\n> --- a/src/ipa/libipa/v4l2_params.cpp\n> +++ b/src/ipa/libipa/v4l2_params.cpp\n> @@ -146,13 +146,13 @@ namespace ipa {\n> * };\n> *\n> * template<>\n> - * struct block_type {\n> + * struct block_type {\n> *\tusing type = struct my_isp_kernel_config_type_agc;\n> *\tstatic constexpr kernel_enum_type blockType = MY_ISP_TYPE_AGC;\n> * };\n> *\n> * template<>\n> - * struct block_type {\n> + * struct block_type {\n> *\tusing type = struct my_isp_kernel_config_type_awb;\n> *\tstatic constexpr kernel_enum_type blockType = MY_ISP_TYPE_AWB;\n> * };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B247BE173\n\tfor ;\n\tTue, 5 May 2026 16:43:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 344F76301E;\n\tTue, 5 May 2026 18:43:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 029D062DC4\n\tfor ;\n\tTue, 5 May 2026 18:43:35 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 119B21F8;\n\tTue, 5 May 2026 18:43:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KUo0z91N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777999413;\n\tbh=N4P5fjRoJNRdwspo0Qr8CrMYOGd6z3apPmtWRtT+EMU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KUo0z91NNhLAcsFZEQsyX6LfoVJpOdg1++9fX7ANXp1jrn2qOz6drIu/hrFZKGQP6\n\tTqo6Mjn7mXhErwZ7L3tQiR6wsIC7TItwGc3DGKhJEdN40rpmZ1WPornQra8cpX8pQd\n\t4f8vAdN29qinHO4l6xByNVrN+N15JelSUD6Ka2ho=","Date":"Tue, 5 May 2026 19:43:34 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org,\n\tAntoine Bouyer ","Subject":"Re: [PATCH 3/3] ipa: libipa: v4l2_params: Fix code example in doc","Message-ID":"<20260505164334.GG1547435@killaraus.ideasonboard.com>","References":"<20260505-extensible-stats-v1-0-0b56c7b1bbd6@ideasonboard.com>\n\t<20260505-extensible-stats-v1-3-0b56c7b1bbd6@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260505-extensible-stats-v1-3-0b56c7b1bbd6@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38735,"web_url":"https://patchwork.libcamera.org/comment/38735/","msgid":"","date":"2026-05-06T07:48:42","subject":"Re: [PATCH 3/3] ipa: libipa: v4l2_params: Fix code example in doc","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 05. 18:11 keltezéssel, Jacopo Mondi írta:\n> Fix the code example in documentation to actually use the myISPBlocks\n> type define a few lines above instead of the mis-spelled myISPBlock\n> type.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/libipa/v4l2_params.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/v4l2_params.cpp b/src/ipa/libipa/v4l2_params.cpp\n> index a1eeeb1b0e6a..b756bfee4de2 100644\n> --- a/src/ipa/libipa/v4l2_params.cpp\n> +++ b/src/ipa/libipa/v4l2_params.cpp\n> @@ -146,13 +146,13 @@ namespace ipa {\n> * };\n> *\n> * template<>\n> - * struct block_type {\n> + * struct block_type {\n> *\tusing type = struct my_isp_kernel_config_type_agc;\n> *\tstatic constexpr kernel_enum_type blockType = MY_ISP_TYPE_AGC;\n> * };\n> *\n> * template<>\n> - * struct block_type {\n> + * struct block_type {\n> *\tusing type = struct my_isp_kernel_config_type_awb;\n> *\tstatic constexpr kernel_enum_type blockType = MY_ISP_TYPE_AWB;\n> * };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 953A3BE173\n\tfor ;\n\tWed, 6 May 2026 07:48:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95E9A62FE8;\n\tWed, 6 May 2026 09:48:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F60762FE1\n\tfor ;\n\tWed, 6 May 2026 09:48:49 +0200 (CEST)","from [192.168.33.81] (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17E8F78E;\n\tWed, 6 May 2026 09:48:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IygPufBq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778053726;\n\tbh=5Hq/kqaopitErgpUNcse7eUoLcnJdNLL/c1aZJ+c5kw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IygPufBq9VNHVXBCtt+vU1d2WLTsx68+6bIbCUxoGfvEQpx+a6BV2M5PA4me04i/8\n\tx1xr8XncCW5PIk4gV8+RPDKo0Rw3XClAVZvCN6PnkaRnyuOgs1aGmRmcHZLpTChnzL\n\tlJcBwm2zdnEVqbX5POM6W1BarYilcMaEgoQrwnQI=","Message-ID":"","Date":"Wed, 6 May 2026 09:48:42 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/3] ipa: libipa: v4l2_params: Fix code example in doc","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tAntoine Bouyer ","References":"<20260505-extensible-stats-v1-0-0b56c7b1bbd6@ideasonboard.com>\n\t<20260505-extensible-stats-v1-3-0b56c7b1bbd6@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260505-extensible-stats-v1-3-0b56c7b1bbd6@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]