{"id":26633,"url":"https://patchwork.libcamera.org/api/patches/26633/?format=json","web_url":"https://patchwork.libcamera.org/patch/26633/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260505083332.610829-1-barnabas.pocze@ideasonboard.com>","date":"2026-05-05T08:33:32","name":"[v1] libcamera: framebuffer: Fix cookie arg type","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"183278c9f39beae4393504b02db6b843ef443007","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26633/mbox/","series":[{"id":5907,"url":"https://patchwork.libcamera.org/api/series/5907/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5907","date":"2026-05-05T08:33:32","name":"[v1] libcamera: framebuffer: Fix cookie arg type","version":1,"mbox":"https://patchwork.libcamera.org/series/5907/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26633/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26633/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89D70BE173\n\tfor ;\n\tTue, 5 May 2026 08:33:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CE556301E;\n\tTue, 5 May 2026 10:33:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E54962010\n\tfor ;\n\tTue, 5 May 2026 10:33:36 +0200 (CEST)","from pb-laptop.local (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7EDBC71\n\tfor ;\n\tTue, 5 May 2026 10:33:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XBOLDx9m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777970013;\n\tbh=uQhTVrcP8idRFUYDW3HCNzNDmuJCAZ0SAKSDbkaum5s=;\n\th=From:To:Subject:Date:From;\n\tb=XBOLDx9mBZAB9FEd9WCc4gqka3wiYIffjOyIFWW7swEGPJ6EqsEWG5Ha3L3zIZeo5\n\tZfh0bH67GcfobBTF6T3BfZcr2dMu6xTYfjReNGlDEy9PGdUXft7O8nVtOm1HCM3iGe\n\t5Q7iztQJ5u96JGEGSGEKXZUXgs3C++fFsUIH+CmU=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: framebuffer: Fix cookie arg type","Date":"Tue, 5 May 2026 10:33:32 +0200","Message-ID":"<20260505083332.610829-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The cookie has type `uint64_t`, but the constructor argument is of type\n`unsigned int`. Fix that.\n\nUnfortunately this is a public API and ABI change.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/framebuffer.h | 2 +-\n src/libcamera/framebuffer.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 723525d05..c633d22a6 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -58,7 +58,7 @@ public:\n \t\tunsigned int length;\n \t};\n \n-\tFrameBuffer(Span planes, unsigned int cookie = 0);\n+\tFrameBuffer(Span planes, uint64_t cookie = 0);\n \tFrameBuffer(std::unique_ptr d);\n \tvirtual ~FrameBuffer() {}\n \ndiff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\nindex 765dab95a..d61319030 100644\n--- a/src/libcamera/framebuffer.cpp\n+++ b/src/libcamera/framebuffer.cpp\n@@ -315,7 +315,7 @@ ino_t fileDescriptorInode(const SharedFD &fd)\n * \\param[in] planes The frame memory planes\n * \\param[in] cookie Cookie\n */\n-FrameBuffer::FrameBuffer(Span planes, unsigned int cookie)\n+FrameBuffer::FrameBuffer(Span planes, uint64_t cookie)\n \t: FrameBuffer(std::make_unique(planes, cookie))\n {\n }\n","prefixes":["v1"]}