{"id":26616,"url":"https://patchwork.libcamera.org/api/patches/26616/?format=json","web_url":"https://patchwork.libcamera.org/patch/26616/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504182658.590233-2-mzamazal@redhat.com>","date":"2026-05-04T18:26:50","name":"[RFC,v4,1/7] libcamera: software_isp: egl: Add filter parameter to createTexture2D()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e16228efb49e97f040a7e3ec1c083809c11be0fc","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26616/mbox/","series":[{"id":5903,"url":"https://patchwork.libcamera.org/api/series/5903/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5903","date":"2026-05-04T18:26:49","name":"LSC for SoftISP simple pipeline","version":4,"mbox":"https://patchwork.libcamera.org/series/5903/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26616/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26616/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FF1FBE173\n\tfor ;\n\tMon, 4 May 2026 18:27:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3454063021;\n\tMon, 4 May 2026 20:27:18 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6160F62FE8\n\tfor ;\n\tMon, 4 May 2026 20:27:17 +0200 (CEST)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-417-rxuJkIkpPcypTw8fINNPKw-1;\n\tMon, 04 May 2026 14:27:13 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id DC7AB180049F; Mon, 4 May 2026 18:27:10 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.69])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 4ACE91800480; Mon, 4 May 2026 18:27:07 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Y1CrBbI9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777919236;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ZYUcLBxDJJZFaM+eJIF2fazWu3f+U030/Fs+/huHGlc=;\n\tb=Y1CrBbI9KnML0DRDA2SKRe3eZZ1aNnKmDVfcm85bIs5mwowpUSkwb9gBxDEy/VQJWV5V0L\n\t9703ROC7aKOUUl7DOVZSZJ3Oaqb9HE7BPR/Q/Nb+djSfuKBZFdZiK25uQpEFoqqpHS0sKg\n\taDZ0SkmbiyPyGJ+at9DDnagphzkQo+g=","X-MC-Unique":"rxuJkIkpPcypTw8fINNPKw-1","X-Mimecast-MFC-AGG-ID":"rxuJkIkpPcypTw8fINNPKw_1777919231","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Xander Pronk ,\n\tBryan O'Donoghue ,\n\tHans de Goede ,\n\tLaurent Pinchart ,\n\tBryan O'Donoghue ,\n\tRick ten Wolde ,\n\tMilan Zamazal ","Subject":"[RFC PATCH v4 1/7] libcamera: software_isp: egl: Add filter\n\tparameter to createTexture2D()","Date":"Mon, 4 May 2026 20:26:50 +0200","Message-ID":"<20260504182658.590233-2-mzamazal@redhat.com>","In-Reply-To":"<20260504182658.590233-1-mzamazal@redhat.com>","References":"<20260504182658.590233-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"By_vW-jbAio2lG3Yvv306ZkJPbXA8BuWEVwB6n4A9Wg_1777919231","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Xander Pronk \n\nAdd `filter' parameter to createTexture2D() to allow overriding\nthe currently hardcoded GL_NEAREST value. This is needed for\ngrid-based lens shading interpolation, which is implemented in followup\npatches.\n\nReviewed-by: Bryan O'Donoghue \nCo-developed-by: Rick ten Wolde \nSigned-off-by: Rick ten Wolde \nSigned-off-by: Xander Pronk \nSigned-off-by: Milan Zamazal \n---\n include/libcamera/internal/egl.h | 3 ++-\n src/libcamera/egl.cpp | 10 ++++++----\n src/libcamera/software_isp/debayer_egl.cpp | 4 +++-\n 3 files changed, 11 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 0ad2320b1..6402dd5c7 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -103,7 +103,8 @@ public:\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n-\tvoid createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data);\n+\tvoid createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height,\n+\t\t\t const void *data, GLint filter);\n \n \tvoid pushEnv(std::vector &shaderEnv, const char *str);\n \tvoid makeCurrent();\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex f65929470..93778acb8 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -212,13 +212,15 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n * \\param[in] width Texture width in pixels\n * \\param[in] height Texture height in pixels\n * \\param[in] data Pointer to pixel data, or nullptr for uninitialised texture\n+ * \\param[in] filter GL texture filter setting\n *\n * Creates a 2D texture from a CPU-accessible memory buffer. The texture\n- * is configured with nearest filtering and clamp-to-edge wrapping. This\n+ * is configured the specified filtering and clamp-to-edge wrapping. This\n * is useful for uploading static data like lookup tables or uniform color\n * matrices to the GPU.\n */\n-void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data)\n+void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height,\n+\t\t\t const void *data, GLint filter)\n {\n \tASSERT(tid_ == Thread::currentId());\n \n@@ -229,8 +231,8 @@ void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint\n \tglTexImage2D(GL_TEXTURE_2D, 0, format, width, height, 0, format, GL_UNSIGNED_BYTE, data);\n \n \t// Nearest filtering\n-\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);\n-\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);\n+\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, filter);\n+\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, filter);\n \n \t// Wrap to edge to avoid edge artifacts\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 8f0c229fd..f10f372c6 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -501,7 +501,9 @@ int DebayerEGL::debayerGPU(MappedFrameBuffer &in, int out_fd, const DebayerParam\n \tegl_.makeCurrent();\n \n \t/* Create a standard texture input */\n-\tegl_.createTexture2D(*eglImageBayerIn_, glFormat_, inputConfig_.stride / bytesPerPixel_, height_, in.planes()[0].data());\n+\tegl_.createTexture2D(*eglImageBayerIn_, glFormat_,\n+\t\t\t inputConfig_.stride / bytesPerPixel_, height_,\n+\t\t\t in.planes()[0].data(), GL_NEAREST);\n \n \t/* Generate the output render framebuffer as render to texture */\n \tegl_.createOutputDMABufTexture2D(*eglImageBayerOut_, out_fd);\n","prefixes":["RFC","v4","1/7"]}