[{"id":3482,"web_url":"https://patchwork.libcamera.org/comment/3482/","msgid":"<20200117211126.GE1074550@oden.dyn.berto.se>","date":"2020-01-17T21:11:26","subject":"Re: [libcamera-devel] [PATCH v2 1/6] checkstyle: Move from pep8 to\n\tpycodestyle","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Nicolas,\n\nThanks for your patch.\n\nOn 2020-01-17 14:17:28 -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> The tool has been renamed in 2016 to make it more obvious what it\n> is doing. There is no other changes needed on our side.\n> \n> See https://github.com/PyCQA/pycodestyle/issues/466\n> \n> Signed-off-by: Nicolas Dufresne \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> utils/checkstyle.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 93f0291..7edea25 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):\n> data = ''.join(self.__content).encode('utf-8')\n> \n> try:\n> - ret = subprocess.run(['pep8', '--ignore=E501', '-'],\n> + ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],\n> input=data, stdout=subprocess.PIPE)\n> except FileNotFoundError:\n> - issues.append(StyleIssue(0, None, \"Please install pep8 to validate python additions\"))\n> + issues.append(StyleIssue(0, None, \"Please install pycodestyle to validate python additions\"))\n> return issues\n> \n> results = ret.stdout.decode('utf-8').splitlines()\n> -- \n> 2.24.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BCDC60782\n\tfor ;\n\tFri, 17 Jan 2020 22:11:29 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id y4so27850281ljj.9\n\tfor ;\n\tFri, 17 Jan 2020 13:11:29 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tl1sm12552257lfj.71.2020.01.17.13.11.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jan 2020 13:11:28 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=X7ZOGX+SBbKDeixWpt/gfZRlaFV0gAVr1cY/2sdM0ME=;\n\tb=x6n4E4SY3YLHsDO3J4eI/+TNBxfhz86jJ4L7MWSMeYP7twi+pXAdyKEQwgdg1Xtsne\n\tRp9uqXfKpfRSY+dE3v826YDrWMOCJpM2AYUdUgoSShfl50I0iZJz+pgyr2cf3kBe8BXs\n\tSpFrcgCjWsK5hBWkmutQNsSEjx3xZtGLhSpLX3ocLb0pQon+hwxQLW5ilPEGJyW30oyQ\n\tVXtXAexk/WPgIhUZysyloNPeRblXq0uf5Xca5ZPyN/lNvexW3CM4uXaU0L1BqhVrZy4u\n\tuP9c/cHAvRKuory6q2WMd/l4j1WuskTUkUSE9Fo0qeQrmmi9VfuvgsVoLW/IiEBCJFEx\n\tvtWw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=X7ZOGX+SBbKDeixWpt/gfZRlaFV0gAVr1cY/2sdM0ME=;\n\tb=QYw/K5eYjt+LLfCdpbPzFnlwwbbMRINjpFmpGcQcVBUJGG0fN91sb5UZkUjryu2j5g\n\tz1hXp6I7d99orvmP2pImp6gAH0F6tj48/HhQbNn7K3JD8Fg7YNGealAemOGSmyMMfp6F\n\tQOSTElc2ML8S8PIqnq41H3Wd9k0/4gaaA2Bveh/oHFIhjpiB2NKRGDyq6trFzUsMAUOc\n\ty0u6tC9zUbRuxKAagwz9QYeA8wAUO0JmG7+0rdQCuym2897H+u45h75ojV1G3rJJlXxl\n\tMxcvpeMkt40fFFxjp95QD8Cnq5jU+hw9gOdOc7ymf7ZvFNWk3IOBYwFEhiQaTLJ8LCDF\n\tYTJA==","X-Gm-Message-State":"APjAAAV6W+dNZYjX8DCzx+O1cKu6pNwctwlcL6ActIIXlfC2J3bO9eg5\n\tnq09mY/MCKXVZMRDN5RNTC8qMg==","X-Google-Smtp-Source":"APXvYqzR0NR3Ni0QhsAk5O0F+Sqi4Wv1devd08EzMtPFD+Tnck88WY88rGjkcy2cAAsv/p+W6E/YFQ==","X-Received":"by 2002:a2e:b0f5:: with SMTP id h21mr7038516ljl.9.1579295488846; \n\tFri, 17 Jan 2020 13:11:28 -0800 (PST)","Date":"Fri, 17 Jan 2020 22:11:26 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Message-ID":"<20200117211126.GE1074550@oden.dyn.berto.se>","References":"<20200117191733.198897-1-nicolas@ndufresne.ca>\n\t<20200117191733.198897-2-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200117191733.198897-2-nicolas@ndufresne.ca>","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] checkstyle: Move from pep8 to\n\tpycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Jan 2020 21:11:29 -0000"}}]