{"id":2661,"url":"https://patchwork.libcamera.org/api/patches/2661/?format=json","web_url":"https://patchwork.libcamera.org/patch/2661/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200117191733.198897-2-nicolas@ndufresne.ca>","date":"2020-01-17T19:17:28","name":"[libcamera-devel,v2,1/6] checkstyle: Move from pep8 to pycodestyle","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f3bb50d3e1a47b913d00e2f1ea817f669ed09849","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2661/mbox/","series":[{"id":634,"url":"https://patchwork.libcamera.org/api/series/634/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=634","date":"2020-01-17T19:17:27","name":"Add the ability to do pre-commit style check","version":2,"mbox":"https://patchwork.libcamera.org/series/634/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2661/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2661/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D42660787\n\tfor ;\n\tFri, 17 Jan 2020 20:17:53 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::127])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 7E4782949D4;\n\tFri, 17 Jan 2020 19:17:52 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ,\n\tKieran Bingham ","Date":"Fri, 17 Jan 2020 14:17:28 -0500","Message-Id":"<20200117191733.198897-2-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200117191733.198897-1-nicolas@ndufresne.ca>","References":"<20200117191733.198897-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/6] checkstyle: Move from pep8 to\n\tpycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Jan 2020 19:17:53 -0000"},"content":"From: Nicolas Dufresne \n\nThe tool has been renamed in 2016 to make it more obvious what it\nis doing. There is no other changes needed on our side.\n\nSee https://github.com/PyCQA/pycodestyle/issues/466\n\nSigned-off-by: Nicolas Dufresne \nReviewed-by: Kieran Bingham \n---\n utils/checkstyle.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 93f0291..7edea25 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):\n data = ''.join(self.__content).encode('utf-8')\n \n try:\n- ret = subprocess.run(['pep8', '--ignore=E501', '-'],\n+ ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],\n input=data, stdout=subprocess.PIPE)\n except FileNotFoundError:\n- issues.append(StyleIssue(0, None, \"Please install pep8 to validate python additions\"))\n+ issues.append(StyleIssue(0, None, \"Please install pycodestyle to validate python additions\"))\n return issues\n \n results = ret.stdout.decode('utf-8').splitlines()\n","prefixes":["libcamera-devel","v2","1/6"]}