[{"id":38696,"web_url":"https://patchwork.libcamera.org/comment/38696/","msgid":"<177788454385.45302.1873584780006590974@ping.linuxembedded.co.uk>","date":"2026-05-04T08:49:03","subject":"Re: [PATCH 6/6] libcamera: egl: Don't depend on libdrm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-05-04 01:04:31)\n> egl.cpp includes libdrm/drm_fourcc.h, creating an implicit dependency on\n> libdrm that is not declared in meson.build. This is a leftover from GBM\n> usage, which was dropped in commit 7350d6cc5dd1 and ensured that libdrm\n> was present.\n> \n> We could add an explicit dependency on libdrm, but this is not required\n> as drm_fourcc.h is also present in the Linux kernel headers. Replace\n> libdrm/drm_fourcc.h with linux/drm_fourcc.h.\n> \n\nReviewed-by: Kieran Bingham \n\n> Fixes: 7350d6cc5dd1 (\"Revert \"libcamera: software_isp: gbm: Add a GBM helper class for GPU surface access\"\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/egl.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index f659294709f2..357918711e83 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -16,11 +16,10 @@\n> \n> #include \n> #include \n> +#include \n> \n> #include \n> \n> -#include \n> -\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(eGL)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C3C9BE173\n\tfor ;\n\tMon, 4 May 2026 08:49:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05CFB62FEC;\n\tMon, 4 May 2026 10:49:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BFB362DC4\n\tfor ;\n\tMon, 4 May 2026 10:49:06 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5552175;\n\tMon, 4 May 2026 10:49:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EqYdaHXi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777884544;\n\tbh=VHwSTAD3zd4M+tP8UnquBB6w0T5S4RFlNZEeMoy5r1o=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=EqYdaHXinlrxWTqv0jO58NkAV4MTrtKre6iTBeuEG8TkBA3TtXqCf3ZyKuJR5Z+yZ\n\t3+bPKlVmUmLmF1eXVz0YtzJxvUPCosh5m1hHKOzI8pc2m+8jP3jtFO8Z4gVtiy4/oq\n\tDSmmY5dPZyf9YqaK6FqcXW6CI9LmLXMMH8VJrRZQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260504000431.1340150-7-laurent.pinchart@ideasonboard.com>","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 6/6] libcamera: egl: Don't depend on libdrm","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 04 May 2026 09:49:03 +0100","Message-ID":"<177788454385.45302.1873584780006590974@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38705,"web_url":"https://patchwork.libcamera.org/comment/38705/","msgid":"<69425744-c217-43ff-a9e6-5abae3a503fb@ideasonboard.com>","date":"2026-05-04T09:12:51","subject":"Re: [PATCH 6/6] libcamera: egl: Don't depend on libdrm","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 04. 2:04 keltezéssel, Laurent Pinchart írta:\n> egl.cpp includes libdrm/drm_fourcc.h, creating an implicit dependency on\n> libdrm that is not declared in meson.build. This is a leftover from GBM\n> usage, which was dropped in commit 7350d6cc5dd1 and ensured that libdrm\n> was present.\n> \n> We could add an explicit dependency on libdrm, but this is not required\n> as drm_fourcc.h is also present in the Linux kernel headers. Replace\n> libdrm/drm_fourcc.h with linux/drm_fourcc.h.\n> \n> Fixes: 7350d6cc5dd1 (\"Revert \"libcamera: software_isp: gbm: Add a GBM helper class for GPU surface access\"\")\n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/egl.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index f659294709f2..357918711e83 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -16,11 +16,10 @@\n> \n> #include \n> #include \n> +#include \n> \n> #include \n> \n> -#include \n> -\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(eGL)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D9D3BE173\n\tfor ;\n\tMon, 4 May 2026 09:12:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E18E663029;\n\tMon, 4 May 2026 11:12:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D2D363024\n\tfor ;\n\tMon, 4 May 2026 11:12:54 +0200 (CEST)","from [192.168.33.78] (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF0589C;\n\tMon, 4 May 2026 11:12:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b1EiZ4lG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777885973;\n\tbh=XeWIDT2Izu8WXGqDgiFlezX9nKG63TXDU8P3tr36q3o=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=b1EiZ4lGtKtH7Qd6hVnDr/a2bodesOD7637MI+6aoE4+oiFJPVKrhR1m4onNs4Icv\n\tMUru2vdhZbCNtIxc5OXEHR1lIEFBRvAW9AkHT9nIyDAomispFpdZSwjMhMT7RnFwSg\n\ttGBSRnBrHzxoRG0C8G1jWrAnciADyIuzMXTDmzC0=","Message-ID":"<69425744-c217-43ff-a9e6-5abae3a503fb@ideasonboard.com>","Date":"Mon, 4 May 2026 11:12:51 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 6/6] libcamera: egl: Don't depend on libdrm","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-7-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260504000431.1340150-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]