{"id":26609,"url":"https://patchwork.libcamera.org/api/patches/26609/?format=json","web_url":"https://patchwork.libcamera.org/patch/26609/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504000431.1340150-7-laurent.pinchart@ideasonboard.com>","date":"2026-05-04T00:04:31","name":"[6/6] libcamera: egl: Don't depend on libdrm","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1e940a0717e4a53beb1f4f4bb1e9dbf8d4424250","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26609/mbox/","series":[{"id":5900,"url":"https://patchwork.libcamera.org/api/series/5900/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5900","date":"2026-05-04T00:04:25","name":"libcamera: kernel headers update","version":1,"mbox":"https://patchwork.libcamera.org/series/5900/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26609/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26609/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCACDBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  4 May 2026 00:04:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70DBF6302B;\n\tMon,  4 May 2026 02:04:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EAAC62E6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  4 May 2026 02:04:41 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 042819C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  4 May 2026 02:04:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iGWo9g3c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777853080;\n\tbh=aYRz9AUEzXycGeLA1DV3qAh6bKuNlOMxqd7bZZXwzHU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=iGWo9g3cgINtNVNdWyae/1wwVPoBTSdWL7x3BWUuG7LZCRcNGNJAjbKNzQeAwXSqO\n\tnAYmgv7mNXrpiZrEmnNXyEMNIgzefqWUe6eBDZEB/3k7FHawUHf+zbdgMAj/dcTeSv\n\t1irXgG7zd3SB5XwiTg3tr1U7IxJv8PWuGe/ExGBQ=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 6/6] libcamera: egl: Don't depend on libdrm","Date":"Mon,  4 May 2026 03:04:31 +0300","Message-ID":"<20260504000431.1340150-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"egl.cpp includes libdrm/drm_fourcc.h, creating an implicit dependency on\nlibdrm that is not declared in meson.build. This is a leftover from GBM\nusage, which was dropped in commit 7350d6cc5dd1 and ensured that libdrm\nwas present.\n\nWe could add an explicit dependency on libdrm, but this is not required\nas drm_fourcc.h is also present in the Linux kernel headers. Replace\nlibdrm/drm_fourcc.h with linux/drm_fourcc.h.\n\nFixes: 7350d6cc5dd1 (\"Revert \"libcamera: software_isp: gbm: Add a GBM helper class for GPU surface access\"\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/egl.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex f659294709f2..357918711e83 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -16,11 +16,10 @@\n \n #include <linux/dma-buf.h>\n #include <linux/dma-heap.h>\n+#include <linux/drm_fourcc.h>\n \n #include <libcamera/base/thread.h>\n \n-#include <libdrm/drm_fourcc.h>\n-\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(eGL)\n","prefixes":["6/6"]}