[{"id":38692,"web_url":"https://patchwork.libcamera.org/comment/38692/","msgid":"<177788425999.45302.16156679853915268774@ping.linuxembedded.co.uk>","date":"2026-05-04T08:44:19","subject":"Re: [PATCH 3/6] utils: update-kernel-headers: Add drm/drm.h and\n\tdrm/drm_mode.h","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-05-04 01:04:28)\n> The drm_fourcc.h header includes \"drm.h\", which in turn includes\n> \"drm_mode.h\". We carry a copy of the first header, but not of the last\n> two. The only reason this does not cause any issue is because the\n> drm_fourcc.h copy is not used.\n> \n> In preparation for including drm_fourcc.h in source files, import the\n> drm.h and drm_mode.h headers.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/update-kernel-headers.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index 93599dfe5d52..9f3a79ec6999 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -46,7 +46,9 @@ set +e\n> \n> # Copy the headers\n> headers=\"\n> + drm/drm.h\n> drm/drm_fourcc.h\n> + drm/drm_mode.h\n> linux/dma-buf.h\n> linux/dma-heap.h\n> linux/dw100.h\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB3AFBDCB5\n\tfor ;\n\tMon, 4 May 2026 08:44:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EBEB63021;\n\tMon, 4 May 2026 10:44:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D652062DC4\n\tfor ;\n\tMon, 4 May 2026 10:44:22 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CCC4175;\n\tMon, 4 May 2026 10:44:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oB+D4PJR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777884261;\n\tbh=PXRpio+rJ06OUMUSfIpbyFxmBJisIsLXTRu14QueW+g=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=oB+D4PJRqKKMkj6BXulAvYsA5KJtOjwGY2J9byXaS6vhqbbdZre6a/GUpxM40mlOC\n\trdl+zx279tpeZ9wP61OtdLRujON9q6EKs5kAlZwV4oavZL//Kw0e6FFAgT1fwFbQOX\n\tjplcfNrTaDgGZc2EApJZFQ26eC01p7OcMajYIbWM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260504000431.1340150-4-laurent.pinchart@ideasonboard.com>","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 3/6] utils: update-kernel-headers: Add drm/drm.h and\n\tdrm/drm_mode.h","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 04 May 2026 09:44:19 +0100","Message-ID":"<177788425999.45302.16156679853915268774@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38702,"web_url":"https://patchwork.libcamera.org/comment/38702/","msgid":"","date":"2026-05-04T09:12:18","subject":"Re: [PATCH 3/6] utils: update-kernel-headers: Add drm/drm.h and\n\tdrm/drm_mode.h","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 04. 2:04 keltezéssel, Laurent Pinchart írta:\n> The drm_fourcc.h header includes \"drm.h\", which in turn includes\n> \"drm_mode.h\". We carry a copy of the first header, but not of the last\n> two. The only reason this does not cause any issue is because the\n> drm_fourcc.h copy is not used.\n> \n> In preparation for including drm_fourcc.h in source files, import the\n> drm.h and drm_mode.h headers.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> utils/update-kernel-headers.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index 93599dfe5d52..9f3a79ec6999 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -46,7 +46,9 @@ set +e\n> \n> # Copy the headers\n> headers=\"\n> +\tdrm/drm.h\n> \tdrm/drm_fourcc.h\n> +\tdrm/drm_mode.h\n> \tlinux/dma-buf.h\n> \tlinux/dma-heap.h\n> \tlinux/dw100.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33B23BE173\n\tfor ;\n\tMon, 4 May 2026 09:12:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E059763022;\n\tMon, 4 May 2026 11:12:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F236D62DC4\n\tfor ;\n\tMon, 4 May 2026 11:12:21 +0200 (CEST)","from [192.168.33.78] (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 446F89C;\n\tMon, 4 May 2026 11:12:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KR17Mgjb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777885940;\n\tbh=mPsCHNtil9rJNU/8FiW/a5jZTPG8KN9b5OcU/CJRg8w=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KR17Mgjbx5DB4G/vXNRKz9Tm/94ucceaDr6uCq28SDi8hb+cOhRHfatqUa+SedFy/\n\tXBHa2/XrEj5LAfGkIBuV0fXtYBp92CBw0s1ymaP0AeSe/TZ01ryuJ3kJ3dR7fUvb3D\n\tUKm+GME1wrxZS97DO75nrLJcKAgJ6sKmRvUNtFic=","Message-ID":"","Date":"Mon, 4 May 2026 11:12:18 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/6] utils: update-kernel-headers: Add drm/drm.h and\n\tdrm/drm_mode.h","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-4-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260504000431.1340150-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]