[{"id":38691,"web_url":"https://patchwork.libcamera.org/comment/38691/","msgid":"<177788422648.45302.9633390630082799935@ping.linuxembedded.co.uk>","date":"2026-05-04T08:43:46","subject":"Re: [PATCH 2/6] utils: update-kernel-headers: Create destination\n\tdirectory","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-05-04 01:04:27)\n> Before copying headers, create the destination directory if it does not\n> exist.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/update-kernel-headers.sh | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index f9baa66d00b4..93599dfe5d52 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -65,7 +65,9 @@ headers=\"\n> \n> for header in $headers ; do\n> name=\"${header#*/}\"\n> - cp \"${install_dir}/usr/include/${header}\" \"${header_dir}/${name}\"\n> + dest=\"${header_dir}/${name}\"\n> + mkdir -p \"$(dirname \"$dest\")\"\n> + cp \"${install_dir}/usr/include/${header}\" \"${dest}\"\n\nReviewed-by: Kieran Bingham \n\n> done\n> \n> # The IPU3 header is a special case, as it's stored in staging. Handle it\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33CE5BDCB5\n\tfor ;\n\tMon, 4 May 2026 08:43:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D827B62DC4;\n\tMon, 4 May 2026 10:43:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE13C6271A\n\tfor ;\n\tMon, 4 May 2026 10:43:48 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 201E0175;\n\tMon, 4 May 2026 10:43:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ISy+1FvT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777884227;\n\tbh=4g38Ax+okNVJk56b3xWrCU+mxD2nSJfD+BT93SbfNpc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ISy+1FvTabJiPKnAPTk6vkCZDem18MEwABHkSoQ6PXXq66q+f4kOD9CaOEFWPbKZU\n\tkdTo4ffGA+QpyhaEFjBuYhEELf2X2eAJrpdMhvbCjGRZ7rCpuYyMEpZv0Q7JyshndP\n\tf1vW85UFLjr2q2oNmZ8RI0WdRP9n6sO2uebo27/o=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260504000431.1340150-3-laurent.pinchart@ideasonboard.com>","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 2/6] utils: update-kernel-headers: Create destination\n\tdirectory","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 04 May 2026 09:43:46 +0100","Message-ID":"<177788422648.45302.9633390630082799935@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38701,"web_url":"https://patchwork.libcamera.org/comment/38701/","msgid":"<22612e26-db9b-44ef-82f7-4f8d22946e2d@ideasonboard.com>","date":"2026-05-04T09:12:11","subject":"Re: [PATCH 2/6] utils: update-kernel-headers: Create destination\n\tdirectory","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 04. 2:04 keltezéssel, Laurent Pinchart írta:\n> Before copying headers, create the destination directory if it does not\n> exist.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> utils/update-kernel-headers.sh | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index f9baa66d00b4..93599dfe5d52 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -65,7 +65,9 @@ headers=\"\n> \n> for header in $headers ; do\n> \tname=\"${header#*/}\"\n> -\tcp \"${install_dir}/usr/include/${header}\" \"${header_dir}/${name}\"\n> +\tdest=\"${header_dir}/${name}\"\n> +\tmkdir -p \"$(dirname \"$dest\")\"\n> +\tcp \"${install_dir}/usr/include/${header}\" \"${dest}\"\n> done\n> \n> # The IPU3 header is a special case, as it's stored in staging. Handle it","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7C98C32F6\n\tfor ;\n\tMon, 4 May 2026 09:12:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5773C6302A;\n\tMon, 4 May 2026 11:12:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D65F6271A\n\tfor ;\n\tMon, 4 May 2026 11:12:12 +0200 (CEST)","from [192.168.33.78] (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A83063F;\n\tMon, 4 May 2026 11:12:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WtTl94go\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777885930;\n\tbh=IwVwfajLsWzStN6MnETOwSbXNm+oN0o11kzJ25K04rI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=WtTl94go2ZYvheXs/jborpJ1uNV8/1yZefVMzcpu0gsOQidYAhI1BCD/Jelmysceh\n\t/yn/MV36+t9panII1Ojag0y3MWJTMnphpsDEmEx3zE4tlHmbN/LeQ53bKPPlmd3ZjS\n\t2Q2qIghAGZ7EnL7H8jdEMgr76bQz5maM/zgXLttc=","Message-ID":"<22612e26-db9b-44ef-82f7-4f8d22946e2d@ideasonboard.com>","Date":"Mon, 4 May 2026 11:12:11 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/6] utils: update-kernel-headers: Create destination\n\tdirectory","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-3-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260504000431.1340150-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]