[{"id":38690,"web_url":"https://patchwork.libcamera.org/comment/38690/","msgid":"<177788418599.45302.16601238940122207812@ping.linuxembedded.co.uk>","date":"2026-05-04T08:43:05","subject":"Re: [PATCH 1/6] include: linux: Move mali-c55-config.h header to\n\tcorrect location","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-05-04 01:04:26)\n> The mali-c55-config.h header has been merged in the mainline kernel, and\n> is located in linux/media/arm/. Update the location of the local copy to\n> prepare for the next kernel headers update.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  include/linux/{ => media/arm}/mali-c55-config.h | 0\n>  src/ipa/mali-c55/algorithms/algorithm.h         | 2 +-\n>  src/ipa/mali-c55/mali-c55.cpp                   | 2 +-\n>  src/ipa/mali-c55/module.h                       | 2 +-\n>  src/ipa/mali-c55/params.h                       | 2 +-\n>  src/libcamera/pipeline/mali-c55/mali-c55.cpp    | 2 +-\n>  6 files changed, 5 insertions(+), 5 deletions(-)\n>  rename include/linux/{ => media/arm}/mali-c55-config.h (100%)\n> \n> diff --git a/include/linux/mali-c55-config.h b/include/linux/media/arm/mali-c55-config.h\n> similarity index 100%\n> rename from include/linux/mali-c55-config.h\n> rename to include/linux/media/arm/mali-c55-config.h\n> diff --git a/src/ipa/mali-c55/algorithms/algorithm.h b/src/ipa/mali-c55/algorithms/algorithm.h\n> index e61115f6c2d6..ffa22cb8d23f 100644\n> --- a/src/ipa/mali-c55/algorithms/algorithm.h\n> +++ b/src/ipa/mali-c55/algorithms/algorithm.h\n> @@ -7,7 +7,7 @@\n>  \n>  #pragma once\n>  \n> -#include <linux/mali-c55-config.h>\n> +#include <linux/media/arm/mali-c55-config.h>\n\nfind | grep mali-c55-config.h\n./include/uapi/linux/media/arm/mali-c55-config.h\n\nSo for that bit\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nBut I can't see any update in this patch to\nutils/update-kernel-headers.sh ... shouldn't that reflect the new\nlocation ?\n\nAha wait - it's because the file isn't there yet, and it gets added in\n4/6.\n\nNo issue then.\n\n--\nKieran","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F1E5BDCB5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  4 May 2026 08:43:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E97662DC4;\n\tMon,  4 May 2026 10:43:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65E136271A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  4 May 2026 10:43:09 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97437175;\n\tMon,  4 May 2026 10:43:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ijm/dD2p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777884187;\n\tbh=Lehvf07AiFy/PQ6Jc+PJkiPCtPQBjn8YeRTcmK7/RS4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Ijm/dD2pzoHG2FFiChe0A95e2/LlkfN7Bu8s8pbvRxdGIK+XfFVD7wsyTj02wtwyP\n\tIW39Xd50LdkaT4WHCG+yO9Bg88TRGklp/1QggsietI1RcyjBpZABZ+6GnBZhnGV9PV\n\tBK9ri0PXskqJVto9u0PG22w98q5uY/FLZqw3g3qQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260504000431.1340150-2-laurent.pinchart@ideasonboard.com>","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 1/6] include: linux: Move mali-c55-config.h header to\n\tcorrect location","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 04 May 2026 09:43:05 +0100","Message-ID":"<177788418599.45302.16601238940122207812@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38700,"web_url":"https://patchwork.libcamera.org/comment/38700/","msgid":"<705c4bf8-8da4-4cd5-9056-36ca85cb6e6c@ideasonboard.com>","date":"2026-05-04T09:12:04","subject":"Re: [PATCH 1/6] include: linux: Move mali-c55-config.h header to\n\tcorrect location","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 04. 2:04 keltezéssel, Laurent Pinchart írta:\n> The mali-c55-config.h header has been merged in the mainline kernel, and\n> is located in linux/media/arm/. Update the location of the local copy to\n> prepare for the next kernel headers update.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n\n>   include/linux/{ => media/arm}/mali-c55-config.h | 0\n>   src/ipa/mali-c55/algorithms/algorithm.h         | 2 +-\n>   src/ipa/mali-c55/mali-c55.cpp                   | 2 +-\n>   src/ipa/mali-c55/module.h                       | 2 +-\n>   src/ipa/mali-c55/params.h                       | 2 +-\n>   src/libcamera/pipeline/mali-c55/mali-c55.cpp    | 2 +-\n>   6 files changed, 5 insertions(+), 5 deletions(-)\n>   rename include/linux/{ => media/arm}/mali-c55-config.h (100%)\n> \n> diff --git a/include/linux/mali-c55-config.h b/include/linux/media/arm/mali-c55-config.h\n> similarity index 100%\n> rename from include/linux/mali-c55-config.h\n> rename to include/linux/media/arm/mali-c55-config.h\n> diff --git a/src/ipa/mali-c55/algorithms/algorithm.h b/src/ipa/mali-c55/algorithms/algorithm.h\n> index e61115f6c2d6..ffa22cb8d23f 100644\n> --- a/src/ipa/mali-c55/algorithms/algorithm.h\n> +++ b/src/ipa/mali-c55/algorithms/algorithm.h\n> @@ -7,7 +7,7 @@\n>   \n>   #pragma once\n>   \n> -#include <linux/mali-c55-config.h>\n> +#include <linux/media/arm/mali-c55-config.h>\n>   \n>   #include <libipa/algorithm.h>\n>   \n> diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp\n> index 3315d9a99488..1d3af0627fdb 100644\n> --- a/src/ipa/mali-c55/mali-c55.cpp\n> +++ b/src/ipa/mali-c55/mali-c55.cpp\n> @@ -10,7 +10,7 @@\n>   #include <string.h>\n>   #include <vector>\n>   \n> -#include <linux/mali-c55-config.h>\n> +#include <linux/media/arm/mali-c55-config.h>\n>   #include <linux/v4l2-controls.h>\n>   \n>   #include <libcamera/base/file.h>\n> diff --git a/src/ipa/mali-c55/module.h b/src/ipa/mali-c55/module.h\n> index 13b34eb28395..91b9aeb85050 100644\n> --- a/src/ipa/mali-c55/module.h\n> +++ b/src/ipa/mali-c55/module.h\n> @@ -7,7 +7,7 @@\n>   \n>   #pragma once\n>   \n> -#include <linux/mali-c55-config.h>\n> +#include <linux/media/arm/mali-c55-config.h>\n>   \n>   #include <libcamera/ipa/mali-c55_ipa_interface.h>\n>   \n> diff --git a/src/ipa/mali-c55/params.h b/src/ipa/mali-c55/params.h\n> index 370f1b8b77bc..64be68583ddb 100644\n> --- a/src/ipa/mali-c55/params.h\n> +++ b/src/ipa/mali-c55/params.h\n> @@ -7,7 +7,7 @@\n>   \n>   #pragma once\n>   \n> -#include <linux/mali-c55-config.h>\n> +#include <linux/media/arm/mali-c55-config.h>\n>   #include <linux/videodev2.h>\n>   \n>   #include <libipa/v4l2_params.h>\n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 69df2a39fc77..ce2469ed19c4 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -13,9 +13,9 @@\n>   #include <string>\n>   #include <variant>\n>   \n> -#include <linux/mali-c55-config.h>\n>   #include <linux/media-bus-format.h>\n>   #include <linux/media.h>\n> +#include <linux/media/arm/mali-c55-config.h>\n>   \n>   #include <libcamera/base/log.h>\n>   #include <libcamera/base/utils.h>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EA24BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  4 May 2026 09:12:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C868762DC4;\n\tMon,  4 May 2026 11:12:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14D786271A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  4 May 2026 11:12:09 +0200 (CEST)","from [192.168.33.78] (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 364C79C;\n\tMon,  4 May 2026 11:12:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AlrBECdR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777885927;\n\tbh=GB+X3u9S500zUBue0EF1c5vtIXNFbaB3tVPQcFfIAl0=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=AlrBECdRJ9fUOmIQvqjfrz7Tr5oBrgk9OMA+ADoUrn5XE+3EuP9gk0MdnoxwbSDfn\n\t0qzYErBQAl1Qr1fhKXO/oG9Yv5fFeK3AjRsgGKJrjMzjsceglhk2JUbqCiGtyqmX2H\n\ti0fxX6A2m8CKREhYggzYtGqTa7Wzvxr3YQ59bIAA=","Message-ID":"<705c4bf8-8da4-4cd5-9056-36ca85cb6e6c@ideasonboard.com>","Date":"Mon, 4 May 2026 11:12:04 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/6] include: linux: Move mali-c55-config.h header to\n\tcorrect location","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260504000431.1340150-1-laurent.pinchart@ideasonboard.com>\n\t<20260504000431.1340150-2-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260504000431.1340150-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]