[{"id":38725,"web_url":"https://patchwork.libcamera.org/comment/38725/","msgid":"<85v7d22g4a.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-05-05T12:30:29","subject":"Re: [PATCH] ipa: simple: data: Add OV01A10 tuning file","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"d3vv3 writes:\n\n> Add tuning data for the OmniVision OV01A10 sensor with black level,\n> colour correction matrix, and AGC parameters tuned to suppress\n> exposure oscillation on this sensor.\n>\n> Signed-off-by: d3vv3 \n> ---\n> src/ipa/simple/data/meson.build | 1 +\n> src/ipa/simple/data/ov01a10.yaml | 25 +++++++++++++++++++++++++\n> 2 files changed, 26 insertions(+)\n> create mode 100644 src/ipa/simple/data/ov01a10.yaml\n>\n> diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build\n> index 92795ee4..e6110320 100644\n> --- a/src/ipa/simple/data/meson.build\n> +++ b/src/ipa/simple/data/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> conf_files = files([\n> + 'ov01a10.yaml',\n> 'uncalibrated.yaml',\n> ])\n> \n> diff --git a/src/ipa/simple/data/ov01a10.yaml b/src/ipa/simple/data/ov01a10.yaml\n> new file mode 100644\n> index 00000000..9b3b8007\n> --- /dev/null\n> +++ b/src/ipa/simple/data/ov01a10.yaml\n> @@ -0,0 +1,25 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - BlackLevel:\n\nIs the black level value known?\n\n> + - Awb:\n> + maxGainR: 2.0\n> + maxGainB: 2.0\n> + speed: 0.25\n> + - Ccm:\n> + ccms:\n> + - ct: 6500\n> + ccm: [ 1.5000, -0.8000, 0.3500,\n> + -0.1000, 0.9500, 0.0000,\n> + -0.3000, -0.1000, 1.4500 ]\n\nWhere do these values (Awb, Ccm) come from? It would be good to mention\nthis in the commit message.\n\nAnd if I'm not mistaken, the sum of each of the matrix rows should be\n1.0.\n\n> + - Adjust:\n> + gamma: 2.2\n> + contrast: 1.0\n> + saturation: 1.0\n> + - Agc:\n> + exposureTarget: 1.4\n> + hysteresis: 0.5\n> + stepDenominator: 20\n> +...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9257CBE173\n\tfor ;\n\tTue, 5 May 2026 12:31:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BD706301E;\n\tTue, 5 May 2026 14:31:02 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE3AC62FE8\n\tfor ;\n\tTue, 5 May 2026 14:31:00 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-304-UQtYFKVRMGeZ7AJ2V5vBdA-1; Tue, 05 May 2026 08:30:58 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-4470d6d2a4fso6021206f8f.1\n\tfor ;\n\tTue, 05 May 2026 05:30:57 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([213.175.46.86])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-45052a48b23sm4527112f8f.14.2026.05.05.05.30.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 May 2026 05:30:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"We7zLjI5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777984259;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=xWE8+ZSmkFqQ0fU+lSmLJt5QDs/ROl7fwqvP6/LdFJg=;\n\tb=We7zLjI53M5MYIP5oSTlZUQKi+kf2VdGyxRkHmBWMDS/hin6Rl0l05MOs13VTADk9l5SaL\n\tJRNWgN6fTciV0NEfo7wApt/jaPgSS+IUSqbdhR392rZ4WwSWVTxcqeRTRrh906FpP3owT6\n\tFMI88jdFe3jiampfRWmis6W2ry30qvo=","X-MC-Unique":"UQtYFKVRMGeZ7AJ2V5vBdA-1","X-Mimecast-MFC-AGG-ID":"UQtYFKVRMGeZ7AJ2V5vBdA_1777984257","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1777984256; x=1778589056;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=xWE8+ZSmkFqQ0fU+lSmLJt5QDs/ROl7fwqvP6/LdFJg=;\n\tb=fTUjDO+O4vhpRN9oflV2SXoHIVn+yxkMMVVSIC2e2tvxa9jZX9P0WQ7luD9roJql7/\n\ttzUaUZkTHo7ogMoIP5XeGxdnF60Zey/IN/UPFe2pvlb5S7hRnvv707+0sfeddZu35pBX\n\tBv2G+4oKFxHsfQtb2r9mu40nen2TOTdSdb4NVpkk0bm4E60TcJkI5SPHQasGbt9y1yif\n\tgyrV6qFt4amjDOyXODUO2bWqdkWNeh2xVbvx3bB0vk5cIOM7ks3blqJMAHp+FVu14jy2\n\tALKYUgC56FE5s03BgpeKkjiOgf0SDn6hZm22gM2ccpaV44+WXAglHf2l5tW11L30nktC\n\t8/YA==","X-Gm-Message-State":"AOJu0Ywuj7McKJffpeESGHcEpdvnJVNrFIfs89CHMy8rgElGCFW0tHUt\n\toymaNtoQUT3UB1pv0X7XXO4a57Ha8Smn5K2uvdr42kOo2xU405KgeV1AVnLnHZm+ibURisaDQfX\n\t19+1Yo7Edagd/ZIB2drHZh6fRkvirq9sAAdAncBp+vnueh99Qb+lxB3Xaegt6u86leZBtJu4ytl\n\t3ey5QhcmfNtnrnpEf7mlZ/zudWc/uvUHhf6r3hqHsjQsnnGFCG08L3Vjr6m8A=","X-Gm-Gg":"AeBDietlxZ6ypSjgCbm6+lOLILltmB3ACg35ExUtRuaeoshUiZi02vDw9zm0luQiun1\n\ty6UszqKkELgmE0Las88FLcv0olj7ZadRnNy+d/uU44vZEfOgYWbGrGoudsEK0TdiJRm2u0vbeko\n\tSrHz3Hmo7wzP4bkfwLl/nvqFUZ++dfwY/jdaW6mz1+8lYY4LsM82SOmwrfGwEa8BL50GeW4Jjpa\n\tsHbblBdnSrOqNoxLhBJuOyslu3LCnZcO+xJro4vNjBFDfEZWeco4TkRkXhtym8foEhmVaDTDnH3\n\tOUEOvMye0TS+JDSRW4gYHfS5ai9SdWrOIPvpEU/gStJLHnkTW9pthC4uD/ehlr9Tu5ycO3FGOSL\n\tcBg2AGT1URiWyOA9KstFVnG/jj7nbk7x/hy1JPVv7aJrH7dNz","X-Received":["by 2002:a05:6000:3110:b0:43f:e9ee:5610 with SMTP id\n\tffacd0b85a97d-44bb7cf19edmr25541093f8f.43.1777984247697; \n\tTue, 05 May 2026 05:30:47 -0700 (PDT)","by 2002:a05:6000:3110:b0:43f:e9ee:5610 with SMTP id\n\tffacd0b85a97d-44bb7cf19edmr25538520f8f.43.1777984231706; \n\tTue, 05 May 2026 05:30:31 -0700 (PDT)"],"From":"Milan Zamazal ","To":"d3vv3 ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: simple: data: Add OV01A10 tuning file","In-Reply-To":"<20260501191400.985920-3-devve.3@gmail.com> (d3vv3's message of\n\t\"Fri, 1 May 2026 21:13:11 +0200\")","References":"<20260501191400.985920-1-devve.3@gmail.com>\n\t<20260501191400.985920-3-devve.3@gmail.com>","Date":"Tue, 05 May 2026 14:30:29 +0200","Message-ID":"<85v7d22g4a.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"tXhzEZ_1lbsi5Kz7ZyUpKz41BGcm2kK6p48A8_56Nos_1777984257","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]